On 06/04/2011 13:07, Miklos Vajna wrote:
On Mon, Apr 04, 2011 at 11:22:52AM +0200, Bjoern
Michaelsen<bjoern.michael...@canonical.com> wrote:
On current debians (I just tried sid) and Ubuntus there is the no
classpath set in the system junit jar that also does not contain
hamcrest. Since this problem is widespread: How about checking, if
either:
- the jar sets an classpath in the manifest
- the jar contains hamcrest
and complain explicitly
"your junit jar neither sets a classpath nor includes hamcrest --
please provide a full junit jar or use --without-junit"
if neither is the case. This also helps people making the right choice
with the upstream jars, where both (including hamcrest and excluding
hamcrest) are available.
Doing this little additional testing might prevent some newcomers to
run away screaming (it might not be the first issue they hit on their
first build).
I'm attaching a patch that tries to implement this.
I've tested with our (Frugalware) junit jar where the classpath is in
manifest and also with upstream junit jar, which bundles hamcrest.
OK to push to libreoffice-3-4?
Miklos
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Have you tested in master before pushing it to 3-4. I think its best to
leave 3-4 as is for now till we test in master to confirm that nothing
breaks before commiting to 3-4
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
