Re: [Libreoffice] CREDITS.odt, http://www.libreoffice.org/about-us/credits/

While at it: My commits from around the year 2005 seem to have been missed causing my joining date to be listed as 2010. It would be great if it could be fixed as well. Thanks! On 01/26/2012 11:59 PM, Andras Timar wrote: > Hi, > > readlicense_oo/odt/CREDITS.odt is rather outdated. I would like to

Re: [Libreoffice] [Pushed] [PATCH]Bug 34425 - [EasyHack] formatting background color toolbar button

Marking this as pushed. I pushed it as two different patches - one for the translations and the other the easyhack. Thank you for the patches (I really liked the new behavior of the button). And sorry for the delay. Some nitpicking: - It would be great if you could use expand tabs (i.e. spaces inst

Re: [Libreoffice] getopt in sal/osl

On 02/01/2012 05:14 AM, Norbert Thiebaud wrote: Looking at gbuildifying idlc, I noticed the glibc hack to get a getopt implementation on platform that don't have a native one. so, I wrote a gnu-compatile implementation based on http://www.kernel.org/doc/man-pages/online/pages/man3/getopt.3.html

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

On Mon, 30 Jan 2012 22:35:46 +0100, Kohei Yoshida wrote: Hi, I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 cherry-picked to the 3-5 branch. It is probably too late for change like this to be in the 3-5-0 branch so I won't even tr

Re: [Libreoffice] getopt in sal/osl

On Tue, 2012-01-31 at 22:14 -0600, Norbert Thiebaud wrote: > Heads-up: > > Looking at gbuildifying idlc, I noticed the glibc hack to get a getopt > implementation on platform that don't have a native one. > > so, I wrote a gnu-compatile implementation based on > http://www.kernel.org/doc/man-page

[Libreoffice] getopt in sal/osl

Heads-up: Looking at gbuildifying idlc, I noticed the glibc hack to get a getopt implementation on platform that don't have a native one. so, I wrote a gnu-compatile implementation based on http://www.kernel.org/doc/man-pages/online/pages/man3/getopt.3.html and I intend to add it to osl for plat

Re: [Libreoffice] [PUSHED][PATCH] Support Komi-Zyrian and Komi-Permyak as text language for spell checking

Hi Harri, On Saturday, 2012-01-28 14:01:52 +0200, Harri Pitkänen wrote: > Attached patch (against master) adds two new languages (Komi-Zyrian and > Komi-Permyak) to the list of possible text languages. Please check if the > language codes I added to i18npool/inc/i18npool/lang.h are correct. Than

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45370, which changed state. Bug 45370 Summary: EDITING: Calculated cell contents not updated after copy - paste - delete of source values https://bugs.freedesktop.org/show_bug.cgi?id=45370 What|Old Value

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hello Le Tue, 31 Jan 2012 21:48:30 +0100, Noel Power a écrit: On 31/01/12 20:29, Kohei Yoshida wrote: Well, that's rather hard to do with the Options dialog, since you can freely switch between different option pages and we then would have to check the validity of all the option tab pages upo

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

Hi, On Tuesday, 2012-01-31 22:38:56 +0100, Markus Mohrhard wrote: > I think we now only need one more review to get this patch into 3-5-0. Pushed to 3-5-0 with my sign-off http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=8558246af43c01bc437c4884e5ff144d714dc848 Eike

[Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans

Attached patch fixes fdo#45453, which breaks datasheet display of all queries/tables (with more than twice the number of rows than fit on screen), if the database system does not properly support boolean types. The original bug report is about Firebird SQL. Please apply to libreoffice-3-5. I sup

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Lionel Elie Mamane changed: What|Removed |Added Depends on||45453 --- Comment #158 from Lionel

Re: [Libreoffice] Storage of user's configuration

Thank you for following up this thread, it worked ! Martin 2012/1/31 Stephan Bergmann > On 01/24/2012 09:38 PM, Stephan Bergmann wrote: > >> One thing that's already there, though, is that if you can indeed go >> with a single string-list property (lets assume you add it as >> org.openoffice.Of

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

Hi Peter, > > thanks for spotting and fixing this. I pushed a fix for that to master > last december and hoped for it to magically move to the 3-5 branch, > which it didn't. Sigh. > > http://cgit.freedesktop.org/libreoffice/core/commit/filter/source/xsltfilter/LibXSLTTransformer.cxx?id=80b8744a9750

[Libreoffice] Same expression on both sides of '&&' on editeng/source/accessibility/AccessibleStaticTextBase.cxx

Hello, Cppchecks reports this : core/editeng/source/accessibility/AccessibleStaticTextBase.cxx 346 duplicateExpression style Same expression on both sides of '&&'. Here are the lines : 342 void AccessibleStaticTextBase_Impl::CorrectTextSegment( TextSegment&aTextSegment,

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

Hi Markus, thanks for spotting and fixing this. I pushed a fix for that to master last december and hoped for it to magically move to the 3-5 branch, which it didn't. Sigh. http://cgit.freedesktop.org/libreoffice/core/commit/filter/source/xsltfilter/LibXSLTTransformer.cxx?id=80b8744a97502c10b87c2

[Libreoffice] Double Duplicate branches for if and else in sw/source/core/doc/ftnidx.cxx

Hello, Cppchecks reports this : core/sw/source/core/doc/ftnidx.cxx 195 duplicateBranch style Found duplicate branches for if and else. 284 duplicateBranch style Found duplicate branches for if and else. Here are the lines : 180 // Set the array number for all footnotes starti

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

On Tue, 2012-01-31 at 21:50 +0100, Markus Mohrhard wrote: > Hey, > > this patch fixes a crash in 3-5. We delete the thread while it is > still running. The patch just adds a Thread::join call to wait till > the thread is correctly termintated before the thread is deleted. > > I think the patch is

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

Hey, 2012/1/31 Kohei Yoshida : > On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: >> Hi Kohei, >> >> On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: >> >> > Well, for expediting the process (since the release of 3.5.0 is >> > nearing), could you take this over?  Sounds like you kn

[Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

Hey, this patch fixes a crash in 3-5. We delete the thread while it is still running. The patch just adds a Thread::join call to wait till the thread is correctly termintated before the thread is deleted. I think the patch is safe and should be applied to 3-5 and maybe even to 3-5-0. Regards, Ma

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 31/01/12 20:29, Kohei Yoshida wrote: Well, that's rather hard to do with the Options dialog, since you can freely switch between different option pages and we then would have to check the validity of all the option tab pages upon dismissal of the whole Options dialog... you're correct, just s

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45401, which changed state. Bug 45401 Summary: CRASH when XML filter settings XSLTs test https://bugs.freedesktop.org/show_bug.cgi?id=45401 What|Old Value |New Value -

[Libreoffice] [PUSHD][PATCH] Remove unused code

On Tue, 2012-01-31 at 20:03 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi Albert, On Tuesday, 2012-01-31 19:35:54 +0100, Albert Thuswaldner wrote: > > However something I noticed is that there are still some problems with > > entering the 'Prefix name" in the options, firstly the input box seems to be > > overwritten by the label ( part of the input/edit field for t

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On Tue, 2012-01-31 at 20:07 +, Noel Power wrote: > On 31/01/12 18:35, Albert Thuswaldner wrote: > >> Additionally you still can get the prefix name to > >> > be blank ( or at least I managed to do that ) by attempting to change > >> > the > >> > name by delete, when all the name is deleted y

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: > Hi Kohei, > > On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > > > Well, for expediting the process (since the release of 3.5.0 is > > nearing), could you take this over? Sounds like you know exactly what > > needs to get done,

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 31/01/12 18:35, Albert Thuswaldner wrote: Additionally you still can get the prefix name to > be blank ( or at least I managed to do that ) by attempting to change the > name by delete, when all the name is deleted you get a message saying the > sheet prefix is illegal ( actually I find tha

Re: [Libreoffice] [PUSHED] partial patch for fdo#44551 libvisio: arrow head shapes not imported properly

On 31/01/12 11:22, Fridrich Strba wrote: Hello, Bruno On 31/01/12 00:35, Bruno Girin wrote: Please find attached a partial patch to import line marker shapes from Visio files. I would appreciate a review to confirm whether I am on the right path or whether I should do something different. Yes

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

Hi Kohei, On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > Well, for expediting the process (since the release of 3.5.0 is > nearing), could you take this over? Sounds like you know exactly what > needs to get done, so it's probably better than me trying to figure this > out on my o

Re: [Libreoffice] tracking ODF compliance issues

Michael Stahl píše v Út 31. 01. 2012 v 14:26 +0100: > hi all, > > i'd like to have some easier way to track bugs related to ODF compliance > in the bugzilla. > > what would be the best way to do this: > - a new keyword, say "odf" or "odf_validation" > - a tracking bug, that depends on all indidua

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Hi Ivan, On Tuesday, 2012-01-31 21:31:11 +0400, Ivan Timofeev wrote: > >should remove the first occurrence, care to fix ? > > so the exact equivalent of > > mpSdCustomShow->Remove(pPage->GetSdrPage()) > > will be: > > SdCustomShow::PageVec::iterator it = std::find( > mpSdCustomShow->Pages

[Libreoffice] [PATCH] Remove unused code

This patch removes unused code as listed in unusedcode.easy From 4eaa8adb17c0334f08c83509644b45553254376e Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Tue, 31 Jan 2012 19:59:31 +0100 Subject: [PATCH] Remove unused code. --- chart2/source/view/axes/Tickmarks_Equidistant.cxx | 27 -

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi, > However something I noticed is that there are still some problems with > entering the 'Prefix name" in the options, firstly the input box seems to be > overwritten by the label ( part of the input/edit field for the prefix is > missing until you type ) Hmm, strange, I haven't notice that mys

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi, >        Well - hopefully six months away is not -so- far - but I appreciate > your pain. Of course - in theory with triple review features can get > into the -3-5 branch, but string changes are less welcome I suspect. > Well, for me it is not that important. I just wanted to make sure before

Re: [Libreoffice] [PUSHED][PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:44, Noel Power пишет: hey I've already proved my (non) STL credentials :-) , but.. if we are to believe the old code then mpSdCustomShow->Remove(pPage->GetSdrPage()); would call Container::Remove( void* p ) which would call Container::Remove( Container::GetPos( p ) ) which afaics de

Re: [Libreoffice] default build verbosity

On Tue, Jan 31, 2012 at 11:43 AM, Michael Stahl wrote: > hi all, > > a recurring problem with remote debugging newbie build problems is that > the default build is silent. > > i wonder if it would make sense to change that: > with default configure invocation, build system outputs the full command

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 17:31, Ivan Timofeev wrote: 31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().beg

[Libreoffice] default build verbosity

hi all, a recurring problem with remote debugging newbie build problems is that the default build is silent. i wonder if it would make sense to change that: with default configure invocation, build system outputs the full command to the terminal/log, and there is an explicit configure option to s

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().e

Re: [Libreoffice] [PUSHED][3.5][3.5.0] fix for fdo#44836 (leaking page breaks)

Michael Meeks píše v Út 31. 01. 2012 v 15:56 +: > On Tue, 2012-01-31 at 15:48 +0100, Cedric Bosdonnat wrote: > > I just fixed some remaining leaking page breaks. Could someone review > > and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? > > > > http://cgit.freedesktop.org

Re: [Libreoffice] [PUSHED 3-5] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

Hi julien2412, On Monday, 2012-01-30 12:24:07 -0800, julien2412 wrote: > Commited and pushed on master (commit > 10bfc4df5335c6cd2ae700df7485668d896998b5) > > PS : if it could be useful to push this on 3.5, just tell me :-) Just did so with my sign-off for 3-5, before someone with an incapable

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:20, Ivan Timofeev wrote: 31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomSh

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:17, Stephan Bergmann wrote: On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someon

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 15:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan nice cat

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On 31/01/12 17:31, Lubos Lunak wrote: > On Tuesday 31 of January 2012, Jan Holesovsky wrote: >> As a fix, I propose this: >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >> e9d9979b5b699e6840454 >> >> Just get rid of the background image; in my opinion, it even loo

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On 31/01/12 16:31, Lubos Lunak wrote: On Tuesday 31 of January 2012, Jan Holesovsky wrote: As a fix, I propose this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d e9d9979b5b699e6840454 Just get rid of the background image; in my opinion, it even looks better witho

[Libreoffice] [PUSHED] Re: [REVIEW] fdo#43965 fix RTF import of page break symbol

On 30/01/12 23:41, Miklos Vajna wrote: > Hi Michael, > > On Mon, Jan 30, 2012 at 10:07:50PM +0100, Michael Stahl > wrote: >>> See >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 >> >> seems that with this change not only the new LN_PFPageBreak

[Libreoffice] hoping that someone will be able to solve this problem - unable to build windows version using cygwin

I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in wiki.documentfoundation.org/Development/Windows_Build_Dependencies but I’m unable to build the release. Full logs (including getting the source) at pastebin.com/u/walterLO Release libreoffice 3-5

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I fixed the english terminology, according to the justifications by Regina. regards Olivier Em 31-01-2012 11:28, Regina Henschel escreveu: > Olivier Hallot schrieb: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi Regina >> >> It has

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 04:25 PM, Michael Stahl wrote: default argument would make officecfg depend on comphelper, so you couldn't use the new headers from comphelper implementation. I just moved configuration.hxx from unotools to comphelper today (to then be able to use the officecfg headers in comphel

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On Tuesday 31 of January 2012, Jan Holesovsky wrote: > As a fix, I propose this: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >e9d9979b5b699e6840454 > > Just get rid of the background image; in my opinion, it even looks > better without that, and is the least intr

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 03:06 PM, Lubos Lunak wrote: How usual is the case that one does not want to pass comphelper::getProcessComponentContext() to all these functions? Or in other words, why not simply make it the default argument value? Default value indeed looks like a smart move. (In principle,

[Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

Hi, https://bugs.freedesktop.org/show_bug.cgi?id=42543 When you use the report designer, at some stage you get to a page (step 2) which is blank; but when you click there, you can edit the data. The problem is that commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=efc6b840a0423099d

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 05:19 PM, Noel Grandin wrote: I ran make check at the global level - does that not invoke the individual modules check targets? It does. Strange anyway. This failure is consistently reproducible for me and looks suspiciously like the remove problem discussed in this thread...

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomShow->Remove(pPage->GetSdrPage()); <- using

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

I ran make check at the global level - does that not invoke the individual modules check targets? On 2012-01-31 18:17, Stephan Bergmann wrote: Looks like you missed to run make check: LOG> 1. removeByIndex("1") ...OK LOG> removing a non existent object to get an exception LOG> 2. removeByInde

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42543, which changed state. Bug 42543 Summary: Report Designer Wizard missing Label display and editing capability https://bugs.freedesktop.org/show_bug.cgi?id=42543 What|Old Value |New

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someone else will spot it. Anyway thanks again for

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hello, On 31/01/12 17:10, Michael Meeks wrote: > Interesting (in a world with infinite time); would the mingw > cross-compile be call-catcher-able such that we could get a more precise > and comprehensive list ? Yes, at the level of callcatcher 1.1.3, I added the support for gnu assembler f

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 16:10 +, Michael Meeks wrote: > On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > > cc'ing Caolán as he might be interested because it doesn't turn up in > > > the unused.easy > > > > Its windows only co

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

thanks, still working out how this STL stuff hangs together. On 2012-01-31 17:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > cc'ing Caolán as he might be interested because it doesn't turn up in > > the unused.easy > > Its windows only code, and callcatcher can only see what gets compiled > as its just a

Re: [Libreoffice] [REVIEW][3.5][3.5.0?] fix for fdo#44836 (leaking page breaks)

On Tue, 2012-01-31 at 15:48 +0100, Cedric Bosdonnat wrote: > I just fixed some remaining leaking page breaks. Could someone review > and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=9babbf346c4d6f76e8b3a243a00e73a1

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan ___ Li

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

Rainer Bielefeld bielefeldundbuss.de> writes: > > Hi, > > Concerning the Virus Kazy.7720 Problem: Can you all please contact > support of your Antivirus Program supplier so that they can check and > rework their filters? So we can save much trouble with false alarms > normal users would see

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 34432, which changed state. Bug 34432 Summary: firebird ODBC: LibO crashes on 64 bits https://bugs.freedesktop.org/show_bug.cgi?id=34432 What|Old Value |New Value

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? On 2012-01-31 17:24, Ivan Timofeev wrote: 31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

On Tue, 2012-01-31 at 00:00 +0100, Regina Henschel wrote: > The term "inverse" is not correct in this context. It should be > "reciprocal" instead. > Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC. I agree Regina, you have unusually good English :-) Any chance

Re: [Libreoffice] Simplified C++ configuration access

On 31/01/12 15:06, Lubos Lunak wrote: > On Tuesday 31 of January 2012, Stephan Bergmann wrote: >> To get a property's value, all that is needed is to call the wrapper >> class's static officecfg::Foo::Bar::Baz::Whatever::get member function, >> which requires the XComponentContext as argument (use

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed somethin

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 11:31 AM, Stephan Bergmann wrote: At the next level, the new unotools/configuration.hxx header provides type-safe C++ wrappers for the various configuration entities on top of the lower level UNO services. For example, the utl::ConfigurationProperty class template can be used to wra

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

Hi Eike, On Tue, 2012-01-31 at 14:27 +0100, Eike Rathke wrote: > Hi Kohei, > > On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > > > I'd like > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > > > cherry-picked to the 3-5 bra

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Hi Petr, Cedric, all, On 2012-01-31 at 15:26 +0100, Petr Mladek wrote: > Looked fine. Worked reasonable => pushed into 3-5-0, see > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > http://cgit.freedesktop.org/libreoffice/core/c

[Libreoffice] [REVIEW][3.5][3.5.0?] fix for fdo#44836 (leaking page breaks)

Hi all, I just fixed some remaining leaking page breaks. Could someone review and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? http://cgit.freedesktop.org/libreoffice/core/commit/?id=9babbf346c4d6f76e8b3a243a00e73a173c16ba6 Thanks, -- Cedric _

[Libreoffice] R: R: Fatal error building Windows release (Cygwin)

The suggestion doesn't solve the problem. Regards Walter >>> cd xmlreader rm -Rf wntmsci12.pro build ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35669, which changed state. Bug 35669 Summary: Incorrect cross-references to illustrations and equations in master documents https://bugs.freedesktop.org/show_bug.cgi?id=35669 What|Old Value

Re: [Libreoffice] [PUSHED:3-5-0]]Fix for annoying bug fdo#35669

Updated subject. Petr Mladek píše v Út 31. 01. 2012 v 15:26 +0100: > Looked fine. Worked reasonable => pushed into 3-5-0, see > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > http://cgit.freedesktop.org/libreoffice/core/commit

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 31/01/12 12:46, openoff...@schierla.de wrote: Noel Power wrote: I cc some writer experts who may suggest some alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Noel Power píše v Út 31. 01. 2012 v 11:24 +: > On 30/01/12 17:16, Cedric Bosdonnat wrote: > > Hi Michael, > > > > On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > >> On 26/01/12 19:30, Michael Stahl wrote: > >>> On 26/01/12 16:21, Cedric Bosdonnat wrote: > Hi all, > > Co

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

sorry, that should be "converted to std::vector" On 2012-01-31 16:22, Noel Grandin wrote: Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___

[Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx index 98f2df5..c8b1495 100644 --- a/sd/sou

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 30/01/12 13:54, Noel Grandin wrote: Hi Attached patch converts SdCustomShow to use std::vector. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html I hate these remove list etc. type patches as they tend to be tricky and tim

[Libreoffice] R: R: Fatal error building Windows release (Cygwin)

A simple question. How can you compile The MASTER Win-x86_7-MinGW without any error ? Which environment is used ? Regards Walter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

Re: [Libreoffice] Simplified C++ configuration access

On Tuesday 31 of January 2012, Stephan Bergmann wrote: > To get a property's value, all that is needed is to call the wrapper > class's static officecfg::Foo::Bar::Baz::Whatever::get member function, > which requires the XComponentContext as argument (use > comphelper::getProcessComponentContext in

Re: [Libreoffice] R: Fatal error building Windows release (Cygwin)

yeah, the gbuild code that figures out the INCLUDE path is obviously a little wonky. As this point all I can suggest is doing: cd xmlreader rm -Rf wntmsci12.pro build Sometimes that sorts it out. On 2012-01-31 15:31, walter wrote: The problem is Cannot open include file: 'sal/config.h' bu

[Libreoffice] master vs. 3.5 regression ... (vcl/python) ...

Hi guys, I just noticed this printing: https://bugs.freedesktop.org/show_bug.cgi?id=45303 from master; looks like a particularly exciting memory corruption regression between python and vcl somewhere. Prolly of my own creation, but I wonder if it rings any bells. Supposedly it is

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi Ivan, On Tuesday, 2012-01-31 12:55:50 +0400, Ivan Timofeev wrote: > just added ':' to the sequence of characters > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a9d8c07ddf054930e1b000cc3c972a3d217d71c Yup, good catch. Technically there's also the limitation that a ' single quote ch

[Libreoffice] R: Fatal error building Windows release (Cygwin)

The problem is Cannot open include file: 'sal/config.h' but this file exists in my 'git/libo/sal/inc/sal' directory !! Regards Walter = (1/1) Building module xmlreade

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

Olivier Hallot schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Regina It has been decades since I handled groups, rings, fields, and functions in my french lycée. Now I am confused because it looks like the two terms are swapped between french and english... Regards Olivier In fren

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

Hi Kohei, On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > I'd like > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > cherry-picked to the 3-5 branch. It is probably too late for change > like this to be in the 3-5-0 branch so

[Libreoffice] tracking ODF compliance issues

hi all, i'd like to have some easier way to track bugs related to ODF compliance in the bugzilla. what would be the best way to do this: - a new keyword, say "odf" or "odf_validation" - a tracking bug, that depends on all indidual ODF related bugs the OpenOffice.org issuezilla used a "odf_valida

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > cc'ing Caolán as he might be interested because it doesn't turn up in > the unused.easy Its windows only code, and callcatcher can only see what gets compiled as its just a compiler wrapper and I run it under Linux. C. __

Re: [Libreoffice] Fatal error building Windows release (Cygwin)

looks like it's failing in the xmlreader module (part6 of your pastebin logs), but I don't know why. try doing this: source ./Env.Host.sh cd xmlreader build On 2012-01-31 14:59, walter wrote: I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in w

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 12:23 PM, Michael Meeks wrote: Sounds like a great cleanup, I vaguely advertised it in my blog. Would it be possible to have a simple "convert just one-key" patch to some old code so newbies can get their cookie cutters correctly calibrated :-)

[Libreoffice] Fatal error building Windows release (Cygwin)

I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in wiki.documentfoundation.org/Development/Windows_Build_Dependencies but I’m unable to build the release. Full logs (including getting the source) at pastebin.com/u/walterLO Release libreoffice 3-5

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

Noel Power wrote: > I cc some writer experts who may suggest some > alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour wrapped drawing objects). > Can you confirm you

[Libreoffice] [PATCH] unusedcode.easy: Removed unused code (basegfx)

--- basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx |3 - basegfx/inc/basegfx/polygon/b2dpolygon.hxx | 20 basegfx/inc/basegfx/polygon/b3dpolygon.hxx |3 - basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx |3 - basegfx/inc/basegfx/range/b1drange.hxx |

Re: [Libreoffice] Storage of user's configuration

On 01/31/2012 12:37 PM, Michael Meeks wrote: Incidentally - do we expect that all properties will end up with a nillable="false" attribute on them in the end ? :-) No. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org htt

Re: [Libreoffice] [PATCH] Remove unused code

On 31/01/12 11:05, Elton Chung wrote: Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. ok, pushed, thank, ps. next time don't chop off the header of the formatted patch 'cause '

Re: [Libreoffice] [PUSHED] [3.5.0] Some simple polish for named ranges dialogue

2012/1/31 Noel Power : > On 30/01/12 19:21, Petr Mladek wrote: >> >> Stefan Knorr (Astron) píše v Po 30. 01. 2012 v 09:45 +0100: >>> >>> Hi, >>> >>> I know this is extremely late for a simple polish fix, but please >>> consider >>> >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cb0a4

  1   2   >