Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/#review65831 --- I think the approach taken by kdelibs (commit 7c7a47575f1f57b

Re: Review Request 119815: Do not clear message on sending while disconnected

2014-09-05 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119815/#review65834 --- kopete/chatwindow/chatview.h

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/ --- (Updated Sept. 5, 2014, 1:52 p.m.) Review request for Kopete and Pali Roh

Re: Review Request 119815: Do not clear message on sending while disconnected

2014-09-05 Thread Roman Nazarenko
> On Сен. 5, 2014, 1:39 п.п., Pali Rohár wrote: > > kopete/chatwindow/chatview.h, line 233 > > > > > > I'm not sure if adding new virtual function will not break ABI. Need to > > check: > > https://techbase.kde

Re: Review Request 119815: Do not clear message on sending while disconnected

2014-09-05 Thread Pali Rohár
> On sep. 5, 2014, 3:39 popoludní, Pali Rohár wrote: > > kopete/chatwindow/chatview.h, line 233 > > > > > > I'm not sure if adding new virtual function will not break ABI. Need to > > check: > > https://techbas

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/#review65838 --- protocols/wlm/wlmchatsession.cpp

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/ --- (Updated Sept. 5, 2014, 4:45 p.m.) Review request for Kopete and Pali Roh

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raymond Wooninck
> On Sept. 5, 2014, 2:27 p.m., Raphael Kubo da Costa wrote: > > protocols/wlm/wlmchatsession.cpp, line 493 > > > > > > Shouldn't you check if `GIFLIB_MINOR` is defined too? I brought the patch inline with the ch

KOPETE

2014-09-05 Thread meduza
Hello Dev Team, i would like to ask you if the plugin for polish IM GG(gadu-gadu) are implemented in KOPETE that is incl. in "KDE for Windows"? As see is there no plugin for GG(gadu-gadu) so may needs just to add the lib for GG(gadu-gadu) IM - but how?   Thanks in advance for any sugestion.  

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/#review65860 --- Ship it! Ship It! - Raphael Kubo da Costa On Sept. 5, 2014

Re: KOPETE

2014-09-05 Thread Pali Rohár
On Friday 05 September 2014 13:24:17 med...@gmx.com wrote: > Hello Dev Team, > i would like to ask you if the plugin for polish IM > GG(gadu-gadu) are implemented in KOPETE that is incl. in "KDE > for Windows"? As see is there no plugin for GG(gadu-gadu) so > may needs just to add the lib for GG(ga

Re: Review Request 120047: Make kopete build with giflib 5.1.0

2014-09-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/ --- (Updated Sept. 5, 2014, 9:41 p.m.) Status -- This change has been ma