> On Sept. 5, 2014, 2:27 p.m., Raphael Kubo da Costa wrote: > > protocols/wlm/wlmchatsession.cpp, line 493 > > <https://git.reviewboard.kde.org/r/120047/diff/2/?file=309934#file309934line493> > > > > Shouldn't you check if `GIFLIB_MINOR` is defined too?
I brought the patch inline with the change that was done in kdelibs. There neither GIFLIB_MAJOR nor GIFLIB_MINOR is tested for being defined. > On Sept. 5, 2014, 2:27 p.m., Raphael Kubo da Costa wrote: > > protocols/wlm/wlmchatsession.cpp, line 494 > > <https://git.reviewboard.kde.org/r/120047/diff/2/?file=309934#file309934line494> > > > > There shouldn't be a space before ");" Fixed. - Raymond ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/#review65838 ----------------------------------------------------------- On Sept. 5, 2014, 1:52 p.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120047/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 1:52 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Bugs: 335519 > http://bugs.kde.org/show_bug.cgi?id=335519 > > > Repository: kopete > > > Description > ------- > > Giflib 5.1.0 introduced some API changes with regards to EGifCloseFile and > takes now an extra argument. > > > Diffs > ----- > > protocols/wlm/wlmchatsession.cpp 4843791 > > Diff: https://git.reviewboard.kde.org/r/120047/diff/ > > > Testing > ------- > > Builds fine with both giflib < 5.1.0 and with giflib 5.1.0 > > > Thanks, > > Raymond Wooninck > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
