----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120047/#review65831 -----------------------------------------------------------
I think the approach taken by kdelibs (commit 7c7a47575f1f57b5c0cc704826a5e5059939bbae -- it fixes calls to `DGifCloseFile`, but the idea is the same) is cleaner, as you can have the `#ifdef`s in a single place (also, watch our for the trailing white space). - Raphael Kubo da Costa On Sept. 3, 2014, 2:14 p.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120047/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 2:14 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Bugs: 335519 > http://bugs.kde.org/show_bug.cgi?id=335519 > > > Repository: kopete > > > Description > ------- > > Giflib 5.1.0 introduced some API changes with regards to EGifCloseFile and > takes now an extra argument. > > > Diffs > ----- > > protocols/wlm/wlmchatsession.cpp 4843791 > > Diff: https://git.reviewboard.kde.org/r/120047/diff/ > > > Testing > ------- > > Builds fine with both giflib < 5.1.0 and with giflib 5.1.0 > > > Thanks, > > Raymond Wooninck > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
