> On sep. 5, 2014, 3:39 popoludní, Pali Rohár wrote: > > kopete/chatwindow/chatview.h, line 233 > > <https://git.reviewboard.kde.org/r/119815/diff/1/?file=305925#file305925line233> > > > > I'm not sure if adding new virtual function will not break ABI. Need to > > check: > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > Roman Nazarenko wrote: > Why would we preserve ABI? Kopete is an application, not library, and > those virtual functions should not affect libkopete as far as I can see.
Kopete has some shared libraries which should not break ABI (there were some external plugins and protocol). Also distributions checking for ABI breaking when packaging these shared libraries... - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119815/#review65834 ----------------------------------------------------------- On aug. 17, 2014, 5:50 popoludní, Liza Lukicheva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119815/ > ----------------------------------------------------------- > > (Updated aug. 17, 2014, 5:50 popoludní) > > > Review request for Kopete. > > > Bugs: 227488 > http://bugs.kde.org/show_bug.cgi?id=227488 > > > Repository: kopete > > > Description > ------- > > When trying to send a message in offline mode, application shows a message > asked to connect and cleared text input. Now text field is cleared only if > message has been succesfully sent. > > > Diffs > ----- > > kopete/chatwindow/chattexteditpart.h 0cf4393 > kopete/chatwindow/chattexteditpart.cpp 83d34ec > kopete/chatwindow/chatview.h ca1965d > kopete/chatwindow/chatview.cpp f92d5fe > kopete/chatwindow/kopetechatwindow.cpp 9df17a5 > kopete/chatwindow/kopeteemailwindow.h c931110 > kopete/chatwindow/kopeteemailwindow.cpp 7bb04b2 > libkopete/kopetechatsession.h fe594fe > libkopete/kopetechatsession.cpp 3bc0d9c > protocols/jabber/jabberchatsession.cpp cc2ef50 > > Diff: https://git.reviewboard.kde.org/r/119815/diff/ > > > Testing > ------- > > > Thanks, > > Liza Lukicheva > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
