Re: [Kicad-developers] Default Canvas for v5

2018-01-04 Thread Wayne Stambaugh
Jon, That fixed it. I merged your patch into the dev branch. Thank you for your contribution. Cheers, Wayne On 01/04/2018 09:27 AM, Jon Evans wrote: > Hi Wayne, try the attached version to fix this. > > On Thu, Jan 4, 2018 at 9:11 AM, Wayne Stambaugh > wrote: >

Re: [Kicad-developers] Default Canvas for v5

2018-01-04 Thread Jon Evans
Hi Wayne, try the attached version to fix this. On Thu, Jan 4, 2018 at 9:11 AM, Wayne Stambaugh wrote: > It compiles now but I found an issue. If the user runs pcbnew with the > OpenGL canvas selected, switches to the legacy canvas, and closes > pcbnew, the dialog will show up the next time the

Re: [Kicad-developers] Default Canvas for v5

2018-01-04 Thread Wayne Stambaugh
It compiles now but I found an issue. If the user runs pcbnew with the OpenGL canvas selected, switches to the legacy canvas, and closes pcbnew, the dialog will show up the next time they launch pcbnew. If the user is already using the OpenGL canvas, then showing the dialog after the user switche

Re: [Kicad-developers] Default Canvas for v5

2018-01-04 Thread Jon Evans
Sorry about that, attached the wrong patch file. On Thu, Jan 4, 2018 at 8:39 AM, Wayne Stambaugh wrote: > Hey Jon, > > Did you forget to add a file to this patch? I'm getting the following > build error: > > CMakeFiles/gerbview_kiface.dir/gerbview_frame.cpp.o: In function > `GERBVIEW_FRAME::GER

Re: [Kicad-developers] Default Canvas for v5

2018-01-04 Thread Wayne Stambaugh
Hey Jon, Did you forget to add a file to this patch? I'm getting the following build error: CMakeFiles/gerbview_kiface.dir/gerbview_frame.cpp.o: In function `GERBVIEW_FRAME::GERBVIEW_FRAME(KIWAY*, wxWindow*)': /home/wayne/src/kicad/kicad-trunk/gerbview/gerbview_frame.cpp:218: undefined reference

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Jon Evans
Hi Wayne, Nick, Updated patch attached with your suggestions. -Jon On Wed, Jan 3, 2018 at 3:36 PM, Nick Østergaard wrote: > Hmm, maybe it is ok to use the technical terms OpenGL and Cairo in the > help text for the menu item. Afterall those terms have been used a lot in > help forums and launc

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Nick Østergaard
Hmm, maybe it is ok to use the technical terms OpenGL and Cairo in the help text for the menu item. Afterall those terms have been used a lot in help forums and launchpad, so it may make it easier for the curious to discover. 2018-01-03 21:15 GMT+01:00 Wayne Stambaugh : > There is also wxRichMess

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Wayne Stambaugh
There is also wxRichMessageDialog[1] which has an optional checkbox for show once features. [1]: http://docs.wxwidgets.org/3.0/classwx_rich_message_dialog.html On 1/3/2018 3:13 PM, Jon Evans wrote: > I figured we might want to re-use this in the future if we ever have > additional "show once" thi

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Jon Evans
I figured we might want to re-use this in the future if we ever have additional "show once" things that are more complicated than yes/no (although I didn't make it with formbuilder). It would be fine to switch to a messagedialog. I can probably do that tonight. -Jon On Wed, Jan 3, 2018 at 3:09 P

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Wayne Stambaugh
John, I took a look at your patch. Is there any reason why you didn't use wxMessageDialog instead of creating wxFormbuilder project for such a simple dialog? It seems to me that wxMessageDialog would do the trick as it allows you to change the strings for the Ok and Cancel buttons. Other than th

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Wayne Stambaugh
I just pushed the fix for this (commit bf44d394). The project linked below mapped 100% without issue. I did move the final rescue to only be performed if the user runs the remapper. If the user closes the dialog without remapping, no project files are changed. If you find any other issues, plea

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Wayne Stambaugh
FYI, I found a remapping issue on windows only which I broke when attempting to resolve the symlink issue on posix systems. I should have a fix soon. Sorry about the issues. Cheers, Wayne On 1/3/2018 4:50 AM, Nick Østergaard wrote: > Please attempt to not derail a thread. This thread is about

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread Nick Østergaard
Please attempt to not derail a thread. This thread is about making the default canvas default or not about remapping. About remapping it is much more helpful if you create a bug report and include a project to test against. Den 3. jan. 2018 10.23 AM skrev "André S." : > Hi, > > ok, I downloaded

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread kristoffer Ödmark
The same settings that were set during your first startup currently, but behind the scenes, a wizard would just give you the option of choosing, or going with the "default" On 2017-12-31 23:11, Simon Wells wrote: the big problem i have with setup wizards is it is not always obvious which opti

Re: [Kicad-developers] Default Canvas for v5

2018-01-03 Thread André S .
Hi, ok, I downloaded and installed the latest nightly. What a nightmare. :D I tried to open my schematic. It told me that it will be transferred to the new format and also showed a rescue dialog. It tries to map the symbols to the symbol library table. Afterwards it could not find the symbols i

Re: [Kicad-developers] Default Canvas for v5

2018-01-02 Thread Jeff Young
I stand corrected. ‘G’ in the middle of a segment does not work: it moves the closer segment end to the current position and drags the intersection from there. > On 2 Jan 2018, at 17:42, Jeff Young wrote: > > Since segments in OpenGL can be selected, the semantics are a bit different. > Sel

Re: [Kicad-developers] Default Canvas for v5

2018-01-02 Thread Jeff Young
Since segments in OpenGL can be selected, the semantics are a bit different. Select a segment and a ‘G’ near its end gives you get drag-intersection behaviour while a ‘G’ in its middle gives you drag-segment. ‘M’ works in both cases as well: ‘M’ near an end gives you move-endpoint; ‘M’ in the

Re: [Kicad-developers] Default Canvas for v5

2018-01-02 Thread José Ignacio
On Tue, Jan 2, 2018 at 11:18 AM, André S. wrote: > Hi everyone, > > I want to add from a users view: > In the current KiCad 4.0.7 (Windows 64 bit) you can't drag traces in > OpenGL/Cairo, only in legacy. (With this I mean: move a segment of a trace > and it stays attached to the other segments of

Re: [Kicad-developers] Default Canvas for v5

2018-01-02 Thread André S .
Hi everyone, I want to add from a users view: In the current KiCad 4.0.7 (Windows 64 bit) you can't drag traces in OpenGL/Cairo, only in legacy. (With this I mean: move a segment of a trace and it stays attached to the other segments of the trace (Hotkey: 'G')). Hotkey 'M' moves segments in Op

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Simon Wells
the big problem i have with setup wizards is it is not always obvious which options will be or were set by the setup dialog Simon > On 1/01/2018, at 11:08 AM, Kristoffer Ödmark > wrote: > > There is still some functionality in it that is missing from what I gather. > > I do like the idea tha

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Kristoffer Ödmark
There is still some functionality in it that is missing from what I gather. I do like the idea that just having an "enable hw acceleration" button or switch in the nagdialog, it feels proffessional, and most people will try it i think. Also, these problems seems like there could be some benef

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
For your consideration, a patch is attached that implements the above. On Sun, Dec 31, 2017 at 2:24 PM, Jon Evans wrote: > I think that getting automatic OpenGL detection and recovery working for > 5.0 might be ambitious. > Maybe Chris can detail what the next steps are for his approach there,

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Kevin Cozens
On 2017-12-31 12:35 PM, Nick Østergaard wrote: We could also write about this in the release notes. That would be a good idea. +1 -- Cheers! Kevin. http://www.ve3syb.ca/ |"Nerds make the shiny things that distract Owner of Elecraft K2 #2172 | the mouth-breathers, and that's wh

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
I think that getting automatic OpenGL detection and recovery working for 5.0 might be ambitious. Maybe Chris can detail what the next steps are for his approach there, but in case we want to push that to a later release, here's what I propose: 1) Rename the View menu options based on my proposal "

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jeff Young
+1 No menu items. Just a checkbox for Enable Hardware Acceleration in Preferences. > On 31 Dec 2017, at 18:36, Andy Peters wrote: > >> - In the case of graphics glitches, inform the users in the FAQ/Manual >> that they can fall back to software renderer in the View menu. >> - Don't use the ter

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Andy Peters
> On Dec 31, 2017, at 11:06 AM, Tomasz Wlostowski > wrote: > > On 31/12/17 18:38, Nick Østergaard wrote: >> I don't think the term standard for Cairo is good. It is better to call >> it fallback or faillsafe. >> > > How about this: > > - Always start with OpenGL by default. > - If pcbnew cra

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
Do we actually need the legacy canvas anymore? I know we need the code in it for printing, but do we need the option to render the UI in legacy mode or could we hide that in some place less prominent than the view menu? It would be a lot less confusing if the only choice was between hardware accele

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
How about "Modern" instead of GAL for user-facing stuff? "Legacy" "Modern (Accelerated)" "Modern (Fallback)" On Dec 31, 2017 12:38, "Nick Østergaard" wrote: > I don't think the term standard for Cairo is good. It is better to call it > fallback or faillsafe. > > Calling it standard gives the im

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Tomasz Wlostowski
On 31/12/17 18:38, Nick Østergaard wrote: > I don't think the term standard for Cairo is good. It is better to call > it fallback or faillsafe. > How about this: - Always start with OpenGL by default. - If pcbnew crashes, fall back automagically to Cairo on the next launch. Inform that the rende

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Marco Ciampa
On Sun, Dec 31, 2017 at 12:04:29PM -0500, Jon Evans wrote: > How about something like this? > > [image: Inline image 1] > > (N.B. I agree with Andy, and think we could consider renaming the options > in the View menu to "Legacy", "Accelerated (OpenGL)" and "Standard (Cairo)" > or something like t

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Nick Østergaard
I don't think the term standard for Cairo is good. It is better to call it fallback or faillsafe. Calling it standard gives the impression that this is what they should choose, but really we want them to select OpenGL. Den 31. dec. 2017 18.12 <20%2017%2018%2012> skrev "Wayne Stambaugh" < stambau.

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Nick Østergaard
We could also write about this in the release notes. Den 31. dec. 2017 15.06 skrev "Jon Evans" : > On modern computers, the OpenGL canvas offers by far the best experience > for users. Until we have the code in place to be able to default to OpenGL > and safely / neatly fall back to Cairo if it d

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Wayne Stambaugh
Looks good to me. On 12/31/2017 12:04 PM, Jon Evans wrote: > How about something like this? > > Inline image 1 > > (N.B. I agree with Andy, and think we could consider renaming the > options in the View menu to "Legacy", "Accelerated (OpenGL)" and > "Standard (Cairo)" or something like that) >

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
How about something like this? [image: Inline image 1] (N.B. I agree with Andy, and think we could consider renaming the options in the View menu to "Legacy", "Accelerated (OpenGL)" and "Standard (Cairo)" or something like that) -Jon On Sun, Dec 31, 2017 at 11:40 AM, Andy Peters wrote: > > On

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Andy Peters
> On Dec 31, 2017, at 6:49 AM, Simon Wells > wrote: > > What about having the default set to cairo, and when the first/once run > dialog runs it talks about openGL (this goes against you already set to GAL) > but it allows a default that even if it crashes won’t requi

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jon Evans
On modern computers, the OpenGL canvas offers by far the best experience for users. Until we have the code in place to be able to default to OpenGL and safely / neatly fall back to Cairo if it doesn't work, I think there is value in telling new users (once) about the fact that they can switch to GL

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Wayne Stambaugh
This is possible solution as well. My concern with this is that users will ignore the message as users tend to do and start bitching about the performance. On 12/31/2017 08:49 AM, Simon Wells wrote: > What about having the default set to cairo, and when the first/once run > dialog runs it talks a

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Kristoffer Ödmark
My personal preference would be to show the nag-dialog only if the user has upgraded from a previous version of kicad, and only once. New users wouldnt have to be informed, and if possible fallback a fallback to the cairo solution instead of falling back to legacy might be tempting. Could ma

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Simon Wells
What about having the default set to cairo, and when the first/once run dialog runs it talks about openGL (this goes against you already set to GAL) but it allows a default that even if it crashes won’t require manually editing a configuration to make it workable Simon > On 1/01/2018, at 2:48

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Wayne Stambaugh
I spite of my disdain for nagware, I'll tolerate this under the following conditions: The current canvas is not already on one of the gal canvases. If the user is already using a gal canvas, a dialog to inform the user about the gal canvas is silly. It's a one shot dialog that never appears agai

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Jeff Young
+1 to the startup dialog idea. I think we also need to set reasonable transparencies in the layers so that it looks more like the default legacy canvas. > On 31 Dec 2017, at 10:09, Clemens Koller wrote: > > On 2017-12-31 03:53, Jon Evans wrote: >> I know this would be work for someone to do an

Re: [Kicad-developers] Default Canvas for v5

2017-12-31 Thread Clemens Koller
On 2017-12-31 03:53, Jon Evans wrote: > I know this would be work for someone to do and maybe I'd offer to do it if > the project leaders approve... > What about a one-time pop-up when first installing a release 5.0 that appears > if the config says the user was using legacy canvas, telling them

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Chris Pavlina
On Sun, Dec 31, 2017 at 03:40:00AM +, Jon Evans wrote: > Chris, I thought your kicad-ogltest was going to make it so we could use > OpenGL by default and then automatically fall back to Cairo if there was a > problem -- what ended up happening with that, is there a technical problem > or is it

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Jon Evans
Chris, I thought your kicad-ogltest was going to make it so we could use OpenGL by default and then automatically fall back to Cairo if there was a problem -- what ended up happening with that, is there a technical problem or is it just not there yet? I'll make a first-run dialog if Wayne approves

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Chris Pavlina
I like this. If you don't offer, everyone who's already used KiCad 4 and didn't realize they (c/sh)ould switch to GAL still won't notice that in KiCad 5. A first-run dialog would be a good idea IMO. On Sun, Dec 31, 2017 at 02:53:50AM +, Jon Evans wrote: > I know this would be work for someone

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread azonenb...@drawersteak.com
My recommendation is to make GL the default but detect problems and fall back when it doesn't work for some reason. -- Original message--From: Jon EvansDate: Sat, Dec 30, 2017 21:54To: Wayne Stambaugh;Cc: KiCad Developers;Subject:Re: [Kicad-developers] Default Canvas for v5 I know

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Jon Evans
I know this would be work for someone to do and maybe I'd offer to do it if the project leaders approve... What about a one-time pop-up when first installing a release 5.0 that appears if the config says the user was using legacy canvas, telling them about how to switch and that they should check i

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Wayne Stambaugh
I don't have any issues with this but it will only apply to new installs. Existing installs will have the last canvas selected in the user's kicad config. On 12/30/2017 04:36 PM, Kristoffer Ödmark wrote: > The power of defaults ;) > > This is also something I have encountered has turned a lot of

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Nick Østergaard
It has been a long time since I have seen reports from people saying they can start pcbnew becasue of opengl. So I think we can sort of safely enable it as a default. But at least pcbnew saves the canvas setting. 2017-12-30 22:36 GMT+01:00 Kristoffer Ödmark : > The power of defaults ;) > > This i

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Kristoffer Ödmark
The power of defaults ;) This is also something I have encountered has turned a lot of users away, because when they try it, they dont really like the setup. So even if they can change it, they give up before they realize they can. -Kristoffer On 12/30/2017 10:30 PM, Chris Pavlina wrote: On

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Chris Pavlina
On Sat, Dec 30, 2017 at 09:27:46PM +, Jeff Young wrote: > +1. > > (I used legacy for 6 months because I thought the only difference was in > rendering. I didn’t realise all the tools were different too….) I hear this a _lot_ from beginners. We're shipping so many cool new features that a su

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Jeff Young
+1. (I used legacy for 6 months because I thought the only difference was in rendering. I didn’t realise all the tools were different too….) Cheers, Jeff. > On 30 Dec 2017, at 21:13, Chris Pavlina wrote: > > Pleeease! > > It makes no sense to use a canvas we call "legacy" as default. GA

Re: [Kicad-developers] Default Canvas for v5

2017-12-30 Thread Chris Pavlina
Pleeease! It makes no sense to use a canvas we call "legacy" as default. GAL may still not have 100% feature parity to allow _removing_ legacy but it's totally ready to be the default. On Sat, Dec 30, 2017 at 08:51:53PM +, José Ignacio wrote: > Since the GAL is pretty much feature complet

[Kicad-developers] Default Canvas for v5

2017-12-30 Thread José Ignacio
Since the GAL is pretty much feature complete (I have used it exclusively for the last year and a half) and the Cairo canvas has much improved performance (it is *significantly* faster than legacy on my systems), should pcbnew make the switch to have Cairo as the default canvas? I understand OpenG