t left blocking forever.
There's also the question of why start_kdeinit is expected to disable OOM
protection instead of kdeinit doing it directly... in any event kdeinit has to
know OOM protection is in use and participates in the process. Perhaps it's a
kernel restriction but
ich
generated reasonable organization domains.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
with several KDE apps, all of which
generated reasonable organization domains.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 9e5f731c8f63d239172f76d826973042e7920dee by Michael Pyne
to branch master.
Bugs: 355508
https://bugs.kde.org/show_bug.cgi?id=355508
Repository: kcoreaddons
Description
On Mon, December 14, 2015 16:07:38 Martin Graesslin wrote:
> On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote:
> > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote:
> > > we are facing a problem during the startup of Plasma on Wayland. If OOM
> > >
QProcess. By reimplementing setupChildProcess I was able to fix the
> problem.
>
> Thanks a lot for pointing me in the right direction!
\o/
:)
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
d of NULL here, but that's mere quibbling
(though being bit once by a C-style NULL in C++ code in 64-bit code was more
than enough).
- Michael Pyne
On Dec. 15, 2015, 10:19 a.m., Martin Gräßlin wrote:
>
> ---
> This is an
all and the patch still
allowed kdeinit to exec processes (albeit noticeably slower), so seems to me it
should work. No other ill effects noted either.
- Michael Pyne
On Dec. 15, 2015, 10:19 a.m., Martin Gräßlin wrote:
>
> ---
> T
;s no real need to use QCache instead
of QMap, I would think.
Diffs
-
src/lib/plugin/desktopfileparser.cpp 06a4a1d
Diff: https://git.reviewboard.kde.org/r/126409/diff/
Testing
---
desktoptojsontest still passes, code compiles.
Thanks,
Michael Pyne
__
https://git.reviewboard.kde.org/r/126410/diff/
Testing
---
Everything compiles. Not much beyond done.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
desktoptojsontest still passes, code compiles.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
il. To reply, visit:
https://git.reviewboard.kde.org/r/126409/#review89679
-------
On Dec. 18, 2015, 3:44 a.m., Michael Pyne wrote:
>
> ---
> This is an automati
marked as submitted.
Review request for KDE Frameworks, Martin Klapetek and Valentin Rusu.
Changes
---
Submitted with commit 1d0bec904dd78ff21d1d68e9c3e363ad1a77f7ed by Michael Pyne
to branch master.
Repository: kwallet
Description
---
Fix a leak of a `FILE*` in kwalletd, spotted
e `defs << *def` in
> > the else block? Would remove the need for the temporary variable
> > declaration at the top.
> >
> > Switching the if/else would also make this easier to understand.
>
> Michael Pyne wrote:
> I prefer to factor loop invari
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126423/#review89792
---
Ship it!
Ship It!
- Michael Pyne
On Dec. 19, 2015, 8:34
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review89795
---
Ship it!
Revised patch looks good here.
- Michael Pyne
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126440/#review89796
---
Ship it!
Ship It!
- Michael Pyne
On Dec. 20, 2015, 10:44
marked as submitted.
Review request for KDE Frameworks and Alex Richardson.
Changes
---
Submitted with commit 95a1349d4ddb17c834f6a98e85b11814dcb807f8 by Michael Pyne
to branch master.
Repository: kcoreaddons
Description
---
Patch to fix a use-after-free issue in
kcoreaddons/src
6dba1a
src/xml/dom_docimpl.cpp 4f0be5c
Diff: https://git.reviewboard.kde.org/r/126480/diff/
Testing
---
Everything compiles, clicking around in Konq on various websites and opening
local XML files seems to work fine. I can't get CMake to build the autotests
however (tho
efcad8
Diff: https://git.reviewboard.kde.org/r/126481/diff/
Testing
---
Compiles. codectest and rfc2047test still pass, though I'm honestly not sure
how much of this codepath they might exercise.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde
f56a06
Diff: https://git.reviewboard.kde.org/r/126506/diff/
Testing
---
Builds, kdirmodeltest passes.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1
Diff: https://git.reviewboard.kde.org/r/126507/diff/
Testing
---
Everything builds and appears to still work, though it's hard to test K4Style
as I'm not sure what uses it right at this point.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing
part).
Diffs
-
src/kdesud/kdesud.cpp f991727
Diff: https://git.reviewboard.kde.org/r/126508/diff/
Testing
---
Builds but I'm not sure what even still uses kdesu in 2015...
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Testing
---
Builds, and I managed to login to a normal desktop with this code running, so
yay.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
iffs
-
src/kdeinit/kinit.cpp 80e70ae
Diff: https://git.reviewboard.kde.org/r/126509/diff/
Testing
---
Builds, and I managed to login to a normal desktop with this code running, so
yay.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit a401ab0561cdea234bcbbfe89e567c758f6b9fe4 by Michael Pyne
to branch master.
Repository: kdesu
Description
---
Don't leak fd when creating socket.
Coverity notes (CID 1289177) that we lea
ting
---
Builds, kdirmodeltest passes.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Daniel Vrátil.
Changes
---
Submitted with commit 543cbd6d2a02b82ad7832d26a01fcfeaca7898b7 by Michael Pyne
to branch master.
Repository: kcodecs
Description
---
Subject says it all. If we're going to note that a buff
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 45e4aea0e219ff1154c9e4fcc177f7c9fb9c7138 by Michael Pyne
to branch master.
Repository: kio
Description
---
Noted by Coverity (CID 1019869), and could result in a set of
---
Code still compiles.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 9543cc4058b24e4e5bfe8d324de309ca7050058b by Michael Pyne
to branch master.
Repository: kwallet-pam
Description
---
Coverity strikes again, and notes in CID 1335116 that copying the
'm not sure what uses it right at this point.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
src/kdecore/klockfile_unix.cpp 67283a5
src/kdeui/k4style.cpp a1a2ab1
Diff: https://git.reviewboard.kde.org/r/126507/diff/
Testing
---
Everything builds and appears to still work, though it's hard to test K4Style
as I'm not sure what uses it right at this
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit f4e9dbf2b4ee2770e554c735b7604637e7b5ec54 by Michael Pyne
to branch master.
Repository: kdelibs4support
Description
---
Fix a couple of Coverity issues:
1. CID 1175508; file descriptors used
g
---
Everything compiles, clicking around in Konq on various websites and opening
local XML files seems to work fine. I can't get CMake to build the autotests
however (though there aren't very many anyways).
Thanks,
Michael Pyne
_
e.org/r/127094/diff/
Testing
---
Compiles and installs, applications still seem to run.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 47fd753a9a7e19a446896362528f69f76fd03029 by Michael Pyne
to branch master.
Bugs: 359485
https://bugs.kde.org/show_bug.cgi?id=359485
Repository: kcoreaddons
Description
---
A bug reporter
to float is incomplete since the compiler still has to upcast to
double (for 100.0, which should be 100.0f to be treated as a float), and moving
the 100.0 to the beginning will force the rest of the expression to be treated
as a double anyways.
- Michael Pyne
On Feb. 21, 2016, 10:30 a.m.,
easier to revert the
switch/case portions of the patch, perhaps add warning suppressions instead?
- Michael Pyne
On Feb. 21, 2016, 5:39 p.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To re
marked as submitted.
Review request for KDE Frameworks, David Faure, Martin Tobias Holmedahl
Sandsmark, and Patrick Spendrin.
Changes
---
Submitted with commit 07bb493a5f62115bd6d61044a7b743cd10be3bec by Michael Pyne
to branch master.
Repository: khtml
Description
---
This is a
marked as 'change then
commit' (I missed that it was updated a few days ago when my email was futzy :(
).
- Michael Pyne
On April 23, 2016, 5:46 p.m., Andrius da Costa Ribas wrote:
>
> ---
> This is an automatically generat
f we're talking about Qt commit 1b9d082b, that appears to already be in the
5.6 branch (though not dev). I'm not sure which the CI uses though, if it's
not 5.6 or less then it is probably more work than its worth to try to
downgrade (something I've run into too much myself).
still running the
patched code a few months later so it certainly seems safe enough!).
- Michael Pyne
On Dec. 15, 2015, 10:19 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
involving combinations of
logically different tests in some cases (in other words I don't think I
accidentally coded the test to always pass).
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 8f5cdadca7fad0265204d5f9ff16bc8ca1c02f72 by Michael Pyne
to branch master.
Bugs: 362161
https://bugs.kde.org/show_bug.cgi?id=362161
Repository: kcoreaddons
Description
---
A very simple
x27;s more that should be covered but I think that would take
care of a large portion of any problems.
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
4491>
On other hand, initializing a KAboutData that hasn't already been set from
QCoreApplication makes sense. But I would move this into the if block above so
that it only runs when a KAboutData wasn't already availa
h. So Qt::UniqueConnection should be useless.
src/plasma/private/dataenginemanager.cpp
<https://git.reviewboard.kde.org/r/127795/#comment64502>
Is it safe to remove this, given that even the change to
DataEngineManager::loadEngine
>
Please either make this a static function or place it in an anonymous
namespace, no need to make this symbol visible in the compiled object file or
library.
- Michael Pyne
On May 3, 2016, 12:39 a.m., Friedrich W. H. Kossebau wrote:
>
> --
---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127655/
> -------
>
> (Updated May 4, 2016, 2:47 p.m.)
>
>
> Review request for KDE Frameworks, Alex Rich
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/#review95186
---
Ship it!
Ship It!
- Michael Pyne
On May 4, 2016, 2:47
as the KF5 stuff seems to require polkit to actually
work, which isn't possible with a homedir install like mine).
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
still seemed to work.
There's not a lot of autotests to choose from, but the KLocalizedString test
still passed.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinf
perly read, that the examples rendered as before, etc.
The Acid3 test makes it to 92/100, but I'm pretty sure it was only at 92/100
before this change as well. ;)
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
more.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
'm sure is a local misconfiguration...
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and kwin.
Changes
---
Submitted with commit f0510907d2247534b40b6176757156181ad499a0 by Michael Pyne
to branch master.
Repository: kwayland
Description
---
Coverity complains (in CID 1335150) about `Generator::parseInterface
n the event loop working or not.
Any objections to the rest?
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127833/#review95214
--------
marked as submitted.
Review request for KDE Frameworks, Localization and Translation (l10n) and
Chusslove Illich.
Changes
---
Submitted with commit 639ab84221434d29a2055fa090e14a8b0822779f by Michael Pyne
to branch master.
Repository: ki18n
Description
---
Coverity noted that some
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit b595f47f021cbcf1cee23cd0bee1df57a2e2f1b9 by Michael Pyne
to branch master.
Repository: oxygen
Description
---
oxygen windeco: Fix use-after-free for pixmap in QCache.
Coverity
Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127834/#review95259
-------
On May 7, 2016, 4:12 a.m., Michael Pyne wrote:
estWaylandOutputDevice class does not have an initializer for
m_queue within the constructor (or in any of the other class members it looked
at). But I don't see how that would be related either.
Regards,
- Michael Pyne
___
Kde-frameworks-dev
we could break the
test into two: 1) ensure order is properly saved and loaded, and 2) ensure
right items are present independent of their order.
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kd
NFO near the top of the file
with the other Windows-compatibility syslog defines.
- Michael Pyne
On May 7, 2016, 3:35 p.m., Allen Winter wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
diff/
Testing
---
Everything still compiles -- I'm limited in my ability to test since I'm still
using KDE4's KWallet (as the KF5 stuff seems to require polkit to actually
work, which isn't possible with a homedir install like mine).
Thanks,
Michael Pyne
buffer.
Diffs
-
src/kcrash.cpp 7d3b8a2
Diff: https://git.reviewboard.kde.org/r/127865/diff/
Testing
---
Compiles w/out warnings, kcrashtest passes.
Thanks,
Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-deve
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127865/#review95472
---
Ping?
- Michael Pyne
On May 8, 2016, 2:03 a.m., Michael
he only CSS
property that requires the second value/return value). I then used the DOM
Inspector tool to manually verify that the CSS background properties were
properly read, that the examples rendered as before, etc.
The Acid3 test makes it to 92/100, but I'm pretty sure it was
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 91e72d319bf99637dadbe4db5bac5305c954aa15 by Michael Pyne
to branch master.
Repository: kcrash
Description
---
Although we don't seem to run across this in practice, Coverity warns
oncur with
not bumping the cache version and agree with your patch. Thanks for taking a
look!
- Michael Pyne
On May 19, 2016, 6:13 p.m., Fabian Vogt wrote:
>
> ---
> This is an automatically generated e-mail. To re
hat you mean when you say we'd affect the currents script. What is your
plan for integrating this without breaking the scripts? Is there work needed by
others (sysadmin, EBN, etc.) to make apidox generation work with your patch
committed? What's the action KDE developers must take after thi
appropriate (e.g. 'Avoid race in
restricting cookie file perms' or something like that) but the change looks
correct to me.
- Michael Pyne
On May 19, 2016, 11:38 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatical
> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote:
> > This has been like this for years. Has any of the premises changed?
I think it's a good idea, if only to keep up with changes to the generated
sources to account for things like undefined behavior fixes, fixes for new
compiler warnin
> On May 19, 2016, 11:17 p.m., Michael Pyne wrote:
> > This is an error upstream in the MurmurHash 1.0 aligned implementation
> > (which still contains the error, see
> > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0
> > )
> >
nk. I'll look at revising the patch and then also testing with the
testcase you provided on Bugzilla.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12783
works but your plan sounds acceptable
so I'd say to go for it and we'll just pick up the pieces if there ends up
being breakage, we just need to be careful to either get everything done in
time to have time to resolve issues that might arise before KF5 5.23.
- Michael Pyne
On April 25,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127984/#review95687
---
Ship it!
Ship It!
- Michael Pyne
On May 21, 2016, 1:50
or kwalletmanager then
you should be able to use something like
options kwalletmanager
# your-options-here
end options
somewhere in your kdesrc-buildrc (as of kdesrc-build git from last month), and
kdesrc-build will use those options once the module shows up.
Re
e that the kde-build-metadata repository
has the right branch names for the modules (stored in the
logical-module-structure file) but I might audit that myself later as well. In
short if build.kde.org is happy with the KF5 modules kde-build-metadata is
probably correct.
- Michael Pyne
On Feb
ture" is up to date.
The kde-build-metadata module has a script to verify that you get the right
branch name so that you don't have to run kdesrc-build to validate the JSON or
ensure you got what you expected.
I might do this myself in the next day or so
f us were paying attention to the mailing list announcement
about the renames. ;)
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
to see extra-cmake-modules
didn't already have a branch-group entry so I've fixed that in
kde-build-metadata.
- Michael Pyne
On Feb. 14, 2014, 2:10 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generat
x27;kbuildsycoca5'? (which I
don't even know is still around in frameworks!).
Hopefully someone else has an idea.
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sat, February 15, 2014 20:35:28 David Faure wrote:
> On Thursday 13 February 2014 17:41:26 Michael Pyne wrote:
> > In the meantime I will fix kdesrc-build to fallback automatically to
> > git-clone like it's supposed to.
>
> There's two cases:
>
> - sn
sure if
that means it should be removed from startkde; I think we're trying to use
systemd/logind or something on Linux, which doesn't work with KDM.
Easiest thing to do would be to experiment and try having startkde keep going
if kstartupconfig5 fails and see what you get though.
of our DBus interfaces intended for
general programmatic consumption need to be async; I've been able to encounter
the most amazing deadlocks sometimes.
Of course this is both hard to do and hard to train/teach others to know how
to do. :-/
Regards,
- Michael Pyne
_
elf using kdesrc-build, shouldn't it take care of it
> for me? Seems a little user unfriendly that it's the one envvar I
> have to set when kdesrc-build takes care of the rest for me?
Yes, it should take care of it for you.
And as of now, it does.
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
l under our own namespace
if it's at all possible (and it's almost always possible). This kind of thing
happens to us every so often and it's always avoidable by naming things
correctly.
Regards,
- Michael Pyne
___
Kde-frameworks-devel m
work great (if by work I mean "compile" ;)
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
cumentation is available at
http://kdesrc-build.kde.org/documentation/, and if you build kdesrc-build it
should install
a man page to $KDEDIR/share/man/man1 or thereabouts.
I've recently become a big fan of --resume-from (or -after), --stop-before (or
-after) and --ignore-modules options mysel
specified", as opposed to "undefined behavior" where optimizers
start adding buffer overflows. So it still seems like the better answer here
unless we want to bring in some of those fancy image-swizzling graphics
libraries.
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Thu, February 27, 2014 11:35:16 Kevin Funk wrote:
> Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne:
> > On Wed, February 26, 2014 22:30:48 Milian Wolff wrote:
> > > Also, while at it, could we get a "truly verbose" flag, which actually
> > >
sing KIO::UDSEntry" at the top of the
file work instead? It doesn't actually matter, all the solutions are probably
equally a hack...
- Michael Pyne
On March 2, 2014, 8:20 p.m., Milian Wolff wrote:
>
> ---
> This is
On Tue, March 4, 2014 22:54:42 David Faure wrote:
> On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote:
> > kf5: Port rc files to use branch-groups consistently.
>
> Thanks!
>
> > This should be absolutely transparent except that "kde-kactivities" will
>
ak reference" to KSharedDataCache
without having to define KSharedDataCache. It might even be possible to
forward-declare KSharedDataCache and use a typedef instead but I didn't even
do the porting work here and that didn't occur to me when I was reviewing the
pa
g again?
It seems to be looking for Qt4 specifically. You might want to see if kdesrc-
build didn't accidentally switch the source git-branch to the KDE4 one instead
of KDE5 one (it should list the branch it's using as it updates the module).
Re
/community.kde.org/Frameworks/Porting_Notes
Regards,
- Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
nt to put a setgrent() here.
src/lib/util/kuser_unix.cpp
<https://git.reviewboard.kde.org/r/116798/#comment37272>
And a setgrent() here.
- Michael Pyne
On March 14, 2014, 2:30 p.m., Alexander Richardson wrote:
>
> -
, and all tests pass.
- Michael Pyne
On March 15, 2014, 4:02 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
unless they cleanly fit the problem.
src/lib/util/kuser_unix.cpp
<https://git.reviewboard.kde.org/r/116883/#comment37546>
A better name for "callback" would be something like "handleNextGroupUser"
or some other descriptive way of describing what the callback is actua
1 - 100 of 328 matches
Mail list logo
