----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126440/#review89796 -----------------------------------------------------------
Ship it! Ship It! - Michael Pyne On Dec. 20, 2015, 10:44 p.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126440/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2015, 10:44 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kinit > > > Description > ------- > > Fix some Clazy warnings in kinit: > - unneeded heap allocation with QString > - qEnvironmentVariableIsEmpty() non-usage > - isEmpty() non-usage > > > Diffs > ----- > > src/kdeinit/kinit.cpp a18008a > src/klauncher/klauncher.h e155f72 > src/klauncher/klauncher.cpp 8b3d343 > src/klauncher/klauncher_main.cpp 432e19a > src/wrapper.cpp 95b7ec2 > > Diff: https://git.reviewboard.kde.org/r/126440/diff/ > > > Testing > ------- > > Compiling without errors. > Automated tests pass. > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
