-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126189/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 3:51 a.m.)
Review request for KDE Frameworks and David Faure.
Changes
-------
- Change the domain stripping behavior to better match original behavior (the
original code could have stripped the domain to a single component, I have it
set to keep at least 2... should it be different?).
- Rebased against latest HEAD
- kaboutdatatest still passes
Bugs: 355508
https://bugs.kde.org/show_bug.cgi?id=355508
Repository: kcoreaddons
Description
-------
This commit permits URLs such as "https://www.foo.org"; (i.e. with non-http
schemas), which bug 355508 points out is something we don't currently support,
and expands the test suite to ensure http and https URLs give the same behavior
when deriving desktop file names and organization domains.
The existing code seems to operate the stripping the first URL host component
(e.g. www.foo.org -> foo.org) for the purposes of generating an organization
domain or desktop file name. I'm not sure if that was intentional or not, but I
found it easier to just limit to two components instead (e.g.
www.product.foo.org -> foo.org). Everything else should be pretty
straightforward for review I think... much of the code change is simply because
I tried to fix by making the current code scheme-independent instead of just
adding a '|| scheme == "https"'.
I also modified the API docs to reflect the change. I will add the appropriate
@since based on when I get a Ship It! ;)
Diffs (updated)
-----
src/lib/kaboutdata.h e9fc56b
src/lib/kaboutdata.cpp de19e6f
autotests/kaboutdatatest.cpp 96b3a13
Diff: https://git.reviewboard.kde.org/r/126189/diff/
Testing
-------
All tests pass in kaboutdatatest, including the extra test cases added to test
https:// URLs specifically.
I also had hacked in some qDebug()s and ran with several KDE apps, all of which
generated reasonable organization domains.
Thanks,
Michael Pyne
_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
