----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126362/#review89576 -----------------------------------------------------------
Ship it! I can confirm the change appears correct, though I'd like to try to force it to work myself if we can't get the broken kwin_wayland to trip the bug. One very minor comment but that's your call. src/kdeinit/kinit.cpp (line 465) <https://git.reviewboard.kde.org/r/126362/#comment61291> I'd recommend Q_NULLPTR instead of NULL here, but that's mere quibbling (though being bit once by a C-style NULL in C++ code in 64-bit code was more than enough). - Michael Pyne On Dec. 15, 2015, 10:19 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126362/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 10:19 a.m.) > > > Review request for KDE Frameworks and Michael Pyne. > > > Repository: kinit > > > Description > ------- > > If for whatever reason the child process does not get SIGUSR1, it > should not block an infinite time, but timeout and continue. > > > Diffs > ----- > > src/kdeinit/kinit.cpp a18008a11bf00a35aa0cab450180926217cd58f5 > > Diff: https://git.reviewboard.kde.org/r/126362/diff/ > > > Testing > ------- > > Seems to not work correctly yet as I don't hit the timeout condition with the > broken kwin_wayland. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
