---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126320/#review89394
---
+1, this also fixes plasma on mobile CI
- Bhushan Shah
On
ls/draganddrop/CMakeFiles/draganddropplugin_automoc.dir/build.make'
Resulting in all this chaos.. I've triggered rebuild of kdeclarative
and hopefully that will fix this.
Cheers!
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
On Mon, Feb 8, 2016 at 7:44 PM, Bhushan Shah wrote:
> Resulting in all this chaos.. I've triggered rebuild of kdeclarative
> and hopefully that will fix this.
And wooho! seems latest run fixed this.. :-)
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah
ere : see : https://git.reviewboard.kde.org/r/127756/
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-integration and also this have broken
unittest.
- Bhushan Shah
On April 27, 2016, 4:46 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
-
>
> (Updated Feb. 11, 2014, 7 p.m.)
>
>
> Review request for KDE Frameworks and Bhushan Shah.
>
>
> Repository: kwindowsystem
>
>
> Description
> ---
>
> Also port KWindowSystem::windowInfo to the flags
>
> The cast was causing problems
> On Feb. 11, 2014, 7:13 p.m., Bhushan Shah wrote:
> > I can not give you Ship it! but +1 from me.. :)
ping
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115658/#re
kdeinit5: PID 1259 terminated.
libKIOCore.so.5 was not found.
libKParts.so.5 was not found.
libPlasma.so.5 was not found.
Diffs
-
src/kdeinit/kinit.cpp a91a09d
Diff: https://git.reviewboard.kde.org/r/116566/diff/
Testing
---
It does not appears again.
Thanks,
Bhushan Shah
/r/116566/diff/
Testing
---
It does not appears again.
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
e Chrome could not find lxrnew.kde.org
Did you mean: kde.org :(
Thanks!
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117337/#review54893
---
Fixes crash, but I am not the one to give Ship it!
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/#review56270
---
+1, Just tested
- Bhushan Shah
On April 23, 2014, 3:05 p.m
See also
"/home/bshah/kdesrc/build/frameworks/karchive/CMakeFiles/CMakeError.log".
Thanks!
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sat, May 10, 2014 at 2:48 PM, Martin Gräßlin wrote:
> I can confirm that behavior. I'm just setting up a new build env on a system
> and it's failing with the same problem in karchive.
Also failing on Jenkins also, http://build.kde.org/job/karchive_master_qt5/47/
--
Bh
On Sat, May 10, 2014 at 3:58 PM, Alex Merry wrote:
> These were causing configure failures in frameworks that use
> ECMAddTests.
Still kcoreaddons is failing..
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-fram
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
32 frameworks failing due to this passes
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
autotests/CMakeLists.txt 11d98f1
Diff: https://git.reviewboard.kde.org/r/118069/diff/
Testing
---
built, all 32 frameworks failing due to this passes
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
://git.reviewboard.kde.org/r/118069/diff/
Testing
---
built, all 32 frameworks failing due to this passes
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote:
> > Good catch, merci! Any chance this fixes bug 330845?
>
> Martin Klapetek wrote:
> Yup, it does. I had Eike especially test this for his comment #2 on that
> bug, he says this fixes the problem :)
This fixes bug indeed but scales up ic
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote:
> > Good catch, merci! Any chance this fixes bug 330845?
>
> Martin Klapetek wrote:
> Yup, it does. I had Eike especially test this for his comment #2 on that
> bug, he says this fixes the problem :)
>
> Bhu
tps://git.reviewboard.kde.org/r/118547/#comment41253>
Err no, this will fail when using formatRelativeDate and
formatRelativeDateTime
- Bhushan Shah
On June 5, 2014, 5:33 a.m., David Edmundson wrote:
>
> ---
> This is a
Hello!
I want to compile kde library without building tests or auto tests.
Reason behind this is I want to speed up compiling process.. Martin
Gräßlin suggested me to use
-DKDE4_BUILD_TESTS=FALSE -DBUILD_TESTING=FALSE
cmake options but this options are not working, with this option cmake
fails t
Hello!
It looks like keystate applet which was removed from KDE4 was(?) the
user of keystate dataengine. If we bring back this applet in Plasma2
then this DataEngine will be used. And this applet is necessary for
disabled people, See https://bugs.kde.org/show_bug.cgi?id=165402
Thanks!
On Sun, No
install dir for me
on opensuse.
- Bhushan Shah
On Nov. 14, 2013, 3:13 p.m., Aurélien Gâteau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
-workspace
Description
---
summary says all
Diffs
-
kwin/tests/CMakeLists.txt 0e2bab9
Diff: http://git.reviewboard.kde.org/r/113861/diff/
Testing
---
compiles, tests pass
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
summary ^
it complains about KGuiAddons in cmake. it fixes this..
Diffs
-
tier3/kiconthemes/CMakeLists.txt d1191d1
Diff: http://git.reviewboard.kde.org/r/114111/diff/
Testing
---
compiles, links, installs.
Thanks,
Bhushan Shah
---------
On Nov. 25, 2013, 9:02 p.m., Bhushan Shah wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114111/
> -
> Next version of CMake should fix this.
>
> Bhushan Shah wrote:
> No I am not able to run cmake, it fails..
>
> Alex Merry wrote:
> Yeah, this is apparently a known bug with current versions of CMake
> (pre-3.0.0). But we have to support 2.8.12, so we need to inclu
, links, installs.
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
<http://git.reviewboard.kde.org/r/114260/#comment32199>
Remove this here and there; it's not needed
- Bhushan Shah
On Dec. 3, 2013, 12:52 a.m., Andrea Scarpino wrote:
>
> ---
> This is an automatically generated e-mai
ttp://git.reviewboard.kde.org/r/114260/#comment32370>
You should call init() here. Have a look at
http://community.kde.org/Plasma/PortingTolibplasma2#DataEngine for changes in
API.
- Bhushan Shah
On Dec. 3, 2013, 3:21 p.m., Andrea Scarpino
tension HtmlExtension FileInfoExtension
ListingExtension
)
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/KParts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Thanks!
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-fra
ommunity.kde.org/Frameworks/Binary_Packages
Thanks!
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Description
---
$summary
Diffs
-
src/kconfig_compiler/kconfig_compiler.cpp df17d4c
Diff: https://git.reviewboard.kde.org/r/114937/diff/
Testing
---
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
David Faure.
Changes
---
fix issues
Repository: kconfig
Description
---
$summary
Diffs (updated)
-
src/kconfig_compiler/kconfig_compiler.cpp df17d4c
Diff: https://git.reviewboard.kde.org/r/114937/diff/
Testing
---
Thanks,
Bhushan Shah
and David Faure.
Changes
---
Fix
Repository: kconfig
Description
---
$summary
Diffs (updated)
-
src/kconfig_compiler/kconfig_compiler.cpp df17d4c
Diff: https://git.reviewboard.kde.org/r/114937/diff/
Testing
---
Thanks,
Bhushan Shah
src/kconfig_compiler/kconfig_compiler.cpp df17d4c
>
> Diff: https://git.reviewboard.kde.org/r/114937/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Bhushan Shah
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and David Faure.
Repository: kconfig
Description
---
$summary
Diffs
-
src/kconfig_compiler/kconfig_compiler.cpp df17d4c
Diff: https://git.reviewboard.kde.org/r/114937/diff/
Testing
---
Thanks,
Bhushan Shah
os to the related group.
Advantages:
1) Easy to assign maintainer to individual component.
2) If we split only some repos, we can not mark it as part of
workspace but this way we can do it.
3) More, may be?
That's my humble suggestion. :)
> Again, this is a proposal so please! send any fee
something as a standard
> solution. So each person will consider "Plasma Desktop" as something entirely
> different.
Yes having group is essential, otherwise it will create confusion..
repo like kde:kf5umbrella will be also needed.
Thanks!
--
Bhushan Shah
http://bhush9.github.i
shows no sources.
- Bhushan Shah
On Feb. 2, 2014, 4:56 p.m., Andrea Scarpino wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
Hello,
I am using project-neon5 on KUbuntu 13.04. I have every packages
installed on my computer which is required to build. I can not build
kwin, kstyles and powermanagement data engine so I have to disable it
for building kde-workspace.
CMake exits saying that XCB Libraries are not installed. [
Hello,
As on my system.. When I run cmake, I get following messages which is
related to the dbusmenu-qt
[NEON5] bshah@kubuntu:~/kde-workspace/build$ neon5-cmake ..
[..]
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- Found DBusMenuQt:
/opt/project-neon5/lib/i386-linux-gnu/libd
tps://git.reviewboard.kde.org/r/119535/#comment44233>
Maybe consider creating it a singleton type?
- Bhushan Shah
On July 29, 2014, 8:01 p.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail.
tps://git.reviewboard.kde.org/r/119535/#comment44236>
why? nameChanged is not related here..
src/qmlcontrols/kcoreaddons/kuserproxy.h
<https://git.reviewboard.kde.org/r/119535/#comment44237>
same.
- Bhushan Shah
On July 29, 2014, 8:01 p.m., Sebastian
> On July 29, 2014, 10:04 p.m., Bhushan Shah wrote:
> > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
> > <https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44>
> >
> > Maybe consider creating it a singleton type?
>
&
ct
Umm strange, I don't see this error.. I myself have ported it and it
works fine here.. let me try and see what can cause this error..
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde
On Tue, Sep 16, 2014 at 11:13 AM, Bhushan Shah wrote:
> Umm strange, I don't see this error.. I myself have ported it and it
> works fine here.. let me try and see what can cause this error..
Okay now I see problem, in KF5 constructor is,
KRun (const QUrl &url, QWidge
On Tue, Sep 16, 2014 at 11:26 AM, Bhushan Shah wrote:
> is working fine, will correct it in little time..
Solved in http://commits.kde.org/ark/cf4c338216908f7b50fc1c36be753cb34b7daecc
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freen
Hello
On Wed, Oct 8, 2014 at 12:04 PM, Marko Käning wrote:
> Dolphin is currently broken on OSX:
>
#ifdef HAVE_BALOO
#include
-#include
#endif
+#include
Can you try this?
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https:
What about this?
#ifdef HAVE_BALOO
#include
#include
#include
#include
#include
-#include
#endif
+#include
On Wed, Oct 8, 2014 at 12:27 PM, Marko Käning wrote:
> Hi Bhushan,
>
> On 08 Oct 2014, at 08:44 , Bhushan Shah wrote:
>> #i
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120886/#review69407
---
Sounds sane but dfaure will give you ship it! :)
- Bhushan
t
available, (Mac OS/X)
7ed7cd97d084364d8ee61b35f5ffa3630c5277a4 is commit which introduced problem
Adding Emmanuel Pescosta to CC.
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-framewor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121953/#review73618
---
+1, Let maintainer give Shipit!
- Bhushan Shah
On Jan. 9
kio-extras is not installed, so kio-extras becomes hidden dep for kio..
So any thoughts on moving thumbnail kioslave and thumbcreator service
type to kio?
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel ma
kio_thumbnail isn't there. Given that kio_thumbnail has no additional
> required dependency (apart from libjpeg), I am OK with it moving to the KIO
> framework.
Thanks, can you do the move? as I have no knowledge of how to preserve
history while doing so and stuff
--
Bhushan Shah
http
/ktar.cpp 0972d76
Diff: https://git.reviewboard.kde.org/r/122216/diff/
Testing
---
no longer created in $PWD
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
kioslave creates ktar-XX.tar file in current working
directory in KF5
Diffs
-
src/ktar.cpp 0972d76
Diff: https://git.reviewboard.kde.org/r/122216/diff/
Testing
---
no longer created in $PWD
Thanks,
Bhushan Shah
___
Kde-frameworks
kglobalaccel limitation.
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122408/#review75324
-------
On Feb. 3, 2015, 10:41 p.m., Bhushan Shah wrote:
>
> --
element in the preferences.menu file would become
$XDG_CONFIG_DIRS/menus/preferences-merged/
Diffs
-
src/kbuildsycoca/applications.menu f2d5253
Diff: https://git.reviewboard.kde.org/r/122499/diff/
Testing
---
Thanks,
Bhushan Shah
- Bhushan Shah
On Feb. 13, 2015, 3:04 a.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
activities and stop activities but somehow
alt+shift+tab is not working due to some kglobalaccel limitation.
Thanks,
Bhushan Shah
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
f "KF5Package" to CMAKE_PREFIX_PATH or set
> "KF5Package_DIR" to a directory containing one of the above files. If
> "KF5Package" provides a separate development package or SDK, be sure it has
> been installed.
Adjusted kde-build-metadata; someone will
()->setError(errorCode);
23:07:44^
See http://build.kde.org/job/plasma-workspace_stable_qt5/89/console
- Bhushan Shah
On March 14, 2015, 12:56 a.m., David Rosca wrote:
>
> ---
> This is an automatically generate
it&a=commit&h=770786f234dc0a824b3b463d5d6923459bd28f0a
[2]
http://quickgit.kde.org/?p=kdelibs.git&a=blob&h=b95002d0403f94f0155eeae5f28351c917be1750&hb=92d3cb4804bad73f8ebabf9be8f6f2a2c0daa471&f=kdecore%2Fdoc%2FREADME.kiosk#l548
Thanks!
--
Bhushan Shah
http://bhush9.g
t;
> -- Configuring incomplete, errors occurred!
Fixed in
http://quickgit.kde.org/?p=kde-build-metadata.git&a=commit&h=d45d83d6110eb595636ca9ed9facfbbbc8b35828
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
f, thanks Albert for finishing that !
Just wondering if it is/can be possible to disable CI notifications
temporarily during tagging; so that this noise can be avoided?
considering number of frameworks and its variations this can be lot of
noise/spam..
--
Bhushan Shah
http://bhush9.github.io
erminal in a gnome session to test and such while
> the rest of kde builds...
Is your /home/jeremy/.cache/ksycoca5 owned by root or something?
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing l
.d->number = static_cast(abs(a));
^
klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead
Diffs
-
src/klocalizedstring.cpp 910f44d
Diff: https://git.reviewboard.kde.org/r/123867/diff/
Testing
---
Thanks,
Bhushan Shah
___
Kde-f
> > #include
ah yeah.
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/#review80680
-------
marked as submitted.
Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett
Clark.
Changes
---
Submitted with commit b0ad9db8235e7ed644c239245c897a643515d278 by Bhushan Shah
to branch master.
Repository: ki18n
Description
---
https://build.kde.org/job/ki18n
> On May 21, 2015, 1:31 p.m., Milian Wolff wrote:
> > src/klocalizedstring.cpp, line 23
> > <https://git.reviewboard.kde.org/r/123867/diff/1/?file=370328#file370328line23>
> >
> > shouldn't this be
> >
> > #include
>
>
^
> klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead
>
>
> Diffs
> -
>
> src/klocalizedstring.cpp 910f44d
>
> Diff: https://git.reviewboard.kde.org/r/123867/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Bhushan Shah
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
in pmc. Not all
plasmoids would support mediacenter containment, so they might need to tell
somehow which formfactors are supported.. About naming, name it
X-KDE-SupportedFormFactor maybe?
Also perhaps document what should be possible values of X-KDE-FormFactors
somewhere?
- Bhushan Shah
On
BUG:343510
- Bhushan Shah
On July 16, 2015, 5:08 p.m., Daniel Vrátil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.
> On July 16, 2015, 6:19 p.m., Bhushan Shah wrote:
> > +1, though I remember sebas also tried to fix some recursive loop here
> > sometime ago..
> >
> > tree b2e50f720e779
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124371/#review82568
---
Ship it!
Ship It!
- Bhushan Shah
On July 16, 2015, 5:08
emails can be stopped.. ;-)
It is due to email notification for both success/failure and status
change is enabled.. please disable success/failure emails...
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-d
> On Oct. 2, 2015, 10:22 a.m., Viktar Vauchkevich wrote:
> > Ship It!
Erm, do you have commit access or want someone to commit for you?
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kd
an test it. I tried to manually cross build but I
screwed something else.. and I failed to build it. Sorry for delay.
IMO patch itself looks quite sensible..
--
Bhushan Shah
http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-dev
viewboard.kde.org/r/125497/
> ---
>
> (Updated Oct. 4, 2015, 1:28 p.m.)
>
>
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
>
>
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id
.. :)
- Bhushan Shah
On Oct. 5, 2015, 12:12 a.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
master.
- Bhushan Shah
On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
-
see testcase in description
Thanks,
Bhushan Shah
ke 523271a
Diff: https://git.reviewboard.kde.org/r/128917/diff/
Testing
---
see testcase in description
Thanks,
Bhushan Shah
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 0cc2de65d111ee1244f3d3ce53c83b3b55b58dfb by Bhushan Shah
to branch master.
Repository: extra-cmake-modules
Description
---
If KDECMakeSettings is included twice for
habricator already have todo item for this
issue, https://phabricator.kde.org/T3689
Thanks
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
fernt prefix, so
CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 for kpackage is not same as one for
frameworks.
Possible solution is to mock the resolveHandler for autotests, so that this
framework's autotests are functional without depending on other packages.
- Bhushan Shah
On Nov. 20, 2016, 4:07 p.m., Ale
> On Nov. 21, 2016, 9:34 a.m., Bhushan Shah wrote:
> > src/kpackage/private/packagejobthread.cpp, line 190
> > <https://git.reviewboard.kde.org/r/129298/diff/2/?file=485657#file485657line190>
> >
> > This can't (and doesn't, as evident by failing
)
<https://git.reviewboard.kde.org/r/129419/#comment67739>
From wherever you copied this license.. it doesn't seem right :-P (along
with "nullptr" library)
- Bhushan Shah
On Nov. 17, 2016, 9:30 p.m., Ale
,
Bhushan Shah
tps://git.reviewboard.kde.org/r/129520/#comment67741>
This will be gone in actual commit, I promise :-P
- Bhushan Shah
On Nov. 21, 2016, 7:58 p.m., Bhushan Shah wrote:
>
> ---
> This is an automatically generated e-mail.
enerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129520/#review101023
---
On Nov. 21, 2016, 7:58 p.m., Bhushan Shah wrote:
>
> ---
> This is an automatically generated e-mail. To r
ATION
autotests/querytest.cpp 4186a0b
src/kpackage/private/packagejobthread.cpp 90016d8
Diff: https://git.reviewboard.kde.org/r/129520/diff/
Testing
---
tests pass, and moar coverage
Thanks,
Bhushan Shah
marked as submitted.
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Marco Martin.
Changes
---
Submitted with commit 6aa60b1be39521c083602ee5f7f08f4257e65edc by Bhushan Shah
to branch master.
Repository: kpackage
Description
---
This works in quite simple way
e have any opinion on "merging" latest git tag in master branch?
and potentially doing that for next releases as well?
Thanks
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
bshah added a subscriber: jbbgameich.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D28114
To: ndavis, #vdg
Cc: jbbgameich, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
1 - 100 of 216 matches
Mail list logo
