> On Jan. 11, 2014, 5:03 a.m., David Faure wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 1589 > > <https://git.reviewboard.kde.org/r/114937/diff/3/?file=233674#file233674line1589> > > > > wrong indentation, or is this just reviewboard being buggy?
there is proper indentation.. > On Jan. 11, 2014, 5:03 a.m., David Faure wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 45 > > <https://git.reviewboard.kde.org/r/114937/diff/3/?file=233674#file233674line45> > > > > wouldn't <kconfig_version.h> work? seems more robust in case of moving > > stuff around. No I tried but it is not working. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47176 ----------------------------------------------------------- On Jan. 10, 2014, 10:29 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114937/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2014, 10:29 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kconfig > > > Description > ------- > > $summary > > > Diffs > ----- > > src/kconfig_compiler/kconfig_compiler.cpp df17d4c > > Diff: https://git.reviewboard.kde.org/r/114937/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
