> On May 25, 2015, 11:09 p.m., Allen Winter wrote: > > This is incorrect. std::abs comes from cstdlib, not cmath > > please fix accordingly. I have it compiling here fine on my macbook with > > #include <cstdlib> instead of #include <cmath>
Fixed with http://commits.kde.org/ki18n/f0a4b6f1564efe397d804ac4ad1740c811748c6b - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80817 ----------------------------------------------------------- On May 21, 2015, 1:49 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123867/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 1:49 p.m.) > > > Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett > Clark. > > > Repository: ki18n > > > Description > ------- > > https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console > > Follow up to, > > commit 8d392e523e4556f9e434f3e02890fcacfcb492e4 > Author: Milian Wolff <m...@milianw.de> > Date: Mon May 18 10:52:29 2015 +0200 > > Fix compiler warning about potential truncation. > > klocalizedstring.cpp:1126:46: warning: absolute value function 'abs' > given an argument of type 'long' but has parameter of type 'int' > which may cause truncation of value > > kls.d->number = static_cast<pluraln>(abs(a)); > ^ > klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead > > > Diffs > ----- > > src/klocalizedstring.cpp 910f44d > > Diff: https://git.reviewboard.kde.org/r/123867/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
