----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/#review73618 -----------------------------------------------------------
+1, Let maintainer give Shipit! - Bhushan Shah On Jan. 9, 2015, 10:03 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121953/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 10:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Add filename to KPluginInfo::property() deprecation notice. > > > Diffs > ----- > > src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b > > Diff: https://git.reviewboard.kde.org/r/121953/diff/ > > > Testing > ------- > > The deprecation notice for `KPluginInfo::property()` includes now the > filename of the originating file, making it easier to update it. > > ``` > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use > KPluginInfo::pluginName() in > "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so" > instead. > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use > KPluginInfo::pluginName() in > "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so" instead. > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use > KPluginInfo::pluginName() in > "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so" instead. > ``` > > > Thanks, > > Elias Probst > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
