Re: Review Request 126161: OS X housekeeping

On 2015-11-26 09:27, René J.V. Bertin wrote: There's something I don't really understand though: the exact same question you asked above. What's the difference between starting kwrite directly on the commandline (or through execve()), and dlopen'ing it? Why does the code go through that on Linux?

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On 2015-11-28 19:25, René J.V. Bertin wrote: On Saturday November 28 2015 15:29:00 David Faure wrote: Otherwise, the next best idea is to get ECM to add your activator to all link lines automatically, e.g. by adding it to CMAKE_EXE_LINKER_FLAGS or whatever. This for sure beats editing every lin

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On 2015-11-28 21:53, René J. V. Bertin wrote: BTW, not that it's already being used, but is CMAKE_EXE_LINKER_FLAGS_INIT incremental or does one have to accumulate all elements first and use a single - DCMAKE_EXE_LINKER_FLAGS_INIT=XX argument? CMAKE_EXE_LINKER_FLAGS_INIT is a bit special. You

Re: KXmlGui Patched for Deployment

On 2015-11-29 08:57, Cristian Oneț wrote: Hi, I was just building some KDE apps (using frameworks) on OSX and encountered the same problem for which we (me and Patrick von Reth) created the QStandardPaths patch at Randa in 2014 [1]. The solution you propose in this mail requires all applications

Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/#review88966 --- Ship it! Ship It! - Alex Merry On Nov. 29, 2015, 8:59 p.m

Re: KDE PIM Split?

On 2015-12-01 09:06, laurent Montel wrote: Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > El 1 dic 2015, a las 05:10, Ben Cooksley escribió: >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> >> Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >>> Hi

Re: Updating techbase wiki page according to KF5 policies

On 2015-12-01 15:34, Martin Walch wrote: On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: On 2015-11-14 01:21, Martin Walch wrote: > Alright, so I have created a stub at > > https://techbase.kde.org/Policies/Frameworks_Coding_Style > > ... > > Qt includes >

Re: Updating techbase wiki page according to KF5 policies

On 2015-12-02 08:09, David Faure wrote: On Tuesday 01 December 2015 22:36:52 Alex Merry wrote: On 2015-12-01 15:34, Martin Walch wrote: > On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: >> On 2015-11-14 01:21, Martin Walch wrote: >> > Alright, so I have

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > > `kde-modules/

Re: Review Request 126185: Make the KAppTemplate CMake module global

l, consider passing in the install destination as an argument, or at least allowing that as a possibility. The actual directory could (should?) be put into KDEInstallDirs.cmake as an extra variable. - Alex Merry On Dec. 3, 2015, 12:34 p.m., Marco Martin wrote: > > --

Re: Purpose as a KDE Framework

On 2015-12-03 18:29, Aleix Pol wrote: On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: I'm trying to understand what Purpose is doing exactly. I've read the readme file, but i still can't quite figure out what it's doing or where i might be able to use it. Could you give a short summary w

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

rlier vague message about Python and Gettext being needed. If you're going to take this approach, I think you still need to define k18n_install_ts_files in the else() branch, but make it spit out an error about exactly what package(s) are missing. - Alex Merry On Dec. 4,

Re: Review Request 126185: Make the KAppTemplate CMake module global

ppen when you're reading the code - it will package the templates and install them. But I'm not going to force your hand on this if you'd rather not do it that way. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line52> > > > > Honestly, I'd just use ARG as the prefix - you're in a f

Re: Review Request 126185: Make the KAppTemplate CMake module global

you find the idea of writing a CMake-based unit test daunting, but you can look in the tests directory for inspiration. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --- > This is an automatically generated e

kdesrc-build setup for kdepim

The recent splitting of kdepimlibs has caused a clean run of kdesrc-build to fail on lots of pim modules. This seems to be a combination of kde-build-metadata not recording the dependencies properly for a lot of things, and "playground/pim" in the kdepim kdesrc-build include file being far too

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 84 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line84> > > > > Use ``KDE_INSTALL_KTEMPLATESDIR`` instead of > > ``KTE

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment61287> I'd prefer ``kde_package_app_templates`` (and the module to be called ``KDEPackageAppTemplates.cmake``). - Alex Merry On Dec. 15, 2015, 10:38 a.m., Marco Martin wrote: > >

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

ght want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory). - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

/contents/ui/main.qml (lines 1 - 18) <https://git.reviewboard.kde.org/r/126185/#comment61372> BSD code only in extra-cmake-modules, please. Frankly, your app template can be complete rubbish, as long as it's packaged up properly. - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco M

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

bad about the sheer number of changes I'm throwing at you! If you want to make me do some of the work, you can create a feature branch and point me at it, but I'm hoping this review is setting you up for an easy ride if you want to contribute something else to e-c-m in the future. -

Re: Review Request 126185: Make the KAppTemplate CMake module global

() to untar the installed tarball, and examine the contents. I highly recommend you look at ECMInstallIconsTest. - Alex Merry On Dec. 17, 2015, 11:15 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

he directory to install the template package to. In most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. And then put a blank line before the bit about TEMPLATES, so they're separate paragraphs. - Alex Merry On Dec. 18, 2015

Re: Review Request 126185: Make the KAppTemplate CMake module global

in. kde-modules/KDEPackageAppTemplates.cmake (line 19) <https://git.reviewboard.kde.org/r/126185/#comment61779> New paragraph, please. - Alex Merry On Dec. 28, 2015, 9:37 a.m., Marco Martin wrote: > > --- > This is a

Re: Review Request 126684: fix loading of RLE compressed PSD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126684/#review90831 --- Ship it! Ship It! - Alex Merry On Jan. 9, 2016, 9:58 a.m

Re: Review Request 126675: Add .kra and .ora qimagio plugins

all the new files are empty. Also, could you please add test cases to the autotests directory? It shouldn't be too complicated, just an example file or two and the PNG equivalents. - Alex Merry On Jan. 16, 2016, 9:55 a.m., Boudewijn Rempt

Re: Review Request 126675: Add .kra and .ora qimagio plugins

g/r/126675/#comment62684> What about making this optional (and only building those two plugins if it is found)? - Alex Merry On Jan. 27, 2016, 9:48 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically gener

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/#review91823 --- Ship it! Ship It! - Alex Merry On Jan. 31, 2016, 1:21

Re: Reminder: Please add "Since" version info also to cmake macros and arguments

On 2016-01-18 16:45, Friedrich W. H. Kossebau wrote: Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau: I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across it, appending the Since behind the example, if that is the current syntax? # Example: #

Re: Review Request 127015: Move to tier2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127015/#review92177 --- Ship it! Good catch! - Alex Merry On Feb. 8, 2016, 6

Re: Review Request 127093: Drop KDocTools requirement

g/r/127093/#comment63114> You should set the package properties to say what it is needed for (and maybe make it RECOMMENDED?). See KF5Completion below. - Alex Merry On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote: > > --

Taking a (semi-)break

Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may have noticed this already). I expect to get back into the swing

Re: Taking a (semi-)break

On 2016-02-22 22:01, Stephen Kelly wrote: Alex Merry wrote: Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of yo

Re: Review Request 115423: Move license information to its proper locations

relicensing script to see how far we can standardise (preferably on the 2,2.1,3,eV version). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/#review48893

Re: Review Request 115423: Move license information to its proper locations

cc698ec3535bad5d652419687fa81dff4ebc0987 cmake/FindOpenEXR.cmake d69f449960a0ff27c35a532bf4492e20978d5dfe Diff: https://git.reviewboard.kde.org/r/115423/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 115456: Fix MSVC libc linkage for debug builds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115456/#review48907 --- Ship it! Oops, that was my fault, sorry. - Alex Merry On

Re: Review Request 115457: Allow compiling KJS on windows

Huh? So this is a nested #if COMPILER(MSVC)? I think the inner one should go... - Alex Merry On Feb. 4, 2014, 12:10 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

g/r/115442/#comment34543> Not changing this? Or deprecating it and adding another version? src/kwindowsystem.h <https://git.reviewboard.kde.org/r/115442/#comment34544> Or this? (And why is this an int?) - Alex Merry On Feb. 4, 2014, 6:52 a.m., Martin G

Re: Review Request 115468: Move qts test to autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115468/#review48922 --- Ship it! Ship It! - Alex Merry On Feb. 4, 2014, 1:12 p.m

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/#review48921 --- Ship it! Ship It! - Alex Merry On Feb. 4, 2014, 6:52 a.m

Re: Review Request 115473: information in README on each part of this framework

. The text should probably reflect that. - Alex Merry On Feb. 4, 2014, 2:45 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Review Request 115474: Use find_dependency() for attica in the Config.cmake file

://git.reviewboard.kde.org/r/115474/diff/ Testing --- Builds and installs; kmediaplayer (which depends on kxmlgui) configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 115476: Defer to CMake's find_dependency macro if it exists

rom the feature summary. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115474: Use find_dependency() for attica in the Config.cmake file

- KF5XmlGuiConfig.cmake.in b6c307a2d579d6b7bedf079017563030af8fdfdd Diff: https://git.reviewboard.kde.org/r/115474/diff/ Testing --- Builds and installs; kmediaplayer (which depends on kxmlgui) configures, builds and installs. Thanks, Alex Merry

Re: Review Request 115457: Allow compiling KJS on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115457/#review48945 --- Ship it! Ship It! - Alex Merry On Feb. 4, 2014, 3:54 p.m

Re: Review Request 115473: information in README on each part of this framework

> On Feb. 4, 2014, 4:24 p.m., Alex Merry wrote: > > README.md, lines 34-35 > > <https://git.reviewboard.kde.org/r/115473/diff/3/?file=241905#file241905line34> > > > > typo: "Current" should be "Currently". In fact, "Currenctly provid

Re: Review Request 115473: information in README on each part of this framework

473/#comment34564> typo: "Current" should be "Currently". In fact, "Currenctly provides" would be better. - Alex Merry On Feb. 4, 2014, 4:21 p.m., Jonathan Riddell wrote: > > --- > This is an au

Review Request 115477: Remove commands that just set variables to their defaults

. Repository: extra-cmake-modules Description --- Remove commands that just set variables to their defaults Diffs - kde-modules/KDECMakeSettings.cmake 24593d4af57e982b8c772b1931b805872d518d21 Diff: https://git.reviewboard.kde.org/r/115477/diff/ Testing --- Thanks, Alex

Re: Review Request 115472: fix test for icon path

> On Feb. 4, 2014, 4:51 p.m., Jonathan Riddell wrote: > > I realise I've largely ignored your suggestion, I think my way is more > > readable but if you disagree I'll go with yours > > FWIW, I find your way easier to parse. - Alex ---

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115478/#review48954 --- Has the Qt patch been submitted upstream? - Alex Merry On

Review Request 115480: Never use an "-apidocs" suffix with kgenframeworksapidox

orksapidox 0fcace47f3e1a36b6d34fe0c9d5fd93500c866cd Diff: https://git.reviewboard.kde.org/r/115480/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115488: Improve docs for kde modules

/KDEFrameworkCompilerSettings.cmake 0799a8d7c0b165c6c9a40e84ec2bd61bc6f1f587 kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 Diff: https://git.reviewboard.kde.org/r/115488/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel

Re: Review Request 115483: Improve kmediaplayer dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115483/#review48983 --- Ship it! Ship It! - Alex Merry On Feb. 4, 2014, 6:23 p.m

Re: Review Request 115481: Improve knotifyconfig dependencies

g/r/115481/#comment34586> I think a better approach is to only add the tests subdir if BUILD_TESTS is true, and use set_package_properties to say that these deps are required for tests. (This is something I think should be done across all the frameworks). - Alex Merry On Feb. 4, 2

Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115419: Split KCompletionMatches class into files of its own

of KCompletion. The comment can literally just be // for KCompletionMatchesWrapper at the end of the line - Alex Merry On Feb. 4, 2014, 11:08 p.m., David Gil Oliva wrote: > > --- > This is an automatically g

Re: Review Request 115370: Fix apidox, fix code style and delete useless includes in KComboBox (KCompletion)

> On Jan. 31, 2014, 8:07 p.m., Alex Merry wrote: > > src/kcombobox.h, line 183 > > <https://git.reviewboard.kde.org/r/115370/diff/1/?file=240925#file240925line183> > > > > Why? This is out of keeping with every other method's documentation... > >

Re: Review Request 115370: Fix apidox, fix code style and delete useless includes in KComboBox (KCompletion)

/kcombobox.h <https://git.reviewboard.kde.org/r/115370/#comment34594> Ah, I meant to get rid of "An enhanced combo box" in the process. ie: replace these three lines with @short A combo box with completion support. - Alex Merry On Feb. 4, 2014, 11:50 p.m., David

Re: Review Request 115480: Never use an "-apidocs" suffix with kgenframeworksapidox

having an apidocs suffix for any of the subdirs. Diffs - src/kgenframeworksapidox 0fcace47f3e1a36b6d34fe0c9d5fd93500c866cd Diff: https://git.reviewboard.kde.org/r/115480/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailin

Review Request 115493: Make CMakeLists.txt respect DESTDIR

` both appear to work as expected. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115477: Remove commands that just set variables to their defaults

24593d4af57e982b8c772b1931b805872d518d21 Diff: https://git.reviewboard.kde.org/r/115477/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115481: Improve knotifyconfig dependencies

g/r/115481/#comment34619> These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should have its PURPOSE set as well. - Alex Merry On Feb. 5, 2014, 10:48 a.m., Michael Palimaka wrote: > > --- > This is an automatically g

Re: Review Request 115476: Defer to CMake's find_dependency macro if it exists

age/cmake.git;a=commitdiff;h=a6971f651), I properly get the transitive deps omitted from the feature summary. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

causes the build to fail. - Alex Merry On Feb. 5, 2014, 1:42 p.m., Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

instead of CMakePackageConfigHelpers, both KJS and KI18n configure and build properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

Alex Merry. Changes --- Add autotests and merge in https://git.reviewboard.kde.org/r/115492 Repository: kimageformats Description (updated) --- Also includes the commit "Add magic detection for WebP files to mimetype description", from https://git.reviewboard.kde.or

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

s possibly a cmake bug. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49034 --- On Feb. 5, 2014, 11:50 a.m., Alex

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

install` and `make install DESTDIR=/tmp/kapidox` both appear to work as expected. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- `make install` and `make install DESTDIR=/tmp/kapidox` both appear to work as expected. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review49054 --- Ship it! Ship It! - Alex Merry On Jan. 29, 2014, 4:27 p.m

Review Request 115502: Fix math function checks

Diff: https://git.reviewboard.kde.org/r/115502/diff/ Testing --- Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux). The configure checks report the results you would expect (providing you are aware that cmath undefs signbit). Thanks, Alex Merry

Re: Review Request 115494: Build on Mac OS X

ndefs the signbit macro. I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part of your request. - Alex Merry On Feb. 5, 2014, 4:06 p.m., Harald Fernengel wrote: > > --- > This is an automatically ge

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

3a8defd8223e84f338cc297bf19cdfcaf564e5f1 Diff: https://git.reviewboard.kde.org/r/115496/diff/ Testing --- Using CMake 2.8.12: KI18n build fails if KJS is left unchanged. If it includes ECMPackageConfigHelpers instead of CMakePackageConfigHelpers, both KJS and KI18n configure and build properly. Thanks, Alex Merry

Review Request 115504: Only perform tests for plugins that are built

tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115504: Only perform tests for plugins that are built

it.reviewboard.kde.org/r/115504/#review49066 ------- On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 115502: Fix math function checks

(providing you are aware that cmath undefs signbit). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Taking over maintainer role for KConfig/KDNSSD

On 06/02/14 07:38, Matthew Dawson wrote: > Just to let everyone know, I'm taking over the role of maintainer for both > KConfig and KDNSSD. I'm most contactable at this email address ( > matt...@mjdsystems.ca ). I'm usually idling on IRC with a nick of MJD, but > I'm not always watching IRC.

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

thing: why call dot directly instead of using yapgvb to render to PNG? Although it looks like tred might not be an option in that case... Third thing: have you tested with python3? - Alex Merry On Feb. 5, 2014, 2:43 p.m., Aurélien Gâteau wrote

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

> On Feb. 6, 2014, 12:56 p.m., Alex Merry wrote: > > Instant issue: the README.md claims that yapgvb is only needed to generate > > the diagrams, but not having it installed causes kgenframeworksapidocs to > > fail with an ImportError (it imports depdiagram, which impor

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

, but I think moving the test to the calling sites is more resilient to future code changes. - Alex Merry On Feb. 6, 2014, 1:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 115481: Improve knotifyconfig dependencies

> On Feb. 5, 2014, 11:58 a.m., Alex Merry wrote: > > tests/CMakeLists.txt, lines 7-20 > > <https://git.reviewboard.kde.org/r/115481/diff/2/?file=241988#file241988line7> > > > > These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should > > hav

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/#review49128 --- Ship it! OK, that works. - Alex Merry On Feb. 6, 2014, 1

Re: Review Request 115481: Improve knotifyconfig dependencies

with tests disabled. Have you already checked this? (It'll be a couple of hours before I have a sane KF5 setup). - Alex Merry On Feb. 5, 2014, 1:04 p.m., Michael Palimaka wrote: > > --- > This is an automatically genera

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/#review49134 --- Ship it! Ship It! - Alex Merry On Feb. 5, 2014, 1:04 p.m

Re: Review Request 115028: Inline deprecated KUser::fullName() method

e48904dabe7b2790599c34673832b6ce38eab0e3 Diff: https://git.reviewboard.kde.org/r/115028/diff/ Testing (updated) --- configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115520: Remove kded transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115520/#review49145 --- Ship it! Ship It! - Alex Merry On Feb. 6, 2014, 4:41 p.m

Re: Taking over maintainer role for KConfig/KDNSSD

On 06/02/14 17:12, Matthew Dawson wrote: > On February 6, 2014 12:12:18 PM Alex Merry wrote: >> Does that mean that someone else will need to take on the bulk of the >> work of merging the kdnssd repositories? >> > I assume this merging the frameworks repository with the on

Re: alpha1 release

On 07/02/14 05:25, Martin Klapetek wrote: > Hey, > > On Thu, Feb 6, 2014 at 11:30 PM, David Faure > wrote: > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > Can we consider KF5 frozen all of tomorrow (Friday 7) ? > > > I have quite some extens

Re: Review Request 115421: Clean up the CMakeLists.txt files

On 07/02/14 08:58, David Faure wrote: > On Saturday 01 February 2014 13:27:49 Alex Merry wrote: >> - KStyle can once again be built standalone > > Is there any reason for this? > > I ask because I noticed that this was another place where the KF5 version had > to be upda

Re: HAVE_X11 usage in KIO/core

On 07/02/14 11:45, Aleix Pol wrote: > On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin > wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > Hi, > > > > > > I found some H

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

> On Feb. 6, 2014, 12:56 p.m., Alex Merry wrote: > > Instant issue: the README.md claims that yapgvb is only needed to generate > > the diagrams, but not having it installed causes kgenframeworksapidocs to > > fail with an ImportError (it imports depdiagram, which impor

Re: kde5 in path

On 09/02/14 23:55, Nicolas Lécureuil wrote: > ./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR > "${SHARE_INSTALL_PREFIX}/applications/kde5" "The XDG apps dir") Personally, I'm still of the view that XDG_APPS_INSTALL_DIR should just be ${SHARE_INSTALL_PREFIX}/applications

Re: Review Request 115620: Fix build when CMAKE_SOURCE_DIR contains spaces in its path

perly). - Alex Merry On Feb. 10, 2014, 10:34 a.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115649: Improve kdesignerplugin dependencies

ow generate some translations in the plugins. I'll have to consider how that might be possible. - Alex Merry On Feb. 11, 2014, 10:22 a.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

imum, translating between "xcb" (the Qt platform name that refers to the libraries used to implement it) and "X11" (the actual window system). - Alex Merry On Feb. 11, 2014, 10:40 a.m., Martin Gräßlin wrote: > >

  1   2   3   4   5   6   7   8   9   10   >