----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115620/#review49431 -----------------------------------------------------------
Good catch! But I would go further than this; all the variables should be quoted whenever they are used as arguments to something, since none of them are meant to be used as lists. This would not only deal with spaces, but also semicolons, which have special status in CMake (not that we're likely to run into that issue, but may as well do it properly). - Alex Merry On Feb. 10, 2014, 10:34 a.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115620/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 10:34 a.m.) > > > Review request for KDE Frameworks and Aurélien Gâteau. > > > Repository: kapidox > > > Description > ------- > > = subject > > > Diffs > ----- > > CMakeLists.txt b2e9876bb05eef29b6451d00905b331da8e7e5aa > > Diff: https://git.reviewboard.kde.org/r/115620/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
