> On Feb. 5, 2014, 11:58 a.m., Alex Merry wrote: > > tests/CMakeLists.txt, lines 7-20 > > <https://git.reviewboard.kde.org/r/115481/diff/2/?file=241988#file241988line7> > > > > These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should > > have its PURPOSE set as well. > > Michael Palimaka wrote: > It looks like there's a couple of other frameworks that need this change > too.
True, that. Somewhere low on my list of CMake-related tasks :-) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/#review49017 ----------------------------------------------------------- On Feb. 5, 2014, 1:04 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115481/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 1:04 p.m.) > > > Review request for KDE Frameworks and David Edmundson. > > > Repository: knotifyconfig > > > Description > ------- > > - Remove transitive dependencies > - Make test dependencies optional > > > Diffs > ----- > > CMakeLists.txt 78b3c717ee0eb9a4de4ebef95094f0bda00e6ef2 > tests/CMakeLists.txt 26a78de9e6052f650e5f6a95812dccd272dd8c4e > > Diff: https://git.reviewboard.kde.org/r/115481/diff/ > > > Testing > ------- > > Builds. Inspected source. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
