----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126684/#review90831 -----------------------------------------------------------
Ship it! Ship It! - Alex Merry On Jan. 9, 2016, 9:58 a.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126684/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 9:58 a.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Bugs: 354413 > https://bugs.kde.org/show_bug.cgi?id=354413 > > > Repository: kimageformats > > > Description > ------- > > decodeRLEData() expects a quint16 as length, but the PSD loader calls it with > a quint32. > We do need quint32 for PSD (it's the pixel count there, i.e. width x height), > otherwise it would overflow for files bigger than 256x256 pixels. > > > Diffs > ----- > > src/imageformats/rle_p.h 71d6b2c > > Diff: https://git.reviewboard.kde.org/r/126684/diff/ > > > Testing > ------- > > RLE compressed PSD files now load fine in applications like (the KF5 based) > gwenview, kolourpaint and okular, thumbnails are shown correctly in dolphin > too. > > PIC files still work as well. > > The tests still pass. > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
