Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

> On June 10, 2013, 8:30 a.m., David Faure wrote: > > khtml/xml/dom_docimpl.cpp, line 2007 > > > > > > This isn't about two QDateTimes. > > > > It's about one QDateTime (m_creationDate) and one number of

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/#review34110 --- kioslave/http/http.cpp

Re: Review Request 110939: Move KMultiTabBar to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110939/#review34114 --- Ship it! Ship It! - Kevin Ottens On June 10, 2013, 5:33 p.m

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review34115 --- Ship it! This change go in. Note that I disagree with the aim

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

> On June 11, 2013, 9:01 a.m., Kevin Ottens wrote: > > kioslave/http/http.cpp, line 4668 > > > > > > It's a QDataStream so we could use a QDateTime in there (would require > > adjusting deserialize too... means

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? Yes it should, it shouldn't be in our API. Of course, someone should fix Qt5 or our QPA plugin if it doesn't

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110907/#review34118 --- Ship it! Ship It! - Kevin Ottens On June 9, 2013, 1:54 p.m.

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 11, 2013, 9:15 a.m., Kevin Ottens wrote: > > Ship It! Ooops... I validated by mistake. :-) This diff is fine, but it looks incomplete, I don't see the CMakeLists.txt changes or the kthml and kdeui changes you referred to in your comment. - Kevin --

Re: Review Request 110478: Move KButtonGroup to KDE4Support

> On May 21, 2013, 10:35 a.m., Kevin Ottens wrote: > > Hm for the kcupsoptionspageswidget.ui don't we need to also introduce a > > QButtonGroup on the C++ side? So that the radio buttons keep being mutually > > exclusive. > > Anne-Marie Mahfouf wrote: > Radio buttons are autoExclusive by d

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? > > Kevin Ottens wrote: > Yes it should, it shouldn't be in our API. Of course, someone should fix > Qt5

Re: crasher in Qt

On Monday, April 29, 2013 16:46:12 Sebastian Kügler wrote: > Current tip of Qt5's dev branch crashes with Plasma Frameworks, hitting an > ASSERT in qquicktextedit.cpp. I've filed a bug against Qt, so it's on the > radar of those who are hopefully able to fix it. > > In the meantime, if you're wo

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/#review34123 --- Ship it! Ship It! - Kevin Ottens On June 5, 2013, 2:12 p.m.

Re: Review Request 110874: Move KInputDialog to KDE4Support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110874/#review34124 --- Ship it! Ship It! - Kevin Ottens On June 7, 2013, 8:47 p.m.

Re: Review Request 110842: Add reviewboardrc file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/#review34126 --- Ship it! Ship It! - Kevin Ottens On June 5, 2013, 8:32 p.m.

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

> On June 3, 2013, 9:59 a.m., David Faure wrote: > > For the record, this is waiting for an updated version of > > https://codereview.qt-project.org/#change,51166 Which is still not seeing any activity... Alex do you need help there? - Kevin -

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review34128 --- Ship it! Ship It! - Kevin Ottens On May 22, 2013, 3:31 p.m.

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? > > Kevin Ottens wrote: > Yes it should, it shouldn't be in our API. Of course, someone should fix > Qt5

Re: Review Request 107696: kcalendarsystem: Simplify weekday naming a lot.

> On May 6, 2013, 11:40 a.m., Kevin Ottens wrote: > > Jon, AFAICT this patch hasn't been pushed and it's been way more than a > > week. Any reason why you didn't push after all? Looks good to me too. Jon, please push your commits (we can't apply this one since you have other git commits to pus

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? > > Kevin Ottens wrote: > Yes it should, it shouldn't be in our API. Of course, someone should fix > Qt5

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/#review34135 --- kioslave/http/http.cpp

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

> On June 11, 2013, 9:01 a.m., Kevin Ottens wrote: > > kioslave/http/http.cpp, line 4668 > > > > > > It's a QDataStream so we could use a QDateTime in there (would require > > adjusting deserialize too... means

Re: Review Request 110939: Move KMultiTabBar to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110939/ --- (Updated June 11, 2013, 10:29 a.m.) Status -- This change has been ma

Re: Review Request 110939: Move KMultiTabBar to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110939/#review34137 --- This review has been submitted with commit 78f6b1d92dace8e5068

ECM install dir (Re: KF5 Update Meeting 2013-w20)

Le lundi 3 juin 2013 22:24:48 Alexander Neundorf a écrit : > On Monday 03 June 2013, Christophe Giboudeaux wrote: > > On Monday 03 June 2013 12:34:46 David Faure wrote: > > > On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > > > > there was a review request for a find-module for libusb1 he

Re: Review Request 108495: Port kimgio to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/#review34138 --- This review has been submitted with commit 217adfc00eaf9c6b4ea

Re: Review Request 108389: Respect the HOME environment variable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review34139 --- This review has been submitted with commit 07ce6442a3d30e82df7

Re: Review Request 108495: Port kimgio to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/ --- (Updated June 11, 2013, 11 a.m.) Status -- This change has been marke

Re: Review Request 108389: Respect the HOME environment variable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated June 11, 2013, 11 a.m.) Status -- This change has been marke

Jenkins build is back to stable : kdelibs_frameworks_qt5 #698

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110478: Move KButtonGroup to KDE4Support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110478/ --- (Updated June 11, 2013, 1:30 p.m.) Status -- This change has been mar

Jenkins build became unstable: kdelibs_frameworks_qt5 #701

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w24

Hello everyone, This is the minutes of the Week 24 KF5 meeting. As usual it has been held on #kde-devel at 4ppm Paris time. Announcements: * I'm back and sebas too :-) * On June 22nd, a KF5 mini-sprint will be held in the Blue Systems Barcelona office Were present: annma, apol, ben2367, df

Re: Review Request 110858: Cleanup KDE development scripts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review34151 --- The perl stuff looks mostly ok, but I found some issues that wo

Review Request 110957: fix compilation with clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/ --- Review request for KDE Frameworks. Description --- Fix compilation wi

Re: Review Request 110957: fix compilation with clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/#review34159 --- staging/kde4support/src/kdecore/kgenericfactory.h

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

Le mercredi 5 juin 2013 23:30:31 Alexander Neundorf a écrit : > On Wednesday 05 June 2013, Alex Merry wrote: > > On 04/06/13 23:01, David Faure wrote: > > > Hm, but why doesn't it work then? I see builddir/libkdeqt5staging/src in > > > both the RPATH and the RUNPATH, and one of these has priority o

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? > > Kevin Ottens wrote: > Yes it should, it shouldn't be in our API. Of course, someone should fix > Qt5

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

> On June 11, 2013, 9:07 a.m., Kevin Ottens wrote: > > This change go in. Note that I disagree with the aim though: KWidgets > > should *not* depend on KIconThemes. Now having KIconThemes not use > > KGlobalSettings is completely welcome (aim being to have KGlobalSettings in > > kde4support at

Re: Review Request 110957: fix compilation using clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/ --- (Updated June 11, 2013, 6:30 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/#review34172 --- This review has been submitted with commit 97dd5694bbbf79da911

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/ --- (Updated June 11, 2013, 6:37 p.m.) Status -- This change has been mar

Re: Review Request 110963: Move KActionMenu to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110963/ --- (Updated June 11, 2013, 6:38 p.m.) Review request for KDE Frameworks. De

Re: Review Request 110963: Move KActionMenu to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110963/ --- (Updated June 11, 2013, 6:38 p.m.) Review request for KDE Frameworks. De

Re: KF5 Update Meeting Minutes 2013-w24

Hi, 2013/6/11 Kevin Ottens: [...] > * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which can perform natural comparison of strings if you use "numeric mode"? Cheers, Frank ___

Re: Review Request 110957: fix compilation using clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/#review34181 --- Ship it! - David Faure On June 11, 2013, 6:30 p.m., Alexande

Re: Review Request 110957: fix compilation using clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/#review34182 --- This review has been submitted with commit 6dc259bba0cc3e745f9

Re: Review Request 110957: fix compilation using clang

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/ --- (Updated June 11, 2013, 8 p.m.) Status -- This change has been marked

Re: Review Request 110874: Move KInputDialog to KDE4Support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110874/ --- (Updated June 11, 2013, 9:11 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kdelibs_frameworks_qt5 #705

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/ --- (Updated June 11, 2013, 10:10 p.m.) Review request for KDE Frameworks. C

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

> On June 11, 2013, 9:07 a.m., Kevin Ottens wrote: > > This change go in. Note that I disagree with the aim though: KWidgets > > should *not* depend on KIconThemes. Now having KIconThemes not use > > KGlobalSettings is completely welcome (aim being to have KGlobalSettings in > > kde4support at

Re: KF5 Update Meeting Minutes 2013-w24

Hello, On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: > 2013/6/11 Kevin Ottens: > [...] > > > * ItemViews will be tier 2 until we contribute the natural compare to Qt; > > I thought that Qt 5.1 will have the QCollator class, which can perform > natural comparison of strings if you us

Re: KF5 Update Meeting Minutes 2013-w24

Hi, thanks for the explanation! 2013/6/12 Kevin Ottens: > Hello, > > On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: >> 2013/6/11 Kevin Ottens: >> [...] >> >> > * ItemViews will be tier 2 until we contribute the natural compare to Qt; >> >> I thought that Qt 5.1 will have the QCollator

Re: KF5 Update Meeting Minutes 2013-w24

On Wednesday 12 June 2013 08:19:40 Frank Reininghaus wrote: > Hi, > > thanks for the explanation! > > 2013/6/12 Kevin Ottens: > > Hello, > > > > On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: > >> 2013/6/11 Kevin Ottens: > >> [...] > >> > >> > * ItemViews will be tier 2 until we con

Re: Review Request 110963: Move KActionMenu to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110963/#review34203 --- Ship it! Ship It! - Kevin Ottens On June 11, 2013, 6:38 p.m

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/#review34204 --- khtml/misc/loader.h