----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review34115 -----------------------------------------------------------
Ship it! This change go in. Note that I disagree with the aim though: KWidgets should *not* depend on KIconThemes. Now having KIconThemes not use KGlobalSettings is completely welcome (aim being to have KGlobalSettings in kde4support at some point). - Kevin Ottens On June 10, 2013, 11:07 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110833/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 11:07 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > As we discussed in the IRC meeting, I removed the KIconLoader dependency to > KWidgets (so that we can make KWidgets depend on KIconLoader). > > I'm unsure if it's the best approach, so I tried to do the simplest > implementation I could. Don't hesitate to suggest changes. > > > Diffs > ----- > > staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e > staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b > staging/kiconthemes/src/kiconloader.cpp 795ec93 > staging/kiconthemes/src/CMakeLists.txt 82828dc > staging/kiconthemes/src/kiconloader.h e4423eb > > Diff: http://git.reviewboard.kde.org/r/110833/diff/ > > > Testing > ------- > > it builds > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
