> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no?
Yes it should, it shouldn't be in our API. Of course, someone should fix Qt5 or our QPA plugin if it doesn't provide the features we need. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110907/#review33977 ----------------------------------------------------------- On June 9, 2013, 1:54 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110907/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 1:54 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Move kdeprintdialog.h and kcups* to kde4support > Fix compilation > Mark as deprecated > Things I am unsure of: the change in khtml/khtmlview.cpp and in > kdeui/dialogs/kshortcutseditor.cpp, some CMakeLists moves as well are to be > checked. > > > Diffs > ----- > > staging/kde4support/src/kdeui/kdeprintdialog.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110907/diff/ > > > Testing > ------- > > Build > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
