> On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote: > > Have we confirmed that Qt5 print dialog provides the options we have here? > > Otherwise it shouldn't go to kde4support, no? > > Kevin Ottens wrote: > Yes it should, it shouldn't be in our API. Of course, someone should fix > Qt5 or our QPA plugin if it doesn't provide the features we need. > > Albert Astals Cid wrote: > Just to confirm, are you saying we are ok with marking things as > deprecated without a replacement? > > David Gil Oliva wrote: > IMHO, we should at least identify those features we want from > KPrintDialog and add the tasks to the "Contributions to Qt5" wiki page. > Otherwise, nobody will do it because nobody will know what should be done. > > Kevin Ottens wrote: > @David: I actually assumed it was already mentionned on the page... if > that's not the case please add it, it should be there. > > @Albert: In some case it might, I think it's one of those. If that makes > you feel better we can put it in kde4attic instead, I wouldn't mind for that > case.
I would sincerely be happier if we don't deprecate classes without providing a way to implement similar functionality. Please note the "if", I am not sure if indeed this is happening in this case or not, that's exactly what I was asking in my first comment. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110907/#review33977 ----------------------------------------------------------- On June 9, 2013, 1:54 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110907/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 1:54 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Move kdeprintdialog.h and kcups* to kde4support > Fix compilation > Mark as deprecated > Things I am unsure of: the change in khtml/khtmlview.cpp and in > kdeui/dialogs/kshortcutseditor.cpp, some CMakeLists moves as well are to be > checked. > > > Diffs > ----- > > staging/kde4support/src/kdeui/kdeprintdialog.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110907/diff/ > > > Testing > ------- > > Build > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
