D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D14661 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, bruns Cc: ngraham, bcooksley, bruns, kde-frameworks-devel, micha

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. In D13869#303905 , @bruns wrote: > And thinking about it, this very likely makes your code wrong. Have you tried mounting a filesystem again after unmounting it, **using via any mean implemented via solid**?

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303861 , @anthonyfieroni wrote: > Since you make question to new code I make for old one, did you know why Device interfaces is ever used, it's look wrong and why interfaces should be empty, after all my tests,

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303877 , @anthonyfieroni wrote: > About loop device it should present as well > http://storaged.org/doc/udisks2-api/2.6.3/gdbus-org.freedesktop.UDisks2.Loop.html > After all you have ony hypothetical argume

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. About loop device it should present as well http://storaged.org/doc/udisks2-api/2.6.3/gdbus-org.freedesktop.UDisks2.Loop.html REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, bruns Cc:

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Since you make question to new code I make for old one, did you why Device interfaces is ever used, it's look wrong and they should be empty, after all my tests, it's easy to see that they are never empty. REPOSITORY R245 Solid REVISION DETAIL https://pha

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303563 , @ngraham wrote: > FWIW, we got a thumbs up from someone in https://bugs.kde.org/show_bug.cgi?id=394348: A thumbs up is nice, but this does not catch the thumbs down of all the persons who are exp

D13869: [solid] Notify when interface to mounted fs is lost

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The change needs a proper commit message. A reference to the bug tracker is not sufficient. The commit message should (at least) include: - Description of the setup - T

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. I'm using too. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: ngraham, bcooksley, bruns, kde-frameworks-devel, michaelh

D13869: [solid] Notify when interface to mounted fs is lost

ngraham added a comment. FWIW, we got a thumbs up from someone in https://bugs.kde.org/show_bug.cgi?id=394348: > Nick Stefanov 2018-08-02 06:59:28 MDT > > I get the Antony's patch from here: > https://phabricator.kde.org/D13869 > I use it two weeks already and so far I haven'

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. For 5.49? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Ping, anything unclear ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Device(udi).interfaces() ("org.freedesktop.UDisks2.Loop", "org.freedesktop.UDisks2.Block") interfaces ("org.freedesktop.UDisks2.Filesystem") REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, df

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This does not answer my question. What I need from you is: > > - which interfaces are in `interfaces` > - which interfaces are in `device.interfaces()` > > so the **exact** case where the patched code

D13869: [solid] Notify when interface to mounted fs is lost

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in udisksmanager.cpp:220 > Old code is complete broken, about me, it does not check any interface except > that it's empty. Can you please just answer the question? REPOSITORY R245 Solid REVISION DETAIL https://phabricato

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This does not answer my question. What I need from you is: > > - which interfaces are in `interfaces` > - which interfaces are in `device.interfaces()` > > so the **exact** case where the patched code

D13869: [solid] Notify when interface to mounted fs is lost

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in udisksmanager.cpp:220 > According to docs, > https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager, > interfaces should not be empty but a dict of looses ones. This does not answer my qu

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Moundting by cdemu also works as expected, not without patch as is described in bug report. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, mic

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Performing working tests - mount -o loop xxx.iso /mnt/xxx - mount xxx/iso /mnt/xxx - Add Android phone - Add second phone, first become inactive, second works REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kd

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni updated this revision to Diff 38153. anthonyfieroni added a comment. First tests looks good, i'll make more later REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13869?vs=37129&id=38153 REVISION DETAIL https://phabricator.kde.org/D13869 AFFE

D13869: [solid] Notify when interface to mounted fs is lost

bcooksley added a comment. Predicates are Solid's query language for searching for only the devices you are interested in. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, mich

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. I'm aware that does not an idea, what is the purpose of Predicate. What should i search in Solid::Predicate::matches? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bruns, kde-framew

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#286746 , @broulik wrote: > Sure, but the device isn't "removed", so emitting a remove signal for something that is still there, is wrong, isn't it? Perhaps we could signal a removal if the device lost *all* its i

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. So about docs when interface is added it will notify again for mounting, i think that's the idea behind interfaces. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bruns, kde-framewor

D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. Sure, but the device isn't "removed", so emitting a remove signal for something that is still there, is wrong, isn't it? Perhaps we could signal a removal if the device lost *all* its interfaces? But it probably doesn't in the unmount case. REPOSITORY R245 Solid

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. So if KFilePlacesModel wants to hide, i don't see how this will break things, it only notify when udisk2 loose interface to mounted fs. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc:

D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. I don't think this is the right approach, technically the device isn't gone but filtered by the client (`KFilePlacesModel` and Device Notifier use a predicate to show only matching devices). This probably needs some "device changed" signal, or even cooler, in `Soli

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This code needs some restructuring, and with the additional conditions, some > comments ... > > 1. `if (udi.isEmpty()) return;` > 2. you are whitelisting a lot of conditions (`... || .. || ...`) - are

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni updated this revision to Diff 37129. anthonyfieroni added a comment. 1. Return early when path is empty 2. Don't check for empty interfaces REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13869?vs=37110&id=37129 REVISION DETAIL https://phab

D13869: [solid] Notify when interface to mounted fs is lost

bruns added inline comments. INLINE COMMENTS > udisksmanager.cpp:220 > > -if (!udi.isEmpty() && (interfaces.isEmpty() || > device.interfaces().isEmpty())) { > +if (!udi.isEmpty() && (!dir.exists() || dir.isEmpty() || > interfaces.isEmpty() > +|| interfaces.contains(UD2_DBUS_INTERF

D13869: [solid] Notify when interface to mounted fs is lost

aacid resigned from this revision. aacid added a comment. Removing myself i don't think i know much/anything about solid, sorry REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni updated this revision to Diff 37110. anthonyfieroni added a comment. Add loop interface REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13869?vs=37108&id=37110 REVISION DETAIL https://phabricator.kde.org/D13869 AFFECTED FILES src/solid/dev

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni created this revision. anthonyfieroni added reviewers: broulik, cfeck, dfaure, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Mostly moun