bruns added inline comments.
INLINE COMMENTS
> udisksmanager.cpp:220
>
> - if (!udi.isEmpty() && (interfaces.isEmpty() ||
> device.interfaces().isEmpty())) {
> + if (!udi.isEmpty() && (!dir.exists() || dir.isEmpty() ||
> interfaces.isEmpty()
> + || interfaces.contains(UD2_DBUS_INTERFACE_FILESYSTEM)
This code needs some restructuring, and with the additional conditions, some
comments ...
1. `if (udi.isEmpty()) return;`
2. you are whitelisting a lot of conditions (`... || .. || ...`) - are the any
cases left where the signal is **not** emitted?
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D13869
To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
