bruns added a comment.
In D13869#303563 <https://phabricator.kde.org/D13869#303563>, @ngraham wrote: > FWIW, we got a thumbs up from someone in https://bugs.kde.org/show_bug.cgi?id=394348: A thumbs up is nice, but this does not catch the thumbs down of all the persons who are exposed to the changed code later, having a different setup. We have seen this in solid several times lately, because every change was only checked to "fix" a non-working case, but omitted all the other cases. Every change should both be checked in a real setup, **and** have a sound reasoning behind it why it is correct. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, bruns Cc: ngraham, bcooksley, bruns, kde-frameworks-devel, michaelh
