Hi Andreas,
thanks for reaching out! You may relicense those LGPL-2.0-only files in
KNotifications with my copyright to be LGPL-2.1-or-later.
I'm CC'ing the kde-frameworks-devel list so that there's a public record of
this :)
Cheers
--
Martin Klapetek
On Sun, Mar 28, 2021 at
repancy was found when doing a license review as part of the
> openSUSE
> package submission process.
>
> Thanks.
>
Absolutely, I hereby give you the permission to relicense those files to
LGPL2.1+.
CC'ing frameworks devel to retain a public record of that.
Cheers
--
Martin Klapetek
mck182 added subscribers: dvratil, mck182.
mck182 added a comment.
@dvratil has slightly more elaborate solution at
https://phabricator.kde.org/D6960
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D6963
To: davidedmundson
Cc: mck182, dvratil, #frameworks
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
Thank you!
REPOSITORY
R289 KNotifications
BRANCH
improve-apidox (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5718
To: elvisangelaccio, mck182
Cc: #frameworks
mck182 added a comment.
+1 looks good, although "Dialog hesla" je zvláštní češtin :)
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D5503
To: lukas, #frameworks
Cc: mck182
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
...provided the usage of `uiLanguages[0]` is safe like this.
INLINE COMMENTS
> DaysCalendar.qml:315
> height: daysCalendar.cellHeight
> -text: Qt.locale().d
mck182 added a comment.
I disagree with this because we currently don't have any
easy and/or sensible way to change date formats and so
we simply suggest using different locales for the different
formats. However, if your UI language is all Spanish and
you want to use the US date format
nt it here, saying that
you would like Baloo to move in this direction, detail out
your proposal and if nobody objects, go ahead and do it.
KDE is about doers, after all :) Also, if you're still a student,
you may want to consider doing this as a GSoC.
Cheers
--
Martin Klapetek
p-and-hold
for context menu, certainly not any of the regular apps.
So I wouldn't say that is "the usual way" on mac at all.
Just to provide some more insight for non-mac folks.
Cheers
--
Martin Klapetek
mck182 added a comment.
Looks like this could work. The `KDE_FULL_SESSION` check is
really old, I'm not sure if this has any implications.
As David noted, the waiting thing should go to Plasma workspace,
that's where it belongs. Also, it would be preferred if the implementation
was p
mck182 added a comment.
> 1. A quick check if KSplashQML is found in the processes list (afaics,
there's no alternatives to ksplash)
> 2. KNotifications could send an async call to KSplash with a very quick
timeout and start deciding on its queued notifications if/after the answer
arrives
mck182 added a comment.
To expand on what Thomas said, SNI is just a specification,
the implementation is fully up to the shells. We chose to
implement it as systray icons, but some innovation there
could take it to much different places. So far nobody has
come with ideas of what that i
On Oct. 16, 2015, 6:52 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125641/
> ---
mck182 added a comment.
Thanks for the patch! I wanted to do exactly this a long
time ago. However this solution brings a burden to all
apps using KNotification in form of a blocking dbus call
which is further only relevant when used in Plasma.
That's a no-no I'm afraid, we'd have to
mck182 added a comment.
> I don't think that KNotification as a framework should hide this feature
from the developer.
I, on the other hand, don't see why the developer should need
this feature; as I said before - there's no scenario where the
app should want either really short or
mck182 added a comment.
Well, I would argue that Android is using exactly indicators
which we know as SNIs. It's the same thing - it's an icon in
your top panel and when you pull the panel down, you see
the title, text and available actions. This is _exactly_ what
SNI does, it just so h
mck182 added a comment.
I see your usecase, but I think there might be better solution overall
and that would involve not actually depending on the notification. As
you say, servers should enforce maximum timeout, Plasma does just
that and there's no safe way to predict what other servers
mck182 added a comment.
This was discussed couple times before and the reason
this was never added is because of potential misuse of
this by setting extremely high value, making the bubble
virtually sticked to your screen forever. This should be
handled by the server that should do the
mck182 added a comment.
In https://phabricator.kde.org/D4416#82951, @hein wrote:
> Gnome-only spec? Why aren't they contributing to fd.o?
"Galago is dead, we took over, deal with it."
https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25
REPOSITORY
R289 KNotifications
BRAN
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
Looks good, should be fine.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4357
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
mck182 added a reviewer: andreask.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D4253
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: varlesh, #breeze, andreask
Cc: #frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101583
---
Ship it!
Ship It!
- Martin Klapetek
On Dec. 26, 2016
tps://git.reviewboard.kde.org/r/129666/#comment67998>
Remove this
src/knotificationrestrictions.cpp (line 82)
<https://git.reviewboard.kde.org/r/129666/#comment67997>
The coding style, as is elsewhere, is newline after comma
- Martin Klapetek
On Dec. 18, 2016, 9:34 a.m., Anthony F
> On Dec. 17, 2016, 4:53 p.m., Martin Klapetek wrote:
> > Just because it "looks annoying" doesn't mean it doesn't have its use.
> >
> > I'll do the git-blame-search for you:
> > https://cgit.kde.org/knotifications.git/commit/?id=3f080d44a
mean it doesn't have its use.
I'll do the git-blame-search for you:
https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f
src/knotificationrestrictions.h (line 97)
<https://git.reviewboard.kde.org/r/129666/#comment67932>
Why?
- Martin Kl
> On Dec. 3, 2016, 5:48 p.m., Martin Klapetek wrote:
> > How about "Using" for the title of the tab and then removing the "Using"
> > label from inside the tab?
> >
> > Also, +1 to putting the version front.
>
> Thomas Pfeiffer wrote:
>
b and then removing the "Using" label
from inside the tab?
Also, +1 to putting the version front.
- Martin Klapetek
On Dec. 3, 2016, 2:39 p.m., Jean-Baptiste Mardelle wrote:
>
> ---
> This is an automatically generated e-m
vertical ;)
- Martin Klapetek
On July 20, 2016, 3:01 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128312/#review96957
---
Ship it!
Looks good!
- Martin Klapetek
On June 28
least the first two stacks are totally vital for Plasma
desktop and really need some attention. If you'd like to put your name on
any of the things above, please let me know. I'll make sure to do a proper
hand-off with explaining everything :)
Cheers
--
Martin Klapetek
tps://git.reviewboard.kde.org/r/128043/#comment64961>
But this is not correct, if you disable the sound in the config, the
soundFilename will be empty and this will cause ::beep() to be executed. But
why if I choose no sound?
- Martin Klapetek
On May 29, 2016, 6:15 p.m., René J.V. Bertin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127925/#review95723
---
Ship it!
Ship It!
- Martin Klapetek
On May 15, 2016
, store
that in a config and then have KNotification/NotifyByAudio simply
do nothing if that config/value is present.
Or even have KNotificationManager::notify(..) skip audio action.
- Martin Klapetek
On May 15, 2016, 12:53 p.m., David Faure wrote
marked as submitted.
Review request for KDE Frameworks and David Gil Oliva.
Changes
---
Submitted with commit f00115a9bb0ddf48d0a34b737583e9d72c5013dd by Martin
Klapetek to branch master.
Repository: kemoticons
Description
---
Right now KEmoticonTheme::parse always returns the
/core/kemoticonsprovider.cpp 5aabd82
Diff: https://git.reviewboard.kde.org/r/127923/diff/
Testing
---
Works as expected plus comes with a simple autotest.
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
---
Works as expected plus comes with a simple autotest.
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127829/#review95170
---
Ship it!
Ship It!
- Martin Klapetek
On May 4, 2016, 3
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127830/#review95168
---
Ship it!
Ship It!
- Martin Klapetek
On May 4, 2016, 3
> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote:
> > You broke the zoomed out view, ie. in the year/decade overview you now get
> > a tick at *every* cell...
>
> Martin Klapetek wrote:
> Oops, I'll fix, thanks.
is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---
On April 21, 2016, 5:41 a.m., Martin Klapetek wrote:
>
> ---
> This is
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 08312b2e340e10d640131c0186e81a0b9f0f2505 by Martin
Klapetek to branch master.
Repository: plasma-framework
Description
---
Simple triangle at the bottom right corner, see
/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde
/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit 9467e77120f1e247933f2c60f91eba40df3eabdf by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
If there is a PersonData that does not have an id,
it's
Tests pass.
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit d4dd58759284ffe09420664e04a7a31e338e9ff1 by Martin
Klapetek to branch master.
Repository: knotifications
Description
---
Adds basic set of unit tests including fake notifications server
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit dae4401f6d85c22074b3160cc3ae33b91d986468 by Martin
Klapetek to branch master.
Bugs: 358589
https://bugs.kde.org/show_bug.cgi?id=358589
Repository: knotifications
Description
---
As
xygen/widgets/tooltip.svgz 33d0bb5
src/desktoptheme/oxygen/widgets/translucentbackground.svgz 47b418d
src/desktoptheme/oxygen/widgets/viewitem.svgz cec433e
Diff: https://git.reviewboard.kde.org/r/126949/diff/
Testing
---
Thanks,
Martin Kla
otification.cpp 17b0be2
src/knotificationmanager.cpp e80d48c
src/knotificationplugin.cpp acf964c
src/notifybypopup.cpp c0050b2
Diff: https://git.reviewboard.kde.org/r/127398/diff/
Testing
---
Unit tests all pass.
Thanks,
Martin Klapetek
__
/kstatusnotifieritem.cpp f9bf460
Diff: https://git.reviewboard.kde.org/r/127452/diff/
Testing
---
According to David Jarvie in that bug report, it works.
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
ll,
> > it's this possible, maybe not. Counters it's not good idea to be signed.
>
> Martin Klapetek wrote:
> Yes...if your application will emit more than 32767 notifications in its
> lifetime. At which point the application is probalby broken.
>
> Alber
nt.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127398/#review93676
-------
On March 16, 2016, 9:23 p.m., Martin Klapetek wrote:
>
>
> > see http://woboq.com/blog/qstringliteral.html for explanation and
> > https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b
> > for the case when QBAL are not suitable
>
> Martin Klapetek wrote:
> Is QByteArrayLiter
64c
src/notifybypopup.cpp b9489c1
Diff: https://git.reviewboard.kde.org/r/127398/diff/
Testing
---
Unit tests all pass.
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailma
5.4? I can't find any info about it
anywhere.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88099
-----
marked as submitted.
Review request for KDE Frameworks and John Layt.
Changes
---
Submitted with commit e311a7a845a35a4e82e786cdd4d07592624f6741 by Martin
Klapetek to branch master.
Repository: kholidays
Description
---
For now it contains just the model of holiday regions
which
part
of KDE Applications and not Frameworks and KDE apps have dependency
freeze tonight, so I'm pushing this now in order to have the events
done in Plasma 5.7.
The QByteArrayLiterals can still be fixed once I get the answer
to the issue.
- Martin Klapetek
On March 16, 2016, 10:24 p.m., M
ard.kde.org/r/127398/#review93674
---
On March 16, 2016, 9:23 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit a72809761419457b803e13ab91c1a1950b5f9ac8 by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
For single contact without any person, PersonData does not work
.
Diffs (updated)
-
autotests/persondatatests.cpp 5f7cabd
src/persondata.cpp 4586bac
Diff: https://git.reviewboard.kde.org/r/127348/diff/
Testing
---
PersonData returns correct data
Thanks,
Martin Klapetek
___
Kde-frameworks-devel
)
-
autotests/persondatatests.cpp 5f7cabd
src/persondata.cpp 4586bac
Diff: https://git.reviewboard.kde.org/r/127348/diff/
Testing
---
PersonData returns correct data
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks
---
PersonData returns correct data
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit 2dec39f0c62a6279a558ab6a7ada830c5cc2a200 by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
If the app using KPeople is also using a QSqlDatabse and also
with
> On March 10, 2016, 2:56 p.m., Martin Klapetek wrote:
> > Can you please explain clearly the problem this should solve and explain
> > more clearly how this solves that problem?
> >
> > Also I see with your every review "I have not tested this", please do
and explain more
clearly how this solves that problem?
Also I see with your every review "I have not tested this", please do test your
patches before posting them.
- Martin Klapetek
On March 10, 2016, 10:28 a.m., Anthony Fie
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127314/#review93332
---
Ship it!
Ship It!
- Martin Klapetek
On March 9, 2016
> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote:
> > Ping
>
> Martin Klapetek wrote:
> Does not work for Quassel and Konversation, I'd like to know why before I
> approve your patch.
>
> Martin Klapetek wrote:
> Ah, interestingly I've n
o reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
>
> (Updated Feb. 29, 2016, 6:18 a.m.)
>
>
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin
> Klapetek.
>
>
>
> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote:
> > Ping
>
> Martin Klapetek wrote:
> Does not work for Quassel and Konversation, I'd like to know why before I
> approve your patch.
Ah, interestingly I've never received the replies you made above. Mu
> On Feb. 29, 2016, 7:59 p.m., Martin Klapetek wrote:
> > This works in 50% of cases for me. I'm not sure if Quassel and Konversation
> > are doing something special wrt to restoring position but this doesn't fix
> > it.
>
> Anthony Fieroni wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93126
---
Looks good, +1
- Martin Klapetek
On March 3, 2016, 9:34
-
src/personmanager.cpp 5c2d7af
Diff: https://git.reviewboard.kde.org/r/127267/diff/
Testing
---
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
l message panels as well.
>
> Andreas Kainz wrote:
> good to know. not every icon is an icon some are hard coded some are
> drawn by application (QStyle), ... so can you close the bug report Heiko.
> David say no changes before bugs are solved and I'd like to make some chang
> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote:
> > hi, heiko fill a bug report cause you cant see the x icon
> > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that
> > knewpassworddialog use an icon cause there is no x icon. is this icon used
> > from KNewPasswordDialog?
assel and Konversation are
doing something special wrt to restoring position but this doesn't fix it.
- Martin Klapetek
On Feb. 29, 2016, 6:18 a.m., Anthony Fieroni wrote:
>
> ---
> This is an automatically generated e-ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127210/#review92925
---
Ship it!
Ship It!
- Martin Klapetek
On Feb. 28, 2016
marked as submitted.
Review request for KDE Frameworks, KDEPIM and Plasma.
Changes
---
Submitted with commit 6ef69a8a17985926ad89543ba932f835d455cec8 by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
I've done this quite some time ago but noticed only
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit bdff68dea3cbe5e59d7c65c7961667ddab0849dc by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
For filtering multiple properties the logic needs to be OR
rather
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit 28843fa2d256dd213ee636eaa552bf892586576e by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
The KPeople::ActionType is just a namespaced enum, so here
marked as submitted.
Review request for KDE Frameworks and KDEPIM.
Changes
---
Submitted with commit cc09522974fe48a58ffc711f8f79023c59f4dfbe by Martin
Klapetek to branch master.
Repository: kpeople
Description
---
This allows filtering for only specific action types
Diffs
s is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92701
---
On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
>
> ---
Description
---
The KPeople::ActionType is just a namespaced enum, so here's a wrapper
that makes it usable from QML
Diffs
-
src/declarative/peopleqmlplugin.cpp 1e0516a
Diff: https://git.reviewboard.kde.org/r/127164/diff/
Testing
---
Works all good.
Thanks,
Martin Kla
Description
---
This allows filtering for only specific action types
Diffs
-
src/declarative/personactionsmodel.cpp ccdc6e6
src/declarative/personactionsmodel_p.h 8032ab9
Diff: https://git.reviewboard.kde.org/r/127163/diff/
Testing
---
Thanks,
Martin Klapetek
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
After
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png
Thanks,
Martin Kla
https://git.reviewboard.kde.org/r/127117/diff/
Testing
---
I get both phonenumber and IM contacts in Plasma Mobile
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinf
only those contacts that have both
and user merged them).
Diffs
-
src/personssortfilterproxymodel.cpp b011cbd
Diff: https://git.reviewboard.kde.org/r/127117/diff/
Testing
---
I get both phonenumber and IM contacts in Plasma Mobile
Thanks,
Martin Kla
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92237
---
+1
- Martin Klapetek
On Feb. 10, 2016, 6:10 p.m., David
omatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126650/#review92227
---
On Jan. 26, 2016, 7:13 p.m., Martin Klapetek wrote:
>
> ---
the issue? Should we look into un-deprecating it?
>
Yes; a replacement for the inhibition functions is being done
at https://git.reviewboard.kde.org/r/126650/
Cheers
--
Martin Klapetek | KDE Developer
___
Kde-frameworks-devel mailing list
Kde-f
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
>
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here:
> http://paste.opensuse.org/view/raw/6071
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
>
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here:
> http://paste.opensuse.org/view/raw/6071
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
>
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here:
> http://paste.opensuse.org/view/raw/6071
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
>
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here:
> http://paste.opensuse.org/view/raw/6071
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
>
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here:
> http://paste.opensuse.org/view/raw/6071
On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
&g
To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
-------
On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatical
dgets/translucentbackground.svgz 47b418d
src/desktoptheme/oxygen/widgets/viewitem.svgz cec433e
Diff: https://git.reviewboard.kde.org/r/126949/diff/
Testing
---
Thanks,
Martin Klapetek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---
On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
>
> -
.cpp PRE-CREATION
autotests/qtest_dbus.h PRE-CREATION
src/CMakeLists.txt 23e5e29
src/inhibition.h PRE-CREATION
src/inhibition.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126650/diff/
Testing
---
Everything works as expected, plus there's an a
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 311cde3ba5d884da15905096732b9cb8eba2bedd by Martin
Klapetek to branch master.
Repository: plasma-framework
Description
---
[plasmaquick/dialog] Don't use KWindowEffect
1 - 100 of 672 matches
Mail list logo
