> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made above. Must > have ended in some @kde.org filter or something. > > Thomas Lübking wrote: > Didn't receive them either. > Either Anthony forgot to push the "publish" button (happens.... ;-) or > kde.org took a nap. > > Anthony Fieroni wrote: > It was publish, since i'm not KDE dev, i don't have kde.org account :)
There's actually a new checkbox, "Send Email", must have been unchecked then. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93128 ----------------------------------------------------------- On Feb. 29, 2016, 6:18 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127216/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 6:18 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin > Klapetek. > > > Bugs: 356523 > https://bugs.kde.org/show_bug.cgi?id=356523 > > > Repository: knotifications > > > Description > ------- > > Store position of widget before hide it > > > Diffs > ----- > > src/kstatusnotifieritem.cpp cf3e7b5 > src/kstatusnotifieritemprivate_p.h 8fdfd4c > > Diff: https://git.reviewboard.kde.org/r/127216/diff/ > > > Testing > ------- > > Tested on pixel ration = 1 > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
