----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review93625 -----------------------------------------------------------
Ok so I shipped this because I realized KHolidays is still part of KDE Applications and not Frameworks and KDE apps have dependency freeze tonight, so I'm pushing this now in order to have the events done in Plasma 5.7. The QByteArrayLiterals can still be fixed once I get the answer to the issue. - Martin Klapetek On March 16, 2016, 10:24 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125965/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 10:24 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kholidays > > > Description > ------- > > For now it contains just the model of holiday regions > which will be used in the Plasma calendar events > configuration. > > > Diffs > ----- > > CMakeLists.txt e8b7970 > src/CMakeLists.txt c067b6c > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/holidayregionsmodel.h PRE-CREATION > src/declarative/holidayregionsmodel.cpp PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125965/diff/ > > > Testing > ------- > > Applet configuration contains proper list of available > holiday regions. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
