> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog? can it be colored in white #f2f2f2. > > > > thanks for the feedback. maybe you can answer on the bug report. > > Elvis Angelaccio wrote: > Hi. The problem is the X icon/button in this screenshot: > https://git.reviewboard.kde.org/r/126523/file/2643/ > > Andreas Kainz wrote: > yes is it really an icon? > > Elvis Angelaccio wrote: > Mmm you're right. Doesn't look like an icon from Breeze: > > > `closeAction->setIcon(q->style()->standardIcon(QStyle::SP_DialogCloseButton));` > (from kmessagewidget.cpp) > > So it's an icon coming from the `QStyle`. I guess you should ask some > Plasma guy to have a look... > > Heiko Tietze wrote: > What else if not an icon? Anyway it was removed from the dialog - and > probably from all message panels as well. > > Andreas Kainz wrote: > good to know. not every icon is an icon some are hard coded some are > drawn by application (QStyle), ... so can you close the bug report Heiko. > David say no changes before bugs are solved and I'd like to make some changes. > > Martin Klapetek wrote: > It's "window-close", likely coming from QCommonStyle. Which seems wrong > because our frameworksintegration plugin implements this style hint to be > "dialog-close" (which would improve the situation somewhat but would still be > red-on-red). So either our style override does not work or this is not run > with breeze/frameworkintegration loaded; needs more investigation I guess.
Aha, so it depends on how breeze style is built, it can extend both QCommonStyle and KStyle (which is in frameworksintegration), so that's why it uses "window-close"; your build is not built with KStyle. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review92946 ----------------------------------------------------------- On Feb. 1, 2016, 7:47 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126523/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 7:47 p.m.) > > > Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, Christoph > Feck, and David Faure. > > > Repository: kwidgetsaddons > > > Description > ------- > > Currently a KNewPasswordDialog makes use of a KTitleWidget to display > messages to the user about the password status (e.g. "password too short", > etc.). This looks out of place, and so does the associated icon (see > screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ ) > > This patch replaces the KTitleWidget with a KMessageWidget. I also > "downgraded" some of the previous "error" red icons to a > `KMessageWidget::Warning` type (the orange one in the screenshots), because > those kind of messages may be displayed before the user even started typing > something as password. > > > Diffs > ----- > > src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d > src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f > > Diff: https://git.reviewboard.kde.org/r/126523/diff/ > > > Testing > ------- > > The KMessageWidgets behaves exactly like the KTitleWidget before: initially > is hidden, then is displayed as soon as the user interacts with the password > fields. > > > File Attachments > ---------------- > > pwd-dialog-1.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png > pwd-dialog-2.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png > pwd-dialog-3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
