Re: KInit - Current state and benchmarks

On Sat, 22 Jun 2019 at 11:21, David Edmundson wrote: > > Benchmarks of dolphin on a low end ARM laptop: > Dolphin via QProcess: 1233ms > Dolphin via Kinit: 1144ms > > again a consistent saving in the order of ~7% > > Initially I had wanted to scrap it, I'm now very conflicted. > > I'll try to po

Re: Review Request 126161: OS X housekeeping

On 26 November 2015 at 18:51, Alex Merry wrote: > On 2015-11-26 09:27, René J.V. Bertin wrote: >> >> There's something I don't really understand though: the exact same >> question you asked above. >> What's the difference between starting kwrite directly on the >> commandline (or through execve())

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

On 6 October 2015 at 11:15, Sebastian Kügler wrote: > On Mon, 05 Oct 2015 10:36:23 - > "Alex Richardson" wrote: >> https://git.reviewboard.kde.org/r/125261/ > >> This change has been discarded. > >> Description >> --- >> >> When loading a .desktop file this will parse the XDG MimeType= ke

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

2015-02-21 14:43 GMT+00:00 Marco Martin : > On Sat, Feb 21, 2015 at 1:34 PM, Alexander Richardson > wrote: >> and then we could also have something like >> KServiceTypeTrader::findPlugin(serviceType, name) that expands to >> KServiceTypeTrader::self()->query(service

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

2015-02-21 10:02 GMT+00:00 Marco Martin : > Hi all, > As you may have noticed, right now starting plasma is a big spam of > the following error: > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, > use KPluginInfo::pluginName() in "/whatever/plugin.so" instead. > > i tried to s

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

Testing --- The newly added unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121495: Fix build if the X11 headers are not located in /usr/include

66fb17c4091fb9171ad4fac577685ebb21a57c04 Diff: https://git.reviewboard.kde.org/r/121495/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121496: Fix build if the X11 headers are not located in /usr/include

Description --- Fix build if the X11 headers are not located in /usr/include Diffs - src/CMakeLists.txt 9038adc2d5c61cf03132751fba9333f75ac4a561 Diff: https://git.reviewboard.kde.org/r/121496/diff/ Testing --- Thanks, Alexander Richardson

Re: Review Request 121495: Fix build if the X11 headers are not located in /usr/include

and Martin Gräßlin. Repository: kwindowsystem Description --- Fix build if the X11 headers are not located in /usr/include Diffs - CMakeLists.txt 3f93712e8aa3b842a0a589637a315ee5c0e737bd Diff: https://git.reviewboard.kde.org/r/121495/diff/ Testing --- Thanks, Alexander

Review Request 121495: Fix build if the X11 headers are not located in /usr/include

Description --- Fix build if the X11 headers are not located in /usr/include Diffs - CMakeLists.txt 3f93712e8aa3b842a0a589637a315ee5c0e737bd Diff: https://git.reviewboard.kde.org/r/121495/diff/ Testing --- Thanks, Alexander Richardson

Re: KF 5.5.0 changelog

2014-12-06 14:59 GMT+00:00 David Faure : > Here's the changelog I wrote for 5.5.0. > > Please everyone remember to use CHANGELOG in your commits, with > a standalone description of the issue (i.e. which doesn't use the modified > filenames as implicit context). > > I tried to grab what I could from

Re: Review Request 121317: Add JSON metadata to the kded modules

- On Dez. 1, 2014, 4:56 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121317/ > -

Review Request 121317: Add JSON metadata to the kded modules

/kcookiejar/kcookieserver.cpp c441496dff316d4e94a4cccdfd46615cd76a7238 src/ioslaves/http/kcookiejar/CMakeLists.txt 890a35bcc24ca043844257f3d2cdd0941ddd1d17 Diff: https://git.reviewboard.kde.org/r/121317/diff/ Testing --- the converted modules can be loaded Thanks, Alexander

Re: Review Request 121314: KPluginInfo: store d->entryPath in KPluginMetaData instead

e35169e6d5f901bb79cf7881ecacfbff81650a31 Diff: https://git.reviewboard.kde.org/r/121314/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121315: Allow using kded modules with JSON metadata

--- everything seems to work correctly. No plugins are converted yet so they are all still loaded from .desktop files Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 121305: convert to new signal slot syntax and categorized logging

://git.reviewboard.kde.org/r/121305/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121314: KPluginInfo: store d->entryPath in KPluginMetaData instead

--- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121313: Introduce KPluginMetaData::metaDataSource()

Diff: https://git.reviewboard.kde.org/r/121313/diff/ Testing --- unit test passes Not sure if `metaDataSource()` is a good name, after all the class is already called KPluginMetaData. Maybe just `source()`? Thanks, Alexander Richardson ___ Kde

Review Request 121313: Introduce KPluginMetaData::metaDataSource()

sure if `metaDataSource()` is a good name, after all the class is already called KPluginMetaData. Maybe just `source()`? Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

/QPluginLoader which resolves those paths anyway) I will adapt kplugininfotest in KService to this change. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

solved. - Alexander Richardson On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121305: convert to new signal slot syntax and categorized logging

Description --- 2 small commits: - convert to new signal slot syntax - Use categorized logging Diffs - src/kded.cpp 74e7dbfe9fb0f270b090a9aa65a394a8b1a63527 Diff: https://git.reviewboard.kde.org/r/121305/diff/ Testing --- compiles Thanks, Alexander Richardson

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

viewboard.kde.org/r/121218/#review71120 --- On Nov. 30, 2014, 2:29 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

The newly added unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

connect in KActionCollection::add[Action]() Diffs - src/kactioncollection.h 879f5920bddc04c9ff48d137ae386a860382 Diff: https://git.reviewboard.kde.org/r/121283/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel

Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

--- Allow using new style connect in KActionCollection::add[Action]() Diffs - src/kactioncollection.h 879f5920bddc04c9ff48d137ae386a860382 Diff: https://git.reviewboard.kde.org/r/121283/diff/ Testing --- Thanks, Alexander Richardson

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

rd.kde.org/r/121218/diff/ Testing --- The newly added unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

0b7 Diff: https://git.reviewboard.kde.org/r/121218/diff/ Testing --- The newly added unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121276: KPluginInfo::category() instead of property("X-KDE-PluginInfo-Category")

.kde.org/r/121276/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121276: KPluginInfo::category() instead of property("X-KDE-PluginInfo-Category")

--- KPluginInfo::category() instead of property("X-KDE-PluginInfo-Category") Diffs - src/kpluginselector.cpp a0d4568c9004b97a3130e699f10847540065a82a Diff: https://git.reviewboard.kde.org/r/121276/diff/ Testing --- Thanks, Alexander

Re: Review Request 121262: make kservice_desktop_to_json warning an author_warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121262/#review70995 --- Ship it! Ship It! - Alexander Richardson On Nov. 27, 2014

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

/120199/diff/ Testing --- Unit test still passes after applying RR 120198, not sure if it works without it. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

ontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 Diff: https://git.reviewboard.kde.org/r/121218/diff/ Testing --- The newly added unit test passes Thanks, Alexander

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

://git.reviewboard.kde.org/r/120198/diff/ Testing --- All unit tests still work Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

s://git.reviewboard.kde.org/r/120198/#review70220 ------- On Nov. 7, 2014, 4:38 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

remember having to do this a few times manually as well. Would it make sense to add the macro to KCoreAddons? - Alexander Richardson On Nov. 8, 2014, 11:26 nachm., Andrius da Costa Ribas wrote: > > --- > This is an automatically ge

Re: Review Request 121082: Add TODO for private signals in KJob

> On Nov. 9, 2014, 8:09 nachm., Alexander Richardson wrote: > > Ship It! Strangely enough you can connect using new-style syntax when you use clang... Sorry for breakig the kdevplatform build - Alexander --- This is an auto

Re: Review Request 121082: Add TODO for private signals in KJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121082/#review70124 --- Ship it! Ship It! - Alexander Richardson On Nov. 9, 2014

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

passes after applying RR 120198, not sure if it works without it. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

://git.reviewboard.kde.org/r/120198/diff/ Testing --- All unit tests still work Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

/ Testing --- All unit tests still work Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

/ Testing --- Unit test still passes after applying RR 120198, not sure if it works without it. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

src/services/kplugininfo.cpp 50a6564edbbb1890c0b91badad69db967035231f Diff: https://git.reviewboard.kde.org/r/120825/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/#review69495 --- On Okt. 29, 2014, 8:37 nachm., Alexander Richardson wrote: > > -

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

t next week. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review68857 --- On Sept. 14, 2014, 4:05 nachm., Alexande

Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

://git.reviewboard.kde.org/r/120825/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

lative paths. > > David Faure wrote: > I can look into adding that somewhen, but if you feel like making a Qt > submission, go ahead of course. > > Alexander Richardson wrote: > I can add it to Qt, just have to figure out how to use Gerrit h

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

s is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120833/#review69357 ------- On Okt. 27, 2014, 10:51 nachm., Alexander Richardson wrote: > > ---

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

) - autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 Diff: https://git.reviewboard.kde.org/r/120833/diff/ Testing --- Unit test passes Thanks,

Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

pluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 Diff: https://git.reviewboard.kde.org/r/120833/diff/ Testing --- Unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-de

Re: Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

43648114224f476ea3c30f6bd255206f9c415d21 Diff: https://git.reviewboard.kde.org/r/120586/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

tocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

--- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/#review67273 --- Ping? - Alexander Richardson On Sept. 23, 2014, 10:36 vorm

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

https://git.reviewboard.kde.org/r/119081/diff/ Testing (updated) --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

eply, visit: https://git.reviewboard.kde.org/r/120198/#review67234 --- On Sept. 14, 2014, 4:05 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mai

Re: desktoptojson man page

Hi Micheal, 2014-09-15 19:57 GMT+02:00 Michael Palimaka : > Hi there, > > In kservice at b427f4c3889004d9d983939cd9bf7c1465e6beb3, desktoptojson > was replaced/moved to kcoreaddons. However, it appears the man page was > forgotten and that still exists in kservice. I'd move it myself, but I'm > not

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

> On Sept. 14, 2014, 2:26 nachm., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644 > > --- a/src/urifilters/shorturi

Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

works without it. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

tests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing --- Unit test passes Thanks, Alexander Richa

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

iewboard.kde.org/r/119936/#review65863 --- On Aug. 28, 2014, 9:48 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

d.kde.org/r/119970/#review65865 --- On Aug. 28, 2014, 9:50 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

dated) --- Unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 119936: Add a basic unit test for KPluginInfo

/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing --- Unit test passes, however I would like some feedback on the three TODO: comments. Is this intended behaviour or should it be fixed? Thanks, Alexander

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

: https://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

t; ... > > } The problem here is that this creates a global constructor which increases library load time. I assumed the compiler would be clever enough to merge the string literals (even if they are unicode literals), but I didn't check it. - Alexander ---

Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119936: Add a basic unit test for KPluginInfo

da83f46a9dcd1fa7801bead5715abf51cd12d668 autotests/kplugininfotest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing --- Unit test passes, however I would like some feedback on the three TODO: comments. Is this intended behaviour or should it be fixed? Thanks, Alexander Richardson

Re: Review Request 119936: Add a basic unit test for KPluginInfo

it be fixed? Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119936: Add a basic unit test for KPluginInfo

on the three TODO: comments. Is this intended behaviour or should it be fixed? Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119356/diff/ Testing --- Unit test works and passes. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

://git.reviewboard.kde.org/r/119356/diff/ Testing --- Unit test works and passes. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing

27493e14e7 Diff: https://git.reviewboard.kde.org/r/119849/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing

g/r/119849/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing

ystem" in directory /foo/bar Now we print: The XRender library could not be found. Please install the development package for it. Diffs - src/CMakeLists.txt 2794ed1e6f56ed521d845bc20ba1c027493e14e7 Diff: https://git.reviewboard.kde.org/r/119849/diff/ Testing --- Thanks,

Re: Review Request 119382: Port kio-mtp to KF5

rn the full url without trailing slash, not just the path. As far as I can see it is only used once, so not much reason to keep it. - Alexander Richardson On Juli 21, 2014, 1:54 nachm., Jan Grulich wrote: > > --- > T

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

ard.kde.org/r/119079/#review62844 --- On Juli 22, 2014, 1:17 nachm., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

thout needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

en directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

EATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

3ff1b0 Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

On Juli 19, 2014, 11:27 vorm., Alexander Richardson wrote: > > I see you haven't changed the KPluginLoader methods - have you looked to > > see if they are the ones that are likely to be useful? I looked at KDevelop and Kate, and it seems there the version return a list of

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

EATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-fram

Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

test works and passes. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119345: Port away from deprecated QUrl API

40ee8876e7fc5f6eae322254f074110c321a33fc Diff: https://git.reviewboard.kde.org/r/119345/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119345: Port away from deprecated QUrl API

, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

here: https://git.reviewboard.kde.org/r/119081/ , just without the renaming of the output file. - Alexander Richardson On Juli 16, 2014, 5:20 nachm., Dan Vrátil wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

> On Juli 13, 2014, 1:17 nachm., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > > > > > I'm not sure if this is the correct approach either. > > > > When i'm looking at file.cpp (in kio/src/ios

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

.com"] } ], }, } And also allowing this for the case with only one author: { "KPlugin": { ... "Authors": { "Name": "Abc Def", "Email": "a...@def.ghi" }, }, } - Alexander

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

EATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

. Yeah thats right, I though QStringLiteral didn't cause a global constructor call, but clang -Wglobal-constructors proved me wrong. Since these keys are used only once (except for MetaData), I guess I could just get rid of those global statics and insert a QStringLiteral in the function that

  1   2   3   4   5   >