----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ -----------------------------------------------------------
(Updated Aug. 28, 2014, 9:48 nachm.) Review request for KDE Frameworks. Summary (updated) ----------------- Fix inconsistencies in KPluginInfo and add a basic unit test Repository: kservice Description (updated) ------- This is a series of small commits, I hope it is fine to have them as one diff: --- Add a basic unit test for KPluginInfo --- KPluginInfoTest: Also test reading a custom property --- Also test KPluginInfo(KService::Ptr) constructor --- Fix KPluginInfo::libraryPath() when constructing from a .desktop file --- Fix KPluginInfo::dependencies() when constructing from a .desktop file Previously it would treat X-KDE-PluginInfo-Depends= (with no value) as a string list with one element (the empty string). When constructing from a KService::Ptr using the same file we get an empty string list as one would expect. This makes the behaviour of the KPluginInfo(QString) constructor match the KPluginInfo(KService::Ptr) version. --- Fix KPluginInfo::isValid() when constructing from a .desktop file Previously it would always return true, even if the file didn't exist or was no valid .desktop file. --- Fix KPluginInfo::libraryPath() when constructing from a KService::Ptr Diffs (updated) ----- autotests/CMakeLists.txt da83f46a9dcd1fa7801bead5715abf51cd12d668 autotests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing (updated) ------- Unit test passes Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
