> On Okt. 29, 2014, 10:29 nachm., David Faure wrote: > > autotests/kplugininfotest.cpp, line 67 > > <https://git.reviewboard.kde.org/r/120825/diff/1/?file=322224#file322224line67> > > > > this comment doesn't match the expected result anymore....
Yeah, forgot to remove that comment. > On Okt. 29, 2014, 10:29 nachm., David Faure wrote: > > src/services/kplugininfo.cpp, line 130 > > <https://git.reviewboard.kde.org/r/120825/diff/1/?file=322225#file322225line130> > > > > Just to make sure I understand -- entryPath will be like > > /full/path/to/plugin.so ? > > Isn't there a risk that some code will try to open it with a .desktop > > file parser? > > (e.g. KService). Yes, it will return the full path to the .so. In https://git.reviewboard.kde.org/r/120586/ it was suggested to change entryPath(). I don't know if there are any applications that are affected by this. If they used entryPath() on a non .desktop plugin before this patch it would fail because the file is not found, now it should fail because the file cannot be parsed. An alternative would be to provide a new function e.g. `QString metaDataSource()` and deprecate entryPath(), that way applications would get a compiler warning because of the new semantics. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/#review69495 ----------------------------------------------------------- On Okt. 29, 2014, 8:37 nachm., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120825/ > ----------------------------------------------------------- > > (Updated Okt. 29, 2014, 8:37 nachm.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kservice > > > Description > ------- > > Fix KPluginInfo::entryPath() being empty when not loaded from .desktop > > > Diffs > ----- > > autotests/kplugininfotest.cpp 34f87028ce08f2db1e5f57edbc6f99a237bf90ac > src/services/kplugininfo.cpp 50a6564edbbb1890c0b91badad69db967035231f > > Diff: https://git.reviewboard.kde.org/r/120825/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
