> On Nov. 10, 2014, 9:57 nachm., David Faure wrote: > > src/services/kplugininfo.cpp, line 47 > > <https://git.reviewboard.kde.org/r/120198/diff/3/?file=326715#file326715line47> > > > > Missing "static" before inline, if these methods are only used in this > > .cpp file.
I put it all in an anonymous namespace as Milian suggested. Should be equivalent to marking them as static. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review70220 ----------------------------------------------------------- On Nov. 7, 2014, 4:38 nachm., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120198/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 4:38 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > A series of 4 commits: > > ---- > > KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage > > This means that KPluginInfo can now simply reuse the QJsonObject > returned by QPluginLoader.metaData() (by storing it in a > KPluginMetaData object instead of having to convert the JSON to a > QVariantMap first. > > Additionally this allows very efficient conversion between KPluginInfo > and KPluginMetaData. > > --- > Add compatibility key names to KPluginInfo::property() > > --- > > KPluginInfo: Fix loading JSON metadata that only has compatibility keys > > This can be removed in KF6, but for now allows loading all both old > style as well as new style metadata > > ---- > > kplugininfotest: also test objects constructed from JSON > > This tests both new style JSON as well as JSON using the old key names > > > Diffs > ----- > > src/services/kplugininfo.cpp 54593e57ca2b898a7d68de2915b7e40c3aa96f5f > autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 > autotests/kplugininfotest.cpp 9d4ee046db1e5d0b9f30a9a68929147763ee1cfa > src/services/kplugininfo.h 871d6a2ead5a9b358d864372152cbfa0c43d8a68 > > Diff: https://git.reviewboard.kde.org/r/120198/diff/ > > > Testing > ------- > > All unit tests still work > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
