D19102: Fix extraction of aspect ratio property

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Thats obviously just avoiding the rules. You can ask for an exception anyway. The intention was to land the fix as soon as possible while complying to the rules,

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. Much better, thanks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19035: Help build on Windows with usage of CMake Targets

cullmann added a reviewer: vkrause. cullmann added a comment. I think I let Volker decide that, for non-cross compile stuff this is more or less a nop and I never do cross compiling ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: dantti, #fr

D19163: Make it possible to show all spaces in the document

cullmann added a comment. I like the feature, but for the implementation: Could we alter the config to itself hold the enum? An other thing: why was the non-printable regex altered? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: cullm

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. If you pass me your author email, I will push that. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sa

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, other things looks reasonable to me. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 20 Feb 2019 04:52:43 + Build duration: 42 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Feb 2019 04:52:43 + Build duration: 22 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 04:52:43 + Build duration: 3 min 52 sec and counting JUnit Tests Nam

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#415677 , @trickyricky26 wrote: > I will make some minor changes to the 64px design. Sure thing, sorry about being lazy and not updating the screenshots 😅 REPOSITORY R266 Breeze Icons REVISION DETAIL

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19163: Make it possible to show all spaces in the document

ngraham added a comment. I have wanted this for so long! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, gennad, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19163: Make it possible to show all spaces in the document

apol added a comment. F6624272: kate-spaces.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauma

D18853: Fix sharing files with spaces or quotes in names via Telegram

mikhailru updated this revision to Diff 52123. mikhailru added a comment. @apol, thanks for a nice suggestion! I somehow missed KShell::quoteArg. :) REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18853?vs=51187&id=52123 BRANCH telegram-sharing-

D19101: Increase precision of frame rate property

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_framerate REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoor

D19102: Fix extraction of aspect ratio property

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > astippich wrote in formatstrings.cpp:157 > That was actually done deliberately to get this in for Kf 5.56 since there is > string freeze. But if concatenation is a no go,

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns added a comment. In D19087#415703 , @astippich wrote: > The stringlist case is still not handled. Thats the reason I have not marked the comment as done ... > And a test case for multiple ints (2 ReleaseYear properties) will al

D19168: Fix crash in Dolphin when dropping trashed file in trash

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, just some minor improvement suggestions for the unittest. INLINE COMMENTS > dropjobtest.cpp:361 > +KIO::CopyJob *copyJob = KIO::move(QUrl::fromLocalFile(m_srcF

D19170: Fix crash while moving files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. If some code is deleting this job from a slot connected to it, that code needs to be fixed. This hack isn't a fix, it will only create more problems.. E.g. if some other bad c

D19109: [Extractor] Add metadata to extractors

bruns added a comment. In D19109#415710 , @astippich wrote: > In D19109#414968 , @bruns wrote: > > > In D19109#414758 , @astippich wrote: > > > > > A f

D19168: Fix crash in Dolphin when dropping trashed file in trash

dhaumann added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

dhaumann added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19170 To: hallas, #frameworks, elvisangelaccio, dfaure Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich added a comment. In D19098#414973 , @bruns wrote: > In D19098#414729 , @astippich wrote: > > > It already does at two different places, because it fuses different information into a single

D19109: [Extractor] Add metadata to extractors

astippich added a comment. In D19109#414968 , @bruns wrote: > In D19109#414758 , @astippich wrote: > > > A few general remarks: > > > > - I really do not like that there are two lists of supporte

D19170: Fix crash while moving files

dhaumann added inline comments. INLINE COMMENTS > kjob.cpp:105 > > +if (isAutoDelete()) { > +deleteLater(); Alternatively to moving the code, you could also use a `QPointer that(this);` to monitor whether the QObject is still existing. Then, you'd have to call if (that && isAu

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. The stringlist case is still not handled. And a test case for multiple ints (2 ReleaseYear properties) will also likely fail. When going with JSON, I think this has to be do

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

dhaumann added a comment. Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19161 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: kde

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

dhaumann added a comment. This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278. But yes, the Qt documentation says to use TextUnderlineStyle instead of FontUnderline. The implementation of fontUnderline()

D19102: Fix extraction of aspect ratio property

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Proper i18n That was actually done deliberately to get this in for Kf 5.56 since there is string freeze. But if concatenation is a no go, this has to wait REPOS

D19102: Fix extraction of aspect ratio property

astippich updated this revision to Diff 52114. astippich added a comment. - do not use QString::number REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52104&id=52114 BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D

D18986: [breeze-icons] Add video camera icons

trickyricky26 commandeered this revision. trickyricky26 added a reviewer: rooty. trickyricky26 added a comment. I will make some minor changes to the 64px design. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty

D19101: Increase precision of frame rate property

astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

astippich updated this revision to Diff 52109. astippich added a comment. - do not use QString::number REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=52103&id=52109 BRANCH ffmpeg_framerate REVISION DETAIL https://phabricator.kde.org/D19

D19170: Fix crash while moving files

hallas created this revision. hallas added reviewers: Frameworks, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fix crash while moving files. The backtrace points towards the KJob

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added reviewers: elvisangelaccio, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas created this revision. hallas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fix crash in Dolphin when dropping trashed file in trash. The actual crash happens

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 21 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 19:52:18 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Feb 2019 19:52:18 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS abi-compa

D19102: Fix extraction of aspect ratio property

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > formatstrings.cpp:157 > +{ > +return QString(QString::number(round(value.toDouble() * 100) / 100) + > QStringLiteral(":1")); > +} Proper i18n REPOSITORY

D19101: Increase precision of frame rate property

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > formatstrings.cpp:152 > { > -return QString(value.toString() + i18nc("Symbol of frames per second, > with space", " fps")); > +return QString(QString::

D19102: Fix extraction of aspect ratio property

astippich updated this revision to Diff 52104. astippich added a comment. - rebase - use exact value for test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=51918&id=52104 BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.

D19101: Increase precision of frame rate property

astippich removed a dependency: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19100: Cleanup ffmpeg extractor

astippich removed a dependent revision: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19101: Increase precision of frame rate property

astippich updated this revision to Diff 52103. astippich added a comment. - rebase on master - use exact value in test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=51917&id=52103 BRANCH ffmpeg_framerate REVISION DETAIL https://phabr

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/25/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Feb 2019 19:21:03 + Build duration: 3 min 55 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 19:20:48 + Build duration: 3 min 8 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Feb 2019 19:17:17 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 19:17:17 + Build duration: 3 min 29 sec and counting CONSOLE OUTPUT [...trunca

D19100: Cleanup ffmpeg extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:96b08a1a601f: Cleanup ffmpeg extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19100?vs=51916&id=52102 REVISION DETAIL http

D19099: Add a test for ffmpeg extractor

This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:f4c72f517911: Add a test for ffmpeg extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52096. vandenoever added a comment. Clean up test by using QTest data. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52091&id=52096 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D19107 AFF

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52091. vandenoever added a comment. Remove duplicate if statement. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52090&id=52091 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D19107 AFFECTE

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52090. vandenoever added a comment. Added tests and code fixes to deal with overlong sequences and content above U+10. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52015&id=52090 BRANCH utf8 RE

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > vandenoever wrote in kconfigini.cpp:683 > A check for U+10 > value is needed. > Overlong sequences are caught on line 696 (count < 4). That's not what an overlong sequence is. You can produce 2-, 3- and 4-byte overlong sequences. See the examp

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19163: Make it possible to show all spaces in the document

apol created this revision. apol added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apol requested review of this revision. REVISION SUMMARY It's a feature offered by several editors. Now we allow to render none, only t

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > kconfigini.cpp:683 > +// When an additional byte leads to an invalid character, return > false. > +bool addByte(unsigned char b) { > +if (count == 0) { This function does operate properly to find valid syntax UTF-8 sequ

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QTextFormat::FontUnderline has been deprecated upstream for a long time. It seems that for s

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar updated this revision to Diff 52072. loh.tar edited the summary of this revision. loh.tar added a comment. Fix mentioned misplaced cursor. The reason was a special treatment for past-end-of-line cursors. The fix changed/fixed also that now the cursor is moved by one not two positions

D19156: port to findcanberra from ECM

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY also move to imported target available from that finder TEST PLAN it builds! REPOSIT

D18793: Handle text completion with block selection mode

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. we override execution in our own completion models, so this patch will only change the behavior for the builtin word and keyword completion models in ktexteditor I believe th

D19075: Fix FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:7c64db956829: Fix FindEGL (authored by tcberner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19075?vs=51847&id=52057 REVISION DETAIL https://phabr

D18952: new find module for Canberra

sitter updated this revision to Diff 52042. sitter added a comment. explicitly set FOUND_VAR so it is camelcase too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51976&id=52042 BRANCH master REVISION DETAIL https://phabricator.kd

D18952: new find module for Canberra

This revision was automatically updated to reflect the committed changes. Closed by commit R240:50e8dd7b2d00: new find module for Canberra (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=52042&id=52043 REVISION DETAIL

D18952: new find module for Canberra

sitter marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

broulik added a comment. Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: brun

D18952: new find module for Canberra

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks! just a little thing to fix before pushing INLINE COMMENTS > FindCanberra.cmake:75 > +find_package_handle_standard_args(Canberra > +REQUIRED_VARS > +Canberra_LI