vandenoever added inline comments. INLINE COMMENTS
> thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10FFFF > (UTF-8 can encode 0x11000 in 4 bytes). > > See > https://code.woboq.org/qt5/qtbase/tests/auto/corelib/codecs/utf8/utf8data.cpp.html#_Z19loadInvalidUtf8Rowsv > for potential UTF-8 pitfalls. A check for U+10FFFF > value is needed. Overlong sequences are caught on line 696 (count < 4). REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns
