bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> formatstrings.cpp:152
>  {
> -    return QString(value.toString() + i18nc("Symbol of frames per second, 
> with space", " fps"));
> +    return QString(QString::number(round(value.toDouble() * 100) / 100) + 
> i18nc("Symbol of frames per second, with space", " fps"));
>  }

No concatenation please, see
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy#Number_Formatting

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Reply via email to