D4911: add Baloo DBus signals for moved or removed files

mgallien added a comment. In https://phabricator.kde.org/D4911#92732, @mgallien wrote: > In https://phabricator.kde.org/D4911#92718, @cullmann wrote: > > > Just my 2 cents from the sideline: > > > > 1. baloo is unmaintained and the bugs pile up, just check bugs.kde.org for that, n

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas added a comment. In https://phabricator.kde.org/D4947#92995, @anthonyfieroni wrote: > Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :) lol! OK! Got it! I guess I can do that, although my initial motivation is

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 6, 2017, 7:44 преди обяд) Review request for KDE Frameworks

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

anthonyfieroni added a comment. Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #ktexteditor, #frameworks, mwolff Cc: anthonyfieroni

Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/ --- Review request for KDE Frameworks. Bugs: 37 https://bugs.kde.org/

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

This revision was automatically updated to reflect the committed changes. Closed by commit R296:859caaa50cdc: Don't set acceptHoverEvents in DragArea as we don't use them (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4919?vs

D4920: With Qt >= 5.8 use the new API to set scene graph backend

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0373754e61f0: With Qt >= 5.8 use the new API to set scene graph backend (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4920?vs=12

D4857: Use initialiser list

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8bedf84b73c: Use initialiser list (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4857?vs=12001&id=12209 REVISION

D4851: Implement FadingMaterial frag/vert shaders on core profile

This revision was automatically updated to reflect the committed changes. Closed by commit R242:23b70f4d4524: Implement FadingMaterial frag/vert shaders on core profile (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4851?vs=11986&id=12207#toc REPOSITORY R2

D4556: Ref/deref DataEngines even if the metadata is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit R242:586ed85561ac: Ref/deref DataEngines even if the metadata is invalid (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D4848: Split frag and vert code of FadingNode into separate files

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3b05f569ac29: Split frag and vert code of FadingNode into separate files (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 155 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/155/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 05 Mar 2017 23:27:20 + Build duration: 4 min 8 sec CHANGE SET No cha

D4931: Small cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a9fc22724c3: Small cleanups (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4931?vs=12152&id=12204 REVISION DETAIL https://

D4630: Only register APPLE_* options if(APPLE)

This revision was automatically updated to reflect the committed changes. Closed by commit R240:9d3abb5c88f9: Only register APPLE_* options if(APPLE) (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4630?vs=11401&id=12205 REVISIO

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas added a comment. In https://phabricator.kde.org/D4947#92889, @mwolff wrote: > You will have to create a separate interface for this, similar to what we have done in the past, with a TODO note that this should be merged in time for KF6. You mean an interface similar to Te

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. now that this API becomes public, it must be improved to make it better understandable to the public and note that you cannot add new virtual methods to this interface, as it

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY I'm creating a diff/patch frontend similar to Kompare but using KTextEditor to display/edit source/destination files. In order to be able

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/ --- (Updated March 5, 2017, 9:04 p.m.) Status -- This change has been ma

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/#review102728 --- Ship it! Ship It! - David Faure On March 5, 2017, 8 p.

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/ --- (Updated March 5, 2017, 8 p.m.) Review request for KDE Frameworks and Dav

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 367 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/367/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 05 Mar 2017 19:53:33 + Build duration: 2 min 17 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 367 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/367/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 05 Mar 2017 19:53:33 + Build duration: 2 min 17 sec CHANGE SET

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/#review102727 --- src/widgets/kurlrequester.h (line 133)

Review Request 129986: KUrlRequester does not allow proper save filedialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/ --- Review request for KDE Frameworks and David Faure. Bugs: 371685 https

D4941: Avoid a lot allocations in KConfig

This revision was automatically updated to reflect the committed changes. Closed by commit R237:75fd07b50074: avoid useless reallocs by removing squeeze call on temporary buffer (authored by cullmann). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4941?vs=121

D4941: Avoid a lot allocations in KConfig

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D4941 To: cullmann, #frameworks, dfaure

D4847: KAuth integration in document saving

dfaure added inline comments. INLINE COMMENTS > katesecuretextbuffer.cpp:1 > +#include "katesecuretextbuffer.h" > + Missing copyright header > katesecuretextbuffer.cpp:39 > +{ > +// QTemporaryFile sets permissions to 0600, so fixing this > +if (newFile) { Isn't it possible to call setP

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 5:58 p.m., David Faure wrote: > > Heh KDE3 is back (we had such functionality long ago). > > > > No objection about the feature itself, but can it be off by default? I hate > > computers that make noise^H^Hsounds unexpectedly. Can be very embarrassing > > when it happens ne

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 5:58 p.m., David Faure wrote: > > Heh KDE3 is back (we had such functionality long ago). > > > > No objection about the feature itself, but can it be off by default? I hate > > computers that make noise^H^Hsounds unexpectedly. Can be very embarrassing > > when it happens ne

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 260 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/260/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Mar 2017 18:06:30 + Build duration: 5 min 53 sec CHANGE SET Revision 854f6d3cd0e66c7a83087d0c9149b948b0298

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 260 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/260/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Mar 2017 18:06:30 + Build duration: 5 min 53 sec CHANGE SET Revision 854f6d3cd0e66c7a83087d0c9149b948b0298

Re: D4941: Avoid a lot allocations in KConfig

On Sunday, 5 March 2017 15:56:25 CET Christoph Cullmann wrote: > cullmann created this revision. > Restricted Application added a project: Frameworks. > > REVISION SUMMARY > Avoid a lot allocations in KConfig: We anyway free this QByteArray direcly > after use, no need to shrink it, which only l

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102722 --- Heh KDE3 is back (we had such functionality long ago). No o

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 7:51 след обяд) Review request for KDE Frameworks,

D4911: add Baloo DBus signals for moved or removed files

mgallien added a comment. In https://phabricator.kde.org/D4911#92718, @cullmann wrote: > Just my 2 cents from the sideline: > > 1. baloo is unmaintained and the bugs pile up, just check bugs.kde.org for that, not sure if adding yet-an-other feature to it is a good idea > 2. as vhand

Re: QFileDialog and KDE file dialogs

Am 04.03.2017 um 20:59 schrieb David Faure: On samedi 4 mars 2017 12:03:08 CET Frank Schäfer wrote: Hi, I'm trying to track down a bug which occurs when using QFileDialog::getSaveFileName in a Qt5-application. With option QFileDialog::DontUseNativeDialog a different dialog displayed, so a nati

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102721 --- thumbnail/audiocreator.cpp (line 213)

D4911: add Baloo DBus signals for moved or removed files

cullmann added a comment. Just my 2 cents from the sideline: 1. baloo is unmaintained and the bugs pile up, just check bugs.kde.org for that, not sure if adding yet-an-other feature to it is a good idea 2. as vhanda said, perhaps better use other API for that I tried to replace bal

D4847: KAuth integration in document saving

cullmann added a comment. Thanks, as my KAuth knowledge is very limited (aka 0), any other input on this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin,

D4941: Avoid a lot allocations in KConfig

cullmann created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Avoid a lot allocations in KConfig: We anyway free this QByteArray direcly after use, no need to shrink it, which only leads (if at all) to unnecessary allocations. Seen in e.g. heaptrack

D4911: add Baloo DBus signals for moved or removed files

mgallien added a comment. In https://phabricator.kde.org/D4911#92473, @vhanda wrote: > I'm not the maintainer of Baloo any more, so I don't want to give it a clear Yes / No. > > This patch is going to be a big CPU hog. For files this will barely have an impact, but for folders of a l

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik added reviewers: andreask, alex-l. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4633: WIP: Updated folder decrypted and encrypted icons

ivan added a comment. I didn't want to change the current icon that much. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 To: ivan, andreaska, alex-l Cc: #frameworks

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 5:02 след обяд) Review request for KDE Frameworks,

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >ins

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 2 p.m., Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >install

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >ins

Re: Review Request 127281: [kio-extras] Audio (id3) thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127281/ --- (Updated März 5, 2017, 2:01 nachm.) Status -- This change has been d

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102717 --- thumbnail/CMakeLists.txt (line 217)

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 11:54 a.m., Kai Uwe Broulik wrote: > > This superseds Review 127281? Yes, this one supports more formats - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12998

D4937: Add KFileWidget::setSelectedUrl()

dfaure added inline comments. INLINE COMMENTS > fvogt wrote in kfilewidget.h:150 > No, I meant setSelectedUrl indeed. It works for relative URLs as well. > Both the function itself and setLocationText check url.isRelative() Ah right, OK. But people are not going to URL-escape filenames and then

D4937: Add KFileWidget::setSelectedUrl()

fvogt added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidget.h:150 > I guess you mean "with setSelection". > I made setSelectedUrl handle only full URLs. No, I meant setSelectedUrl indeed. It works for relative URLs as well. Both the function itself and setLocationText check url.is

D4937: Add KFileWidget::setSelectedUrl()

dfaure added inline comments. INLINE COMMENTS > fvogt wrote in kfilewidget.h:150 > Currently that works with setSelectedUrl as well as it handles relative urls > (basically escaped filenames) as well, but it would definitely be a good > shortcut, so I'm for option #2 I guess you mean "with set

D4937: Add KFileWidget::setSelectedUrl()

fvogt added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidget.h:150 > Very good point. > > But there might be other users of this class who need the ability to select > by filename. > I think this means we have two options: > > - changing setSelection to only handle filenames, inc

D4937: Add KFileWidget::setSelectedUrl()

dfaure added inline comments. INLINE COMMENTS > fvogt wrote in kfilewidget.h:150 > This function only works correctly for URLs, as filenames can contain ':'s. > However, for those setSelectedUrl is the right function, so I'd mark this > function as deprecated Very good point. But there might be

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 10:21 a.m., Elvis Angelaccio wrote: > > thumbnail/audiothumbs.desktop, line 7 > > > > > > Not sure if wildcards are allowed by the .desktop specification. @David > > are they? > > Anthony Fier

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

dhaumann added a comment. Just for info: I just added a unit test for all View and Document config values (which immediately caught some bugs). So in future, we also need to extend the unit test whenever new entries are added to the ConfigInterface. REPOSITORY R39 KTextEditor REVISION DET

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102713 --- This superseds Review 127281? - Kai Uwe Broulik On März 5

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12185. martinkostolny added a comment. Understood and agreed, kauth_ktexteditor_helper it is :). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4847?vs=12181&id=12185 REVISION DETAIL https://phabricator.kde

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 1:27 след обяд) Review request for KDE Frameworks,

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 12:21 след обяд, Elvis Angelaccio wrote: > > thumbnail/audiothumbs.desktop, line 7 > > > > > > Not sure if wildcards are allowed by the .desktop specification. @David > > are they? It should be

D4847: KAuth integration in document saving

cullmann added a comment. Thanks for in cooperating my advice! I think for the naming, we could just call it kauth_ktexteditor_helper. That makes clear what it is and with ktexteditor in the name, we will not have clashs, or? We should avoid new "kate.." names in the installation as actu

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2df4c40ea27a: Added font and on-the-fly-spellcheck options in ConfigInterface (authored by jsalatas). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4940?vs=12182

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

jsalatas added a comment. In https://phabricator.kde.org/D4940#92656, @dhaumann wrote: > Looks good, please commit. Do you have commit rights, or should I commit for you? Committed. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4940 To: jsa

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good, please commit. Do you have commit rights, or should I commit for you? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4940 To: jsalatas, #frame

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102711 --- +1 I've been using it for a while and works fine (from [her

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

jsalatas added a comment. In https://phabricator.kde.org/D4940#92646, @dhaumann wrote: > In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-) Ooops! My bad :) Added > And thinking about it mo

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

jsalatas updated this revision to Diff 12182. jsalatas added a comment. Added documentation for the new options in configinterface.h REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4940?vs=12180&id=12182 REVISION DETAIL https://phabricator.kde.org/D494

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-) And thinking about it more, it also

D4847: KAuth integration in document saving

martinkostolny marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfu

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12181. martinkostolny added a comment. Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful. One thing I've noticed - it seems there isn't any naming convention for KAuth helper binary. Sometimes

D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface

jsalatas created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - Added "font" option in View's ConfigInterface - Added "on-the-fly-spellcheck" option in View's ConfigInterface TEST PLAN Tested in