> On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > <https://git.reviewboard.kde.org/r/129985/diff/2/?file=492266#file492266line241> > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > > install(FILES audiothumbnail.desktop DESTINATION > > ${SERVICES_INSTALL_DIR}) > > endif() > > ```
Yeah, i want to do this. Why it will not work? > On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, line 217 > > <https://git.reviewboard.kde.org/r/129985/diff/2/?file=492266#file492266line217> > > > > What's the minimum taglib version required? I think we need at least > > 1.11? Yeap. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102717 ----------------------------------------------------------- On Март 5, 2017, 1:27 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129985/ > ----------------------------------------------------------- > > (Updated Март 5, 2017, 1:27 след обяд) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kio-extras > > > Description > ------- > > ^^ > > > Diffs > ----- > > cmake/FindTaglib.cmake PRE-CREATION > thumbnail/CMakeLists.txt da6e4233 > thumbnail/audiocreator.h PRE-CREATION > thumbnail/audiocreator.cpp PRE-CREATION > thumbnail/audiothumbnail.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129985/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
