dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed.
In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-) And thinking about it more, it also would be nice to have unit tests for the config interface, we need to add that later. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4940 To: jsalatas, #ktexteditor, #frameworks, dhaumann Cc: dhaumann, kwrite-devel