----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102717 -----------------------------------------------------------
thumbnail/CMakeLists.txt (line 217) <https://git.reviewboard.kde.org/r/129985/#comment68376> What's the minimum taglib version required? I think we need at least 1.11? thumbnail/CMakeLists.txt (lines 241 - 243) <https://git.reviewboard.kde.org/r/129985/#comment68374> This does not work, if you need to do: ``` if (TAGLIB_FOUND) install(FILES audiothumbnail.desktop DESTINATION ${SERVICES_INSTALL_DIR}) endif() ``` thumbnail/audiocreator.h (line 36) <https://git.reviewboard.kde.org/r/129985/#comment68375> Not needed, remove it. - Elvis Angelaccio On March 5, 2017, 11:27 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129985/ > ----------------------------------------------------------- > > (Updated March 5, 2017, 11:27 a.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kio-extras > > > Description > ------- > > ^^ > > > Diffs > ----- > > cmake/FindTaglib.cmake PRE-CREATION > thumbnail/CMakeLists.txt da6e4233 > thumbnail/audiocreator.h PRE-CREATION > thumbnail/audiocreator.cpp PRE-CREATION > thumbnail/audiothumbnail.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129985/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
