Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-02-05 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/ --- (Updated Фев. 6, 2016, 9:19 преди обяд) Status -- This change has be

Re: Review Request 126955: Fix crash in activities context menu

2016-02-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/ --- (Updated Feb. 6, 2016, 1:23 a.m.) Review request for KDE Frameworks. Bu

FileManager1 wrapper in KIO/KRun (re-sent)

2016-02-05 Thread Kai Uwe Broulik
(seems BlackBerry 10 doesn't think anyone would want to send plain-text Emails, sorry for the previous html screw-up) Hi everyone, ‎ There's a FDO DBus interface [1] to tell a file manager to highlight a given file in a directory. This is interface is provided by Nautilus and Dolphin and proba

FileManager1 wrapper in KIO/KRun

2016-02-05 Thread Kai Uwe Broulik
Hi everyone, There's a FDO DBus interface [1] to tell a file manager to highlight a given file in a directory. This is interface is provided by Nautilus and Dolphin and probably others and used by some third party applications like Firefox, Gimp iirc.We have many places where we want to show the p

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread David Faure
> On Feb. 5, 2016, 12:36 p.m., David Faure wrote: > > Looks good to me. Ideally I'd like Dawit to take a look, but if he doesn't, > > feel free to push. > > Especially since the release is tomorrow, and I guess you'd like this in ;) > > Krzysztof Nowicki wrote: > Sorry for noob question, bu

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
> On Feb. 5, 2016, 1:36 p.m., David Faure wrote: > > Looks good to me. Ideally I'd like Dawit to take a look, but if he doesn't, > > feel free to push. > > Especially since the release is tomorrow, and I guess you'd like this in ;) Sorry for noob question, but how do I push this? I don't think

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126990/#review92081 --- Ship it! Looks good to me. Ideally I'd like Dawit to take

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-05 Thread Krzysztof Nowicki
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated Feb. 5, 2016, 12:56 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 228 - Still Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/228/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 11:24:19 + Build duration: 15 min CHANGE SET Revision 1c8efdd78836b5cd609c59f494dd1cbd622b1d8c by Dav

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 219 - Still Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/219/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 11:24:19 + Build duration: 8 min 19 sec CHANGE SET Revision 1c8efdd78836b5cd609c59f494dd1cbd62

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-05 Thread Krzysztof Nowicki
> On Feb. 5, 2016, 9:38 a.m., David Faure wrote: > > What if this kio_http instance is then reused to connect to another host? > > Shouldn't these lists ("blacklisted auth methods" etc.) be cleared? Fair point. I guess the blacklist needs to be cleared upon disconnecting from the server. I'll

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
> On Feb. 5, 2016, 9:36 a.m., David Faure wrote: > > autotests/http/httpauthenticationtest.cpp, line 73 > > > > > > What if key.size() > 64? (this goes out of bounds, then). Or is this > > always ensured by the

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126990/ --- (Updated Feb. 5, 2016, 12:17 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 227 - Still Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/227/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 09:18:02 + Build duration: 8 min 45 sec CHANGE SET Revision 48af09519bafb71130b9dd4a025834ac98624060

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 218 - Still Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/218/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 09:18:02 + Build duration: 7 min 44 sec CHANGE SET Revision 48af09519bafb71130b9dd4a025834ac98

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92075 --- What if this kio_http instance is then reused to connect to a

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 226 - Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 08:22:50 + Build duration: 15 min CHANGE SET Revision 1510bea556fdc973af3872636d067b9978b83f53 by Dav

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126990/#review92074 --- autotests/http/httpauthenticationtest.cpp (line 73)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 217 - Unstable!

2016-02-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/217/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 08:22:55 + Build duration: 8 min 41 sec CHANGE SET Revision 1510bea556fdc973af3872636d067b9978

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126963/ --- (Updated Feb. 5, 2016, 8:22 a.m.) Status -- This change has been mar