-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/
-----------------------------------------------------------
(Updated Feb. 6, 2016, 1:23 a.m.)
Review request for KDE Frameworks.
Bugs: 351485
http://bugs.kde.org/show_bug.cgi?id=351485
Repository: kactivities
Description
-------
Currently we call deleteLater() from inside ::run which is running in a
different thread than the receiving object.
(QThread objects live in the thread that created them, not in the thread they
create)
This patch causes deleteLater to be run in the right thread.
QCoreApplication::postEvent is thread safe but it needs to be in the right
thread to work out the correct event loop level for deferred delete events.
BUG: 351485
Diffs (updated)
-----
src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp
a88713204c95d7c4a7502a1b31ca51962186a555
src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.h
50dccc5c80b24af9d38ddb021d4c69a2348630a5
src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp
3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a
Diff: https://git.reviewboard.kde.org/r/126955/diff/
Testing
-------
Right click in dolpin. Still works.
Couldn't reproduce the original crash, so I don't know for sure it fixes it.
Debug in qcoreapplication showed we got a different eventLoopLevel on the
QDeferredDeleteEvent
Thanks,
David Edmundson
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
