> On Feb. 5, 2016, 9:38 a.m., David Faure wrote:
> > What if this kio_http instance is then reused to connect to another host?
> > Shouldn't these lists ("blacklisted auth methods" etc.) be cleared?
Fair point. I guess the blacklist needs to be cleared upon disconnecting from
the server. I'll submit a fix.
- Krzysztof
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126991/#review92075
-----------------------------------------------------------
On Feb. 4, 2016, 5:01 p.m., Krzysztof Nowicki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126991/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 5:01 p.m.)
>
>
> Review request for KDE Frameworks and Dawit Alemayehu.
>
>
> Repository: kio
>
>
> Description
> -------
>
> When authenticating agains a server offering multiple authentication methods
> make sure to attempt other methods in case the best one fails.
>
> This also fixes a connection close issue in the middle of an NTLM
> authentication dialog due to clearing the password.
>
>
> Diffs
> -----
>
> src/ioslaves/http/http.h 621b2c7
> src/ioslaves/http/http.cpp a84129f
>
> Diff: https://git.reviewboard.kde.org/r/126991/diff/
>
>
> Testing
> -------
>
> I have performed testing on an IIS 7.5 server which offered 3 authentication
> options: Negotiate, NTLM and Basic. Since I have Kerberos configured the
> original code would only try Negotiate and because it failed it would retry
> it endlessly. With this patch authentication correctly falls back to NTLM or
> Basic (if NTLM fails too).
>
>
> Thanks,
>
> Krzysztof Nowicki
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
