----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126990/#review92081 -----------------------------------------------------------
Ship it! Looks good to me. Ideally I'd like Dawit to take a look, but if he doesn't, feel free to push. Especially since the release is tomorrow, and I guess you'd like this in ;) - David Faure On Feb. 5, 2016, 11:17 a.m., Krzysztof Nowicki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126990/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 11:17 a.m.) > > > Review request for KDE Frameworks and Dawit Alemayehu. > > > Repository: kio > > > Description > ------- > > Some IIS servers seem to be configured to reject NTLMv1 authentication by > refusing to reply to a NTLM stage 1 if the NTLMv2 flag is not set. If such a > thing happens try to send another stage 1 message with the NTLMv2 flag set > and if the server accepts this continue with NTLMv2. > > This also fixes invese logic when determining if the authentication needs a > password (it needs it during stage 3 response and not stage 1). > > As a bonus this includes a test case for verifying NTLMv2 authentication and > a fix for one of the existing test cases which contained wrong expected data > (the expected response was generated without use of username and password due > to the inverse logic bug above). > > > Diffs > ----- > > autotests/http/httpauthenticationtest.h > 35b822a0d400959d97e11473d48bc94352e8e5b3 > autotests/http/httpauthenticationtest.cpp > 719f7a9856194003cfba52848e0a6c5ea6324531 > src/ioslaves/http/httpauthentication.h > a74565e253ad489fed6c82116c72244386ebaaf2 > src/ioslaves/http/httpauthentication.cpp > dcc86c276fa4422fb08904b5cf6d3d2db6bb4c0d > src/kntlm/kntlm.cpp ed6f3881f3dfd0b78069368db22f7cd865261738 > > Diff: https://git.reviewboard.kde.org/r/126990/diff/ > > > Testing > ------- > > Tested on an IIS 7.5 server with NTLMv1 blacklisted. Additionally executed > automatic tests without regressions. > > > Thanks, > > Krzysztof Nowicki > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
