Re: Review Request 126717: Fix DBus service name of polkit agent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126717/ --- (Updated Jan. 12, 2016, 7:19 a.m.) Status -- This change has been ma

Re: qml file install location

On Mon, Jan 11, 2016 at 4:08 AM, René J.V. wrote: > Hello, > > How do KF5 framework, application etc. projects determine the install > location for their qml files? > > I see that KDeclarative itself already refers to 2 CMake variables to > define that location, KDE_INSTALL_QMLDIR and QML_INSTALL

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

> On Jan. 11, 2016, 9:12 a.m., Martin Gräßlin wrote: > > I'm interested in the reasoning why to put it into KIdleTime? My first > > thought would have been Solid, so I'm interested in the reasoning. It was suggested in the original review (https://git.reviewboard.kde.org/r/126627/), it's basic

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

> On Jan. 11, 2016, 1:05 p.m., Martin Gräßlin wrote: > > src/inhibition.h, lines 32-34 > > > > > > Please use lock screen instead of screensaver. These things don't exist > > anymore ;-) xscreensaver? Also the i

Re: QSP patch/activator

On Sunday 10 January 2016 21:52:13 René J.V. Bertin wrote: > You meant inter-INdependent I suppose? Yes, of course. > Sadly I had completely forgotten I'd ever heard about KDE, 4 years ago (and > wasn't where I was ATM, development wise). If I'd have known what I know now > I'd have defended K

Re: Review Request 126717: Fix DBus service name of polkit agent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126717/#review90921 --- Ship it! Ship It! - David Edmundson On Jan. 11, 2016, 3:59

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is dep

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is dep

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

> On Jan. 10, 2016, 7:04 p.m., David Faure wrote: > > src/ioslaves/http/kcookiejar/kcookiejar.json, line 96 > > > > > > Why was this set to false (and autoload to true) when the > > kcookiejar.desktop file had >

Review Request 126717: Fix DBus service name of polkit agent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126717/ --- Review request for KDE Frameworks and David Edmundson. Repository: kauth

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? KGlobalSettings is deprecated in KF5. I recommend quering

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 10, 2016, 11:33 p.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 80 > > > > > > this ';' seems unnecessary and weird, it's the end of an if() block. Stray junk indeed. - Thomas

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/228/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:43 + Build duration: 3 min 23 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/228/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:43 + Build duration: 3 min 23 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:46 + Build duration: 2 min 52 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:46 + Build duration: 7 min 8 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:46 + Build duration: 2 min 52 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:46 + Build duration: 7 min 8 sec CHANGE SET

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:38 + Build duration: 5 min 23 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:38 + Build duration: 5 min 23 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/228/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:43 + Build duration: 7 min 18 sec CHANGE SET No cha

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/228/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:43 + Build duration: 7 min 18 sec CHANGE SET No cha

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 195 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:41 + Build duration: 5 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 195 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 14:44:41 + Build duration: 5 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/#review90902 --- qt5/style/qtcurve_api.cpp (line 3211)

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_ ma

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 12:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_ m

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 182 > > > > > > Why is clazy complaining here? I think the .first() API is actually > > quite nice, don't see anything wr

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90890 --- autotests/coronatest.cpp (line 182)

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote: > > >Gwenview switches to a dark palette when in fullscreen mode for instance > > > > and how does this help solve that? There's no method to get a palette from > > a ColorSet that may be useful to add then? - Marco ---

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90886 --- >Gwenview switches to a dark palette when in fullscreen mode f

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90884 --- nice work! src/CMakeLists.txt (line 27)

Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126712/#review90883 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016, 9

Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/#review90885 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016, 1

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/#review90882 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016, 7

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90879 --- +1 from me, too. - Sebastian Kügler On Jan. 5, 2016, 11:16

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90871 --- ping? - Marco Martin On Jan. 5, 2016, 11:16 a.m., Marco Mar

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90869 --- Ship it! Ship It! - Martin Gräßlin On Jan. 10, 2016, 10:58

Re: Draft split for qpt plugin from frameworkintegration

Am 2016-01-06 22:18, schrieb Albert Astals Cid: El Friday 18 December 2015, a les 10:03:39, Martin Graesslin va escriure: On Thursday, December 17, 2015 5:48:47 PM CET Martin Graesslin wrote: > On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > > On Wed, Dec 16, 2015 at 4:12 PM, Ma

qml file install location

Hello, How do KF5 framework, application etc. projects determine the install location for their qml files? I see that KDeclarative itself already refers to 2 CMake variables to define that location, KDE_INSTALL_QMLDIR and QML_INSTALL_DIR, neither of which appears to be set anywhere that I can

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 08:43:03 + Build duration: 2 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 08:43:03 + Build duration: 2 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 08:43:00 + Build duration: 1 min 35 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 08:43:00 + Build duration: 1 min 35 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90867 --- I'm interested in the reasoning why to put it into KIdleTime?