> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote:
> > Perfect use of the message panel. However, the red close icon does not work 
> > (well) with colored backgrounds.
> 
> Kai Uwe Broulik wrote:
>     Do we even need the close button to begin with? It's not like it 
> appearing is really under your direct control anyway.
> 
> Thomas Pfeiffer wrote:
>     I agree with Kai: No need for a close button there, since the message 
> widget disappears anyway as soon as the user fixes the problem.
> 
> Heiko Tietze wrote:
>     Not so sure. Popups should have means to get closed manually. Otherwise 
> you may argue that plasma notifications also do not need any close 
> interaction. And the HIG talks about the option to dismiss the panel. So 
> either we change it everywhere and update the HIG or we find a good reason 
> why it is not neccessary here. My position is clear: Don't use color as the 
> primary indicator, i.e. do not color the whole icon. Colored decorations are 
> okay.
> 
> Elvis Angelaccio wrote:
>     So, should I leave it? If the close button needs to be fixed, I think 
> should be done independently from this patch.
> 
> Thomas Pfeiffer wrote:
>     The red close icon and the close button on panels are two independent 
> issues, which are both independent from this patch.
>     Therefore, neither of them would block you from shipping this patch.
>     If the close icon is changed, you do not have to change anything in your 
> code, anyway. If we decide that being able to close message panels manually 
> is not necessary in all cases (this is a decision that has to be made on a 
> HIG-level, not on an individual basis) we'll get in touch with you and ask 
> you to remove the close button here (in a separate patch).
>     That's why Heiko already gave a "Ship it" from the usability side (the 
> technical review is independent from this).
> 
> Elvis Angelaccio wrote:
>     All right. Waiting for the code ship-it, then :)

> Waiting for the code ship-it, then :)

Ping?


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/#review90137
-----------------------------------------------------------


On Dec. 26, 2015, 10:18 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126523/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 10:18 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and 
> Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Currently a KNewPasswordDialog makes use of a KTitleWidget to display 
> messages to the user about the password status (e.g. "password too short", 
> etc.). This looks out of place, and so does the associated icon (see 
> screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )
> 
> This patch replaces the KTitleWidget with a KMessageWidget. I also 
> "downgraded" some of the previous "error" red icons to a 
> `KMessageWidget::Warning` type (the orange one in the screenshots), because 
> those kind of messages may be displayed before the user even started typing 
> something as password.
> 
> 
> Diffs
> -----
> 
>   src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
>   src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 
> 
> Diff: https://git.reviewboard.kde.org/r/126523/diff/
> 
> 
> Testing
> -------
> 
> The KMessageWidgets behaves exactly like the KTitleWidget before: initially 
> is hidden, then is displayed as soon as the user interacts with the password 
> fields.
> 
> 
> File Attachments
> ----------------
> 
> pwd-dialog-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
> pwd-dialog-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
> pwd-dialog-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to