> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > <https://git.reviewboard.kde.org/r/126624/diff/1/?file=428407#file428407line3211> > > > > Should this be turned on only when KF5 is enabled?
KGlobalSettings is deprecated in KF5. I recommend quering it from QCommonStyle or KStyle though, they both provide the value through `SH_DialogButtonBox_ButtonsHaveIcons`. If none of these aren't bases of QtCurve (I don't know about its internals), then the raw KConfig value should be queried (See `KStyle` to see how to implement it). - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/#review90902 ----------------------------------------------------------- On Jan. 4, 2016, 5:28 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126624/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 5:28 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu. > > > Repository: qtcurve > > > Description > ------- > > Implementation details have changed in Qt5 that affect when icons were being > shown in pushbuttons; as a result, many buttons were drawn with icons visible > regardless the `ShowIconsInButtons` preference. > > This patch implements a solution in the Qt5 style itself, which appears to be > the only way to respect the preference both robustly (= on all buttons) and > reversibly (i.e. icons will appear or disappear when toggling the setting > without need to restart running applications). > Buttons that have only an icon but no text will continue to show the icon. > > Note that `KGlobalSettings::showIconsOnPushButtons()` is deprecated and will > have to be replaced with something that is not... > > > Diffs > ----- > > qt5/style/qtcurve_api.cpp 9b7adfa > > Diff: https://git.reviewboard.kde.org/r/126624/diff/ > > > Testing > ------- > > On OS X 10.9.5 and Linux, both with Qt 5.5.1 and KF5 5.17.0 installed into > /opt/local > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel