Re: Review Request 126149: [Icon widget] Bring back properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review89023 --- applets/icon/plugin/icon_p.cpp (line 203)

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/#review89022 --- Please kind in mind that kded must be able to pop up dialogs,

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89021 --- Overall I think this is now too much code duplication. With th

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126189/#review89020 --- Ship it! Ship It! - David Faure On Dec. 2, 2015, 3:51 a.m.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89019 --- Just wondering: if your main aim is to change default settings

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Dec 2015 07:24:50 + Build duration: 2 min 39 sec CHANGE SET Revision 3123816b1765108ccf699661656ac1fa939

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Dec 2015 07:24:50 + Build duration: 2 min 39 sec CHANGE SET Revision 3123816b1765108ccf699661656ac1fa939

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Dec 2015 07:24:50 + Build duration: 2 min 43 sec CHANGE SET Revision 3123816b1765108ccf699661656ac1fa9397cab3 b

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Dec 2015 07:24:50 + Build duration: 2 min 43 sec CHANGE SET Revision 3123816b1765108ccf699661656ac1fa9397cab3 b

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126189/ --- (Updated Dec. 2, 2015, 3:51 a.m.) Review request for KDE Frameworks and D

Re: Updating techbase wiki page according to KF5 policies

On 2015-12-01 15:34, Martin Walch wrote: On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: On 2015-11-14 01:21, Martin Walch wrote: > Alright, so I have created a stub at > > https://techbase.kde.org/Policies/Frameworks_Coding_Style > > ... > > Qt includes > * For Qt #includes omit th

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89009 --- src/platformtheme/kdemactheme.mm (lines 53 - 87)

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89008 --- A couple of things I jotted down today, probably open doors bu

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 1, 2015, 9:29 p.m.) Review request for KDE Software on Mac

Re: KDE PIM Split?

On 2015-12-01 09:06, laurent Montel wrote: Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > El 1 dic 2015, a las 05:10, Ben Cooksley escribió: >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> >> Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >>> Hi

Re: Purpose as a KDE Framework

On Dienstag, 1. Dezember 2015 15:01:10 CET Aleix Pol wrote: Hi, looks really interesting! > I'd like to see it used in other cases than sharing as well as in other applications Would you accept a plugin which can be used to compare selected files? - e.g. by starting kompare This would replace

Re: Purpose as a KDE Framework

On 1 December 2015 at 20:42, Aleix Pol wrote: >> 1. I'd like to be able to load the list of plugins available per >> mimetype a priori before the filename to share becomes available. > You can pass { "mimetype": "image/png", "urls": [] }. > > That should work. > I'm not sure why you'd want to list

Re: Purpose as a KDE Framework

AlternativesModel doesn't seem like a good name. Alternate to what? - /** @returns the job that will perform the share of the specified @p data.*/ what data? -- Does the JSON blob in Job::setData() match the X-Purpose-OutboundArguments of that plugin? I don't seem to be able to ac

Re: Updating techbase wiki page according to KF5 policies

On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: > On 2015-11-14 01:21, Martin Walch wrote: > > Alright, so I have created a stub at > > > > https://techbase.kde.org/Policies/Frameworks_Coding_Style > > > > ... > > > > Qt includes > > * For Qt #includes omit the module name and only us

Re: Purpose as a KDE Framework

On Tue, Dec 1, 2015 at 4:24 PM, Kai Uwe Broulik wrote: >> you can build any view you want on top of it and the API is > public and (should be) stable. > > Yes but some services require additional information and provide a QML UI for > that.‎ And that one will look out of place if using Plasma Com

AW: Purpose as a KDE Framework

> you can build any view you want on top of it and the API is public and (should be) stable. Yes but some services require additional information and provide a QML UI for that.‎ And that one will look out of place if using Plasma Components and used in a widget environment, or limited to basic s

Re: Purpose as a KDE Framework

On Tue, Dec 1, 2015 at 4:01 PM, Boudhayan Gupta wrote: > On 1 December 2015 at 19:31, Aleix Pol wrote: >> Hi, >> I've been working on Purpose since some months now, with the intention >> of becoming a framework some day. > > +1. I intend to port Spectacle to use it instead of KIPI for uploading >

Re: Purpose as a KDE Framework

On Tue, Dec 1, 2015 at 4:05 PM, Kai Uwe Broulik wrote: > Yes please! > > I recently discovered Quick Share and was surprised that we didn't market > this stuff more :) > > One thing I wasn't sure is where the share assistant UIs are going to be > used, ie. if they're Plasma exclusive or can be u

Re: Purpose as a KDE Framework

On 1 December 2015 at 19:31, Aleix Pol wrote: > Hi, > I've been working on Purpose since some months now, with the intention > of becoming a framework some day. +1. I intend to port Spectacle to use it instead of KIPI for uploading images to online sites, and I love the API's simplicity. I only

Re: Purpose as a KDE Framework

Yes please!  I recently discovered Quick Share and was surprised that we didn't market this stuff more :) One thing I wasn't sure is where the share assistant UIs are going to be used, ie. if they're Plasma exclusive or can be used from (widget) applications, too. The latter limits us to bare

Re: Purpose as a KDE Framework

On Tue, Dec 1, 2015 at 3:31 PM, Martin Graesslin wrote: > On Tuesday, December 1, 2015 3:01:10 PM CET Aleix Pol wrote: >> Hi, >> I've been working on Purpose since some months now, with the intention >> of becoming a framework some day. Some information about it can be >> read here: >> https://pro

Re: Purpose as a KDE Framework

On Tuesday, December 1, 2015 3:01:10 PM CET Aleix Pol wrote: > Hi, > I've been working on Purpose since some months now, with the intention > of becoming a framework some day. Some information about it can be > read here: > https://projects.kde.org/projects/playground/libs/purpose/repository/revisi

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/#review88999 --- src/kstatusnotifieritem.cpp (line 804)

Purpose as a KDE Framework

Hi, I've been working on Purpose since some months now, with the intention of becoming a framework some day. Some information about it can be read here: https://projects.kde.org/projects/playground/libs/purpose/repository/revisions/master/entry/README.md As it is right now it's a tier 2 framework

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 1, 2015, 2:03 p.m.) Review request for KDE Software on Mac

Re: Review Request 126161: OS X housekeeping

On Tuesday December 01 2015 10:35:47 René J.V. Bertin wrote: >Your patch only modifies launch() IIRC. If my understanding is correct, then >that means kdeinit will fail if it decides to use the kdeinit module, because >that decision is not made inside launch(). Or maybe the truth is somewhere i

Re: Review Request 126161: OS X housekeeping

On Tuesday December 01 2015 09:56:15 David Faure wrote: > >Yes - which is exactly what my suggested patch does, AFAICS. Your patch only modifies launch() IIRC. If my understanding is correct, then that means kdeinit will fail if it decides to use the kdeinit module, because that decision is not

Re: KDE PIM Split?

Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > > El 1 dic 2015, a las 05:10, Ben Cooksley escribió: > >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: > >> > >> Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > >>> Hi Pim devels, > >> > >> Hi, > >> So

Re: KDE PIM Split?

On Tue, Dec 1, 2015 at 9:46 PM, laurent Montel wrote: > Le mardi 1 décembre 2015, 21:10:57 CET Ben Cooksley a écrit : >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> > Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >> >> Hi Pim devels, >> > >> > Hi, >> > So I reorganiz

Re: Review Request 126161: OS X housekeeping

On Tuesday 01 December 2015 09:53:06 René J.V. Bertin wrote: > > The entry point into kdeinit is "start kwrite please". kdeinit decides > > whether to do that using the kdeinit module (.so) or the executable. > > So what you're saying is that we should be fine (by design) if I remove the > bit w

Re: Review Request 126161: OS X housekeeping

On Monday November 30 2015 09:01:25 David Faure wrote: Hi, >I never realized you could pass a shared lib to kwrapper5, that is definitely >not the intended usage, and I can tell you, nobody does this ;) Ok, just to get this straight: it doesn't make sense to pass a shared lib to kwrapper5, but

Re: KDE PIM Split?

> El 1 dic 2015, a las 05:10, Ben Cooksley escribió: > >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >>> Hi Pim devels, >> >> Hi, >> So I reorganized source yesterday. >> I verified that all was ok >> So how I do now

Re: KDE PIM Split?

Le mardi 1 décembre 2015, 21:10:57 CET Ben Cooksley a écrit : > On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: > > Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > >> Hi Pim devels, > > > > Hi, > > So I reorganized source yesterday. > > I verified that all was ok > > So how

Re: KDE PIM Split?

On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: > Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >> Hi Pim devels, > > Hi, > So I reorganized source yesterday. > I verified that all was ok > So how I do now to split ? The splitting of the repositories can be conducted using