----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/#review89022 -----------------------------------------------------------
Please kind in mind that kded must be able to pop up dialogs, though. (cookie dialog, SSL cert messagebox + dialog, etc. etc.). If making it an "agent" doesn't prevent it from showing GUI elements now and then, then no problem. - David Faure On Nov. 25, 2015, 6:12 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126170/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 6:12 p.m.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: kded > > > Description > ------- > > There should be no reason to build `kded5` as an app bundle on OS X, and with > recent feedback in mind I postulated that marking it "nongui" > (`ecm_mark_nongui_application`) would be acceptable on other platforms too. > > Additionally, `kded5` doesn't have any more reason to appear in the Dock or > app switcher, on OS X, so I have added the code to make it an agent. > > > Diffs > ----- > > CMakeLists.txt 4b9a5ff > src/CMakeLists.txt 5e95df8 > src/kded.cpp 6929d7d > > Diff: https://git.reviewboard.kde.org/r/126170/diff/ > > > Testing > ------- > > On OS X 10.9.5 with Qt 5.5.1 and FWs 5.16.0 . > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
